projecthydra-labs / orcid

95%

master: 94%

LAST BUILD ON BRANCH updating-profile-request-sequence

branch: updating-profile-request-sequence

CHANGE BRANCH

x

Reset

• updating-profile-request-sequence
• 41-after-profile-creation-request-behavior
• adding-ability-to-test-orcid-end-to-end
• adding-coveralls-support
• adding-disconnect-user-from-profile
• adjusting-collaborators-for-profile-connection
• appeasing-code-climate
• expanding-code-coverage
• improving-code-coverage
• internationalizing-views
• master
• renaming-parameters-to-reflect-reality
• teasing-apart-coveralls-behavior
• updating-specs-to-pass-with-rspec-bridge
• v0.8.1
• v0.8.2
• v0.8.3
• v0.9.0
• v0.9.1

Build # 283

Build Type

push

travis-ci

Committed by jeremyf

Commit Message

Introducing ProfileRequestCoordinator

Responsible for converting an Orcid::ProfileRequest into an
Orcid::Profile.

The Orcid::ProfileRequest object was doing too many things (i.e.
persisting the profile request then handling the remote interaction
with orcid.org).

I'm trying to tease apart the offline coordinator for the profile
request. Basically separating the persistence of the initial request
to processing that persisted request.

Also, this pull request includes adjusting Orcid exceptions
inheritance.

I want to provide a base error from which Orcid errors are built from.
That way, someone could feasibly rescue an Orcid::BaseError exception
and handle in a uniform manner.

Run Details

760 of 796 relevant lines covered (95.48%)

2.88 hits per line