• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

projecthydra-labs / hydra-pcdm
100%
master: 100%

Build:
Build:
LAST BUILD BRANCH: v0.8.0
DEFAULT BRANCH: master
Repo Added 12 May 2015 02:23PM UTC
Files 20
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH remove-memoized-object-in-which-state-is-unneeded
branch: remove-memoized-object-in-which-state-is-unneeded
CHANGE BRANCH
x
Reset
  • remove-memoized-object-in-which-state-is-unneeded
  • 0.2.0
  • 189-encapsulate-solr-keys
  • 214-create-a-collection-validator
  • af_980
  • af_ids_reader
  • allowing-ruby-2.3-in-build-matrix
  • autorubocopification
  • bump_dep
  • clean_suite
  • consolidation
  • coverage
  • extending-file
  • file-schemas
  • file_services_and_filtering
  • file_tech_metadata
  • finding_parents
  • fix_119_ancestor_fails
  • fix_119_ck_ids_before_objects
  • fix_137_use_filters
  • fix_append_tests
  • fix_coverage_badge
  • fix_file_validation
  • fix_rubocop
  • improve_object_tests
  • include_wrapper_rake_tasks
  • indexer_class_method
  • jetty_config
  • linked_files_escowles
  • loosen_version_req
  • master
  • member_of_empty
  • members_shovel
  • mime_types
  • namespace_vocabs
  • new_ordering
  • new_service_for_removing
  • obj_val_full_tests_plus_child_parent_rework
  • object_ids
  • objects_validations
  • objects_validations_full_tests
  • opt_test_add_collection
  • opt_test_add_related_object
  • opt_test_get_services
  • opt_test_remove_services
  • optimize_coll_add_object_spec
  • parent_becomes_in
  • parent_child_refactor
  • parent_objects_refactor
  • pcdm_resource_validation
  • pcdmissue140
  • performance_tests
  • prefer-module-function-over-class
  • refactor_object_spec
  • remove-memoization-of-a-constant
  • remove_<<_from_services
  • remove_append
  • remove_filter_accessors
  • remove_haml-lint
  • remove_todo
  • remove_uneeded_child_object_ids
  • removing-redundancy
  • rename_collection
  • reorder_members
  • rubocop_autocorrect_rspec
  • services_addXtoY
  • services_addXtoY_getXfromY
  • solrizing
  • test_object_ancestors
  • type_validators
  • undo
  • unordered_collections
  • update_af_agg
  • update_af_aggregation
  • update_dependencies
  • v0.0.1
  • v0.1.0
  • v0.3.0
  • v0.3.1
  • v0.3.2
  • v0.4.0
  • v0.5.0
  • v0.6.0
  • v0.7.0
  • v0.8.0
  • v0.8.0.beta1
  • versioned_file
  • with-metadata-schema

pending completion
610

push

travis-ci

jeremyf
Renaming opaque `.call` method

When I was orienting to the code, it took a bit to understand the
ancestor? method ordering and purpose. As I was extracting a module
function, I opted to go with `.call`. However, when I went back to the
method, I had to once again reorient to what was going on.

So I opted for the new method name `.former_is_ancestor_of_latter?`.
This resulted in a change in parameter order. To preserve parameter
order, I considered the method `.latter_is_ancestor_of_former?` but
that was more difficult to parse when reading.

219 of 219 relevant lines covered (100.0%)

36.71 hits per line

Relevant lines Covered
Build:
Build:
219 RELEVANT LINES 219 COVERED LINES
36.71 HITS PER LINE
Source Files on remove-memoized-object-in-which-state-is-unneeded
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
610 remove-memoized-object-in-which-state-is-unneeded Renaming opaque `.call` method When I was orienting to the code, it took a bit to understand the ancestor? method ordering and purpose. As I was extracting a module function, I opted to go with `.call`. However, when I went back to the method, I ... push 01 Apr 2016 05:09PM UTC jeremyf travis-ci pending completion  
608 remove-memoized-object-in-which-state-is-unneeded Removing DeepMemberIterator Based on the previous commit, the DeepMemberIterator is not needed. I checked through the two organizations (i.e. projectyhdra and projecthydra-labs) for any additional uses of DeepMemberIterator, and found none. Perh... push 01 Apr 2016 04:18PM UTC jeremyf travis-ci pending completion  
606 remove-memoized-object-in-which-state-is-unneeded Removing DeepMemberIterator Based on the previous commit, the DeepMemberIterator is not needed. I checked through the two organizations (i.e. projectyhdra and projecthydra-labs) for any additional uses of DeepMemberIterator, and found none. Perh... push 01 Apr 2016 04:14PM UTC jeremyf travis-ci pending completion  
604 remove-memoized-object-in-which-state-is-unneeded Removing memoized object as query is stateless There was not a benefit to memoizing the AncestorChecker object. So I opted to remove the memoization and favor a module function. I also did some parameter renaming to reflect that the parameter na... push 01 Apr 2016 04:00PM UTC jeremyf travis-ci pending completion  
600 remove-memoized-object-in-which-state-is-unneeded Removing memoized object as query is stateless There was not a benefit to memoizing the AncestorChecker object. So I opted to remove the memoization and favor a module function. I also did some parameter renaming to reflect that the parameter na... push 01 Apr 2016 03:57PM UTC jeremyf travis-ci pending completion  
572 remove-memoized-object-in-which-state-is-unneeded Removing memoized object as query is stateless There was not a benefit to memoizing the AncestorChecker object. So I opted to remove the memoization and favor a module function. I also did some parameter renaming to reflect that the parameter na... push 31 Mar 2016 10:13PM UTC jeremyf travis-ci pending completion  
See All Builds (428)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc