projectblacklight / spotlight

97%

master: 97%

LAST BUILD ON BRANCH fix-async-form-observer

branch: fix-async-form-observer

CHANGE BRANCH

x

Reset

• fix-async-form-observer
• 1.0.0.alpha2
• 1318-role-plural
• 1342-vendor-prefixes
• 1353-generated-config
• 1392-resource-atomic-updates
• 1401-exhibit-tags
• 1407-filter-instructions
• 1423-signet-oauth
• 1444-safari-flexbox
• 1456-browse-item-count
• 1458-browse-category-view
• 1463-browse-update
• 1473-install-generator
• 1492-solr-wrapper
• 1503-meta-tags
• 1544-raw-solr-upload
• 1550-exhibit_search_facet_url
• 1565-sort-unpublished
• 1570-contact_avatars
• 1573-tags-input
• 1586-always-invite-users
• 1603-autocomplete-scroll
• 1604-quote-widget-formatting
• 1606-autocomplete-fix
• 1615-st-block-bug
• 1621-browse-desc-formatting
• 1622-browse-cats
• 1623-remove-jcrop-references
• 1641-iiif-manifests-for-documents
• 1648-iiif-crop-uploaded-exhibit-items
• 1656-feedback-form-weirdness
• 1657-exhibit-cache
• 1668-non-iiif-autocomplete
• 1669-iiif-ids
• 1670-crop-help-text
• 1672-iiif-migration
• 1673-sir-trevor-iiif
• 1681-riiif
• 1682-custom-fields-edit
• 1685-no-default-thumbs
• 1693-masthead-thumb-iiif-init
• 1698-home-page-thumb
• 1698-page-widget
• 1704-zpr-link
• 1722-crop-indicator
• 1723-multi-image-init
• 1724-drop-image-selector-on-new-selection
• 1731-iiif-importer-improvements
• 1743-csv-upload-bug
• 1750-dropdown
• 1762-facet-mapping
• 1782-browse-cat-bug-fix
• 1806-fix-thumbnails-for-about-pages
• 1818-search-breadcrumb
• 1880-browse-category-search-box
• 1893-reset-timestamp
• 1900-redirect-raw-docs
• 1915-metadata-field-translations
• 1916-i18n-search-related-fields
• 1917-browse-category-i18n
• 1919-pages-translation-base
• 1919-pages-translation-base-bugfix
• 1920-locale-toggle
• 1932-configure-tab-redirects
• 1935-i18n-progress-bar
• 1944-remove-redefined-has_many
• 1953-translate-home-breadcrumb
• 1958-translation-tab-redirects
• 1963-i18n-all-exhibit-descriptions
• 2002-create-home-page-automatically
• 2014-drip-drop
• 2037-lang-help-text
• 298-indexing-job-summary
• 301-view-label
• 329-typeahead
• 331-browse-pagination
• 341-browse-json
• 342-markdown-render
• 669-delete-contact-email
• actionmailer
• add-checkboxes
• add-configurable-widgets
• add-expectation-for-page-load
• add-general-edit-form
• add-i18n-tasks
• add-iiif-presentation-gem
• add-language-translation-exportability
• add-missing-migration
• add-missing-translation
• add-moar-locales
• add-user-helptext
• add_translation_published_checkboxes
• align-numeric-table-col
• allow-for-default-configurable-search-sort-fields
• allow-for-fields-to-be-disabled
• alpha2
• also_ignore_ruby_gemset
• analytics
• asset-extension
• autocomplete-test-fix
• autocomplete-to-upload-bug
• banish-js-evil-🔮
• before-each
• blacklight_7
• blacklight_gallery_optional
• blanks-translations
• blanks-translations-m4d
• browse-category-bug
• bug_spec
• build_stubbed
• bump-to-1.4.0
• bump-to-v1.1.0
• bump-to-v1.2.0
• bump-to-v1.3.0
• bump-version
• bump_version
• cached-test-app
• caption
• capybara3
• carrierwave_extension_whitelist
• cast-nil-items-to-hash
• cbeer-patch-1
• cbeer-patch-2
• chrome
• chrome-js
• chromedriver
• clamp-crop
• col-md-12
• conditional_extra
• csv-indexing
• csv-utf8
• curator-items
• data-attributes-typo
• default-upload-image
• deprecations
• desc-trunc
• deselect-as-default
• dev-niceties
• devise
• devise-less-than-4.4.2
• did-someone-say-breadcrumbs
• disable-animation
• disable-images-in-CI
• disable-title-on-other-languages
• doctype
• enable-translation-selection
• engine_cart
• exhibit-description-fix
• exhibits-345-can-spam-feedback
• exhibits-345-can-spam-feedback_config-field-name
• exhibits-index-includes
• exhibits-pagination
• factory_bot
• fail_fast
• field-config-respects-if-unless
• fix-deprecation
• fix-i18n-keys
• fix-pt-br
• fix-roar
• fix-rubocop
• fix-slideshow-spec
• fix-upload-manifest
• fix-user-invite-bug
• fix_1802_metadata_display
• fix_admin
• fix_deprecation
• fix_rubocop
• flappy-spec
• flexbox
• form_for_label
• friendly-id-deprecations
• gallery-gen-pin
• gallery_pin
• gemfile-stanza
• generate_copyable_list_of_user_emails_1472
• has_checked_field
• hide_facet_config_for_facets_with_zero_items_1438
• i18n-🌝
• i18n-🌝-rebase
• ignore_named_subject_cop
• iiif-crop-zoom
• iiif_crop
• iiif_crop-nested-attributes
• iiif_crop_helpers
• iiif_works
• immutable
• in-progress-item-status
• index-status
• indexer
• invitable_bump
• jcoyne-patch-1
• jkeck-patch-1
• language-selector
• leaflet-editable
• leaflet-fixes
• leaflet-iiif-updates
• leaflet-polygons
• limit-width-of-oembed-iframe
• link-to-search
• link-to-search-icon
• list
• local-prefixes
• locale-key-analysis
• longblob
• main-menu-translation
• main-menu-translation-changes
• making-solr-document-block-spec-more-reliable
• mark_page_titles_as_safe
• master
• max-height
• mejackreed-patch-1
• migrate-uploads
• migration-fix
• minor-fixups
• minor-test-fix
• minor-🌝-fixups
• missing-data
• mo_rspec
• morepapertrail
• nestable
• no-ar-solrdoc
• no-default-scope
• no-js-logger
• no-sandbox
• no-sleep
• no-ssb
• only-check-reindex-status-on-items-page
• ordered-blocks
• page-migration
• parallel-specs
• pin-capybara
• pin-solr
• pin_rubocop
• pt-br-fix
• rails
• rails-5.1
• rails-ujs-error-behavior
• rails5
• rails5-test
• readme_link
• rebase-sun-baby
• refactor-reindex-progress
• reindex-later
• reindex-progress
• reindex-progress-cables
• reindex-progress-improvements
• reject-docs-wo-ids
• release-1.5.1
• release-1.x
• release-1.x-backport
• remote-image-url-fix
• remove-added-assest-for-gem
• remove-missing-file
• remove-osd-crop
• remove-phantomjs-prereq
• remove_custom_facet_fields_config
• remove_deprecations
• remove_duplicate
• rename-jshint-config
• resource-subclasses
• resource-tracking
• resource-validation
• revert-1955-1953-translate-home-breadcrumb
• revert-temp-pin
• riiif
• rspec
• rubocop
• rubocop-fixes
• rubocop_updates
• ruby-2.3
• sds-index
• selection-style
• sidecar_exhibit_membership
• sir-trevor
• site-admin-menu
• sitemap-template
• solr-72
• solr-conf
• solr_wrapper_in_README
• specify-image-extension
• spotlight-exhibit-slugs
• spotlight-namespace
• spotlight_resources_iiif
• st-uploads
• st06
• stable-deps
• switch-on-off-locales
• tag-sidecar-migration
• tagstests
• temp-pin
• test_multiple_sidecar
• themes
• translation-responsiveness
• try-no-versioning
• try-travis-cache
• unique-translation
• upd-rubocop_todo
• update-dependencies
• update-embed-text-widget-desc
• update-iiif-cropper
• update-js-tests
• update-trigger
• update_riiif
• update_rubocop
• upload-iiif
• use-backwards-compatible-ujs-adapter
• user-admin
• v0.18.0
• v0.19.0
• v0.19.1
• v0.19.2
• v0.20.0
• v0.20.1
• v0.20.2
• v0.20.3
• v0.21.0
• v0.22.0
• v0.23.0
• v0.24.0
• v0.25.0
• v0.26.0
• v0.26.1
• v0.27.0
• v0.28.0
• v0.28.1
• v0.28.2
• v0.28.3
• v0.29.0
• v0.29.1
• v0.30.0
• v0.31.0
• v0.32.0
• v0.33.0
• v0.33.1
• v0.33.2
• v0.33.3
• v0.34.0
• v0.34.1
• v019
• v1.0.0
• v1.0.0.alpha1
• v1.0.0.alpha2
• v1.1.0
• v1.2.0
• v1.3.0
• v1.4.0
• v1.4.1
• v1.5.0
• v1.5.1
• v2.0.0.rc1
• v22
• v23
• v24
• v25
• v26
• v27
• v281
• valid-factories
• view_label
• webmock
• widget-update
• without_generated_feature_methods
• without_jquery

Build # 6764

Build Type

push

travis-ci

Committed by mejackreed

Commit Message

Refactor form-observer to be useful when serving javascript as async

This refactor does a few things:
 - Removes the form observer methods from the global state
 - creates this as a singleton jQuery type plugin/module
 - Documents some strange edge cases / handles same event instantiation

Unforuntately this is not compatible to running our tests in an async
way. But manual smoke testing has confirmed this working.

Run Details

3480 of 3585 relevant lines covered (97.07%)

390.55 hits per line