projectatomic / atomic-reactor

95%

master: 96%

LAST BUILD ON BRANCH get-manifest-digests-improvements

branch: get-manifest-digests-improvements

CHANGE BRANCH

x

Reset

• get-manifest-digests-improvements
• 1.5-release
• 1.5.0
• 1.5.1
• 1.6.0
• 1.6.0-release
• 1.6.1
• 1.6.10
• 1.6.11
• 1.6.12
• 1.6.13
• 1.6.14
• 1.6.15
• 1.6.16
• 1.6.17
• 1.6.18
• 1.6.19
• 1.6.2
• 1.6.20
• 1.6.21
• 1.6.22
• 1.6.23
• 1.6.23.1
• 1.6.23.2
• 1.6.23.x
• 1.6.24
• 1.6.24.1
• 1.6.25
• 1.6.25.1
• 1.6.26
• 1.6.26.1
• 1.6.26.2
• 1.6.26.3
• 1.6.27
• 1.6.28
• 1.6.29
• 1.6.29.1
• 1.6.30
• 1.6.30.1
• 1.6.30.2
• 1.6.4
• 1.6.5
• 1.6.6
• 1.6.7
• 1.6.8
• 1.6.9
• 110-run_always
• 116-rename-labels
• 116-standard-labels
• 116-use-new-labels
• 131-display-versions
• 239-plugin-exception-reporting
• 245-silence-ssl-warnings
• 248-create-imagestream
• 257-osbs-client-in-buildroot
• 258-store-metadata-traceback-on-failure
• 261-fail-fast
• 263-log-pulp-task-ids
• 269-venvgit2
• 270-service-account-secrets
• 285-bump_release-push_url
• 305-avoid-pygit2
• 320-no-plugins-after-build-failure
• 326-bump-release-label-env-indirection
• 329-layering-metadata
• 339-store-v2-digest
• 343-align-commits-and-branch-names
• 347-remove-failure-nonfatal
• 348-push-plugin
• 354-push-to-pulp
• 372-insecure-registry-push-failure
• 388-label-alias-tests
• 397-occasional-409
• 402-digest-again
• 402-digest-in-1.10
• 405-tests-without-network
• 417-rpmqa-fail-not-allowed
• 423-compression-ratio
• 424-more-metadata
• 434-inspect-config
• 472-koji-build-id-as-str
• add-dockpulp-logs
• add-filesystem-arch
• add-filesystem-packaging
• add-integration-test-dockpulp
• add-labels-append-labels
• add-labels-base-image
• add_filesystem/gather_platforms
• add_version
• additional-tags-no-hyphens
• annotations-no-pulp
• arrangement-6-fixes
• atomic-reactor-1.6.19-2
• auto-increment-release
• autopub_fix
• autopublish
• avoid-duplicate-pulp-registries
• base-image-scratch
• better-push-error-reporting
• build-host-from-docker
• build-logs-fixes
• build-resource-limits
• build_is_failing
• buildstep-error
• bump-release-labels
• bump-release-no-inspect
• bump_release
• bump_release-git-ssh-command
• bump_release-push.default
• cancel-add-filesystem
• cancel-build-test-fix
• capture-warnings
• cg-filesystem-koji-task-id
• chain-rebuild-fixes
• check_and_set_rebuild
• check_and_set_rebuild/from_latest
• check_rebuild
• cli-build-traceback
• clone-into-git-module-dirname
• clusters-client-config-dir
• compress-plugin
• compression-output
• config-doc
• container-yaml-schema
• correct-list-repos-data-processing
• coveralls-confusion
• cp-built-image-to-node
• create-image-repos
• dangerous-default-value
• debug-mangling-cluster-api
• debug-media-types
• disable-pulp-pull
• distribution-scope
• distribution-scope-image-build
• dnf-clean-all
• doc-fixes
• docker-api-error-detail
• docker-api-image-id
• docker-api-syntax-error
• docker-build-error-reporting
• docker-py-2
• dockerfile-content-compat
• dockpulp-get-versions-from-manifest
• dockpulp-prefix
• dockpulp-redirect-url
• docs-digests-media-types
• docs-plugin-required
• docs-update
• email-typo
• email_log
• equality-check
• exit-plugins
• expand-yum-repos-in-logs
• fallback-base-image-inspect
• fedora-review-spec-changes
• fetch-maven-artifacts
• fetch-maven-artifacts-chunk-size
• fix-arr3-koji-import
• fix-by-tag-pullspec
• fix-docker-build-logging
• fix-install-tree
• fix-pubkey-madness
• fix-pubkey-madness-some-more
• fix-pulp-pull
• fix-test
• fix/odcs-timeout
• fix/path-source
• fix/update-labels
• flatpak-tests
• format-string
• fs-watcher-test
• gc-docs-update
• group-false-pullspec-tag
• group-false-tags
• group-manifests-false-digest
• handle-koji-parent-no-result
• handle-md2man-absent
• help_file
• hotfix/odcs-arches
• id-without-sha256
• ignore-gpg-pubkey-packages
• ignore-unknown-params
• image-task-result
• image.index.digests-docs
• image_name
• import-image-ignore-version-release
• import-image-populate-build-json-dir
• import-image-tag-conf
• import-image-tests
• import-image-verify
• import_image
• import_image-insecure_registry
• import_image-no-conf-needed
• import_image-tests-cleanup
• import_image/fix-docker-image-repo
• improve-get-versions
• increase-pulp-timeout
• inject-parent-image
• input_osv3/fix-pulp_push-removal
• isolated-docs-koji-md
• isolated_kp
• isolated_meta
• iterator
• keep-tmpdir-for-exit-plugins
• koji-cg-digests
• koji-cg-metadata-arch
• koji-cg-upload-chunk-size
• koji-doc
• koji-image-tags
• koji-import-help
• koji-import-logs
• koji-import-rewrite-repositories
• koji-import-x86_64-image-id
• koji-log-task-id
• koji-parent
• koji-parent-fix-poll-timeout
• koji-promote-component
• koji-promote-container-koji-task-id
• koji-promote-filename-fmt
• koji-promote-less-verbose
• koji-promote-log-upload-progress
• koji-promote-metadata-doc
• koji-promote-metadata-fix
• koji-promote-packaging
• koji-promote-pod-failure
• koji-promote-start-time
• koji-promote-upload-logging
• koji-promote-warnings
• koji-repositories-doc
• koji-server-dir
• koji-ssl-auth-cleanup
• koji-tag-build
• koji-tag-build-tests
• koji-tags
• koji-tests
• koji-upload-platform
• koji-util
• koji-util-unicode-literals
• koji_promote
• koji_promote-int-task-ids
• koji_promote-name-without-namespace
• koji_promote-pulp-both
• koji_promote-repositories
• koji_promote-typo
• koji_upload/optional-params
• koji_upload_dir
• label-alias-override
• landscape-fixes
• landscape-python-3
• landscape-smells
• leaking-image
• legacy-openshift
• log-dockpulp-version
• logging-fixes
• manifest-digests-version
• master
• media_types-docs
• metadata-no-null
• mmilata-next
• more-specfile-improvements
• multi-hash-maven-artifacts
• next
• no-base-labels
• no-force-remove
• no-git-bindings
• no-log-password
• no-rpmqa-logs-annotations
• no-strip-library-prefix
• non-amd64-build
• nonexistent-plugin-error-message
• oc-dockerbuild
• odcs-integration
• odcs-ssl-support
• omit-docker-registries
• omit-tmp-files
• orchestrat-build-plugin
• orchestrate-build-cancel-on-failure
• orchestrate-build-tests
• orchestrate_build/optional-platforms
• orchestrator-build-annotations
• orchestrator-extra-metadata
• osbs-143-dock-deprecated
• osbs-143-dont-talk-about-dock
• osbs-333-namespace-param
• osbs-5080-sendmail-autorebuild-logs-link
• osbs-5462-no-packages
• osbs-5520-info-url-arrv6
• osv3-namespace
• owner2
• parentcg
• pdc-changes
• perf/push_to_pulp
• pkg-doc-koji-plugins
• plugin-error
• plugin-metadata-openshift_uri-depr
• plugin-required
• plugin-store-df-use-snapshot-of-df
• plugin_refactor
• plugins-workflow-doc
• pr656
• prefer-schema1-digest
• publish
• publish-build-failure
• publish-multiple-remove
• pull-base-image-logging
• pull-base-image-plugin
• pulp-pull-403
• pulp-pull-exception
• pulp-pull-none
• pulp-pull-timeout
• pulp-pull-workaround
• pulp-sync-auth
• pulp-sync-fetch-content
• pulp-sync-new-syncrepo-api
• pulp-sync-source-secret
• pulp-test-not-running
• pulp_publish
• pulp_pull
• pulp_pull-as-exit-plugin
• pulp_pull-expect_manifest_list
• pulp_sync
• pulp_sync-crane
• pulp_sync-delete_from_registry
• pulp_sync-fixes
• pulp_sync-publish
• r-repr
• reactor-config-mixins
• reactor_config
• reactor_config-filename
• reactor_config-use-version-key
• reactor_config/koji-path-info
• readme-contact
• rebuilds-sub-package
• record-exit-plugin-failures
• reenable-pulp-pull
• registry-delete
• release_1.6.24
• release_1.6.25
• release_1.6.26
• release_1.6.27
• release_1.6.28
• release_1.6.29
• release_1.6.30
• remove-debug
• remove-exit-plugin-error
• remove-sources-file-check
• remove-unused
• remove_buildconfigs
• report-buildstep-fail-reason
• report-errors-more
• report-progress-of-a-push-and-pull
• require-amd64
• resolve_composes/module-support
• retries
• retries2
• retries3
• retry_log
• revert-603-update-parent-image-stream-tag
• revert-748-master
• revert-new-labels
• revert-pullspec-floating-tags
• rhbz#1260134-cli-require-image-name
• rpmqa-pubkey-testcase
• rpmqa-report-exception-info
• rpmqa-signatures
• schema2-metadata-docs
• scratch-builds
• sendmail-fixes
• sendmail-plugin
• setup.py-test
• single-alt-arch
• spec-rebuild-fixes
• speed-up-inner-tests
• split-koji-build-tag
• squash-produce-tar-and-engine-image
• squash-remove-failure-warning
• stale-code
• stickler-ci-E501
• stop-rebuild-plugin
• store-build-selflink
• store-metadata-extra-debug-output-on-error
• store-metadata-failure
• store-metadata-pulp-only
• store-metadata-tests-fixes
• store-v2-digest
• support-basic-auth-osv3-plugin
• tag-and-push-http-registry
• tag-by-labels-quieten
• tag-by-labels-typo
• tag-from-config-dockerfile
• tag-race
• test-plugin-failure
• test-pr
• test-remove_built_image
• test-speedup
• test-squash-plugin
• test/steve
• tests-dead-code
• tests-in-sdist
• tests/disable-rawhide
• tox
• travis-ci-python-3.6
• travis-ci-test
• travis-dockpulp-py2
• twaugh-test
• typo
• typo-listRepos
• unclosed-files
• unique-tag-only
• update-change-from-plugin
• update-parent-image-stream-tag
• update-plugin-docs
• use-correct-content-sets
• utf8-logs
• validate-base-image-manifest-list
• version-dash-release
• versions-display-also-paths
• warn-container-remove
• without-rebuilds-plugins

Build # 5227

Build Type

push

travis-ci

Committed by twaugh

Commit Message

Improvements to get_manifest_digests utility function (OSBS-5099)

This function now gives more debugging output to aid diagnosis of a
situation in which only one of the two expected media types is seen on
the Pulp server.

As part of this, the function has been improved to aid readability.
There are now two more functions:
* `guess_manifest_media_type()` takes a bytes object and attempts to
decode it and interpret the JSON in order to decide which manifest media
type it is
* `manifest_is_media_type()` takes a requests.Response object and an
expected media type and attempts to confirm or deny that the manifest
returned in the response is of the expected media type

The media type guessing has also been improved. Previously in the
absence of a Content-Type HTTP response header, API v1 manifests could
not be identified at all (they lack a mediaType key). Now, if there is
no mediaType key the schemaVersion key will be inspected. This allows us
to reasonably guess at the manifest being API v1.

Signed-off-by: Tim Waugh <twaugh@redhat.com>

Run Details

7037 of 7399 relevant lines covered (95.11%)

4.62 hits per line