pretenderjs / pretender
64%
master: 64%

LAST BUILD BRANCH: v3.4.1
DEFAULT BRANCH: master
Repo Added
Files 1
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH vendor-whatwg-fetch
branch: vendor-whatwg-fetch
CHANGE BRANCH
x

465

Pull #295

travis-ci

web-flow 
Vendor whatwg-fetch

Pretender uses the `whatwg-fetch` package in order to intercept `fetch` calls. However, Pretender relies implicitly on `whatwg-fetch` internals to get the `fetch` intercepting behavior working correctly.

This starting causing some problems in some systems where the `whatwg-fetch` package was swapped or removed altogether, since the package is indeed a polyfill and the system determined the behavior was present and thus the polyfill wasn't needed. However, because Pretender actually relied not only on the polyfill behavior but also internal implementation details, Pretender would break in these systems.

More details: The `fetch` implementation that `whatwg-fetch` provides actually delegates to `window.XMLHTTPRequest` under the hood. Since Pretender _also_ monkey patches `window.XMLHTTPRequest`, it is able to intercept `fetch` calls equally as well. But it's only due to those internals – due to the fact that the `whatwg-fetch` polyfill happens to use XMLHTTPRequest under the hood. This is not part of `whatwg-fetch`'s public API, even though it is unlikely the change.

Since Pretender has been relying on observable but undocumented behavior of `whatwg-fetch`, this commit vendors the package, ensuring that `whatwg-fetch` can no longer be treated as an external dependency and hoisted or replaced.
Pull Request #295: Vendor whatwg-fetch

270 of 513 branches covered (52.63%)

452 of 708 relevant lines covered (63.84%)

97.12 hits per line

Relevant lines Covered
708 RELEVANT LINES 452 COVERED LINES
97.12 HITS PER LINE
Source Files on vendor-whatwg-fetch
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
465 vendor-whatwg-fetch Vendor whatwg-fetch Pretender uses the `whatwg-fetch` package in order to intercept `fetch` calls. However, Pretender relies implicitly on `whatwg-fetch` internals to get the `fetch` intercepting behavior working correctly. This starting causing... Pull #295 web-flow travis-ci pending completion  
464 vendor-whatwg-fetch Vendor whatwg-fetch Pretender uses the `whatwg-fetch` package in order to intercept `fetch` calls. However, Pretender relies implicitly on `whatwg-fetch` internals to get the `fetch` intercepting behavior working correctly. This starting causing... push samselikoff travis-ci pending completion  
See All Builds (224)