postmarketOS / pmbootstrap
79%
master: 79%

LAST BUILD BRANCH: feature/chroot-buildroot-architecture
DEFAULT BRANCH: master
Repo Added
Files 392
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/1379-pkgrel_bump-subpackages
branch: fix/1379-pkgrel_bump-subpackages
CHANGE BRANCH
x

4623

push

travis-ci

ollieparanoid 
"pkgrel_bump --auto": Handle subpackages properly

`pmbootstrap pkgrel_bump --auto` automatically increases the pkgrel for
packages linking against libraries, which don't exist anymore (because
the soname has been changed). The feature is explained in detail in

The previous implementation did not detect soname breakage, when a
subpackage linked against a certain library, but the main package
did not (e.g. `qt5-qtbase-mysql` and `qt5-qtbase`). This was, because
we iterated over the aports/* to find the packages to be checked.

To fix this, we are iterating over the packages found in the APKINDEX
files instead (of both the locally compiled packages and the downloaded
index from the pmOS mirror).

Details:
* `pmb/helpers/pkgrel_bump.py`:
  * Rewrite `auto_apkindex_package()` to act upon a given parsed
    `aport` and `apk` (from the index) instead of finding the `apk`
    dict by itself (we need it earlier anyway).
  * Rewrite `auto()` to iterate over APKINDEX files instead of aports
    * Skip packages already found, so the `pkgrel` does not get
      increased multiple times when the same package was found in
      multipe index files.
* Put the package name at the beginning of the log messages to make
  them more readable
* testdata: Create a new `testsubpkg` aport, where only the subpackage
  links against `testlib`
* Adjust testing code to test everything with `testsubpkg` as well.

NOTE: This makes the command a bit slower, but we could improve
performance again by smart caching of `pmb.parse.apkindex.depends()`.
This could come in a future PR, the important part here is that the
command is bug-free again with this fix.

3207 of 4049 relevant lines covered (79.2%)

0.79 hits per line

Relevant lines Covered
4049 RELEVANT LINES 3207 COVERED LINES
0.79 HITS PER LINE
Source Files on fix/1379-pkgrel_bump-subpackages
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
4623 fix/1379-pkgrel_bump-subpackages "pkgrel_bump --auto": Handle subpackages properly `pmbootstrap pkgrel_bump --auto` automatically increases the pkgrel for packages linking against libraries, which don't exist anymore (because the soname has been changed). The feature is explaine... push ollieparanoid travis-ci pending completion  
See All Builds (1844)