postlund / pyatv

73%

master: %

LAST BUILD ON BRANCH pair_fix

branch: pair_fix

CHANGE BRANCH

x

Reset

• pair_fix
• add_stop
• aiohttp_130
• aiohttp_1_3_1
• aiohttp_version
• aiozeroconf
• aiozeroconf_proxy
• airplay-session
• airplay_creda
• airplay_creds
• airplay_leading_zeros
• airplay_parse_fix
• airplay_permissions
• airplay_refactor
• airplay_retry
• airplay_session
• airplay_test
• arrow_keys_atv4
• artwork_docs
• artwork_docs-1
• artwork_fixing
• artwork_url
• async_await_fix
• async_updates
• atvremote_help
• atvremote_name
• atvremote_tests
• basic_info
• bugfix
• bump_aiohttp
• cleanup
• code_of_conduct
• connect
• connection
• contributing_file
• custom_pairing_guid
• custom_session
• dependabot/pip/coveralls-1.10.0
• deprecate_py34
• device_auth
• devid_scan
• disable_ipv6
• doc_manual_connect
• docs
• docs_update
• enums
• extract_command_listing
• fast_scan
• fifth_prerel
• fix_bugs
• fix_code_issues
• fix_daap_timeouts
• fix_device_id
• fix_doc_links
• fix_flaky_test
• fix_leaks
• fix_mrp_pairing
• fix_pages
• fix_pin
• fix_play_url
• fix_requirements
• fix_return_code
• fix_service
• fix_test
• fixes
• fourth_prerel
• genre_support
• hash_function
• heads/refs/remove_layouts
• implementation_proposal
• import_fixes
• initial_docs
• issue_templates
• keyboard
• lgtm_badge
• mac_as_id
• master
• media_kinds
• minor_fix
• more_docs
• more_mrp_tests
• mrp
• mrp_creds
• mrp_fixes
• mrp_flow
• mrp_idle_state
• mrp_pair_exception
• mrp_playing_tests
• mrp_position
• mrp_proxy
• mrp_scan
• mrp_tests
• multiple_commands
• new_version
• no_home_sharing
• pair_breakout
• pair_ip_fix
• pairing
• pairing_guid
• pairing_improvements
• pairing_process
• parse_fix
• pin
• play_media
• play_state_logic
• play_url
• playing_idle
• playing_output
• playstate_2
• pre_rel0
• pre_rel1
• protobuf_messages
• protobuf_raw
• protocol_fix
• proxy
• proxy_fix
• py36
• python_bump
• quantifiedcode
• re_login
• refactor
• regressions
• rel_0_4_0a7
• release
• release_0_3_0
• release_0_3_5
• release_0_3_6
• release_0_3_x
• release_0_4_0a8
• release_0_4_0a9
• release_0_4_a10
• release_script_fixes
• remove_dev_commands
• remove_quantifiedcode
• remove_timeout
• rename
• requirement_fixes
• rtd
• scan_bug
• setup_script
• shuffle_repeat
• sixth_prerel
• small_fix
• state_change
• status_code_bug
• sticky_pairing
• suspend
• test_atvremote
• test_requirements
• textinput
• tvos13_fix
• unique_id
• unpin_deps
• upgrade_zeroconf
• uplift
• url_bug
• v0.3.10
• v0.3.11
• v0.3.12
• v0.3.13
• v0.3.5
• v0.3.6
• v0.3.9
• v0.4.0a3
• verbose_flag_fix
• version_improvements
• wakeup
• zeroconf_bump
• zeroconf_stub

Build # 489

Build Type

Pull #146

travis-ci

Committed by web-flow

Commit Message

Fixes broken device pairing

Pairing with DMAP and MRP is a bit different since MRP requires more
details about the device when pairing (both an address and port). This
kinda got lost in the implementation so pairing stopped working. With
this commit pairing should work again and the implementation should
also be simpler (no need to make it more general than it has to be).

Pull Request Pull Request #146: Fixes broken device pairing

Run Details

27 of 27 new or added lines in 4 files covered. (100.0%)

1325 of 1805 relevant lines covered (73.41%)

2.2 hits per line