plomino / Plomino

72%

master: 72%

LAST BUILD ON BRANCH jean-fix-zipfile-import

branch: jean-fix-zipfile-import

CHANGE BRANCH

x

Reset

• jean-fix-zipfile-import
• -h
• 1.18
• 1.18.1
• 1.18.2
• 1.18.3
• 1.18.4
• 1.18.5
• 1.18.6
• 1.19
• 1.19.1
• 1.19.2
• 1.19.3
• 1.19.4
• 1.19.5
• ace-editor
• datagrid-inline-editing
• filter_design_davisp1
• fix-inline-editing
• fix-number-format_value
• fix_inline_editing
• genericsetup
• github-main
• issue-437
• jean-BaseField-getFieldValue-default
• jean-GET-POST-issue380
• jean-PlominoColumn-tidy
• jean-allow-underscore_in_ids
• jean-datagrid-inline-editing
• jean-datetime-DateTime
• jean-datetime-xmlrpc
• jean-decimal-xmlrpc
• jean-displayfield-default
• jean-dynamic-documenttitle
• jean-enctype
• jean-escape_xml_illegal_chars
• jean-fix-searchDocuments
• jean-getColumnRender
• jean-i18n-work
• jean-import-export-decimal
• jean-import-until-imported
• jean-issue-497-OFS.Folder
• jean-issue335-labels
• jean-issue418
• jean-json-loads-dumps
• jean-keycolumn
• jean-log-delete-failed
• jean-order-export
• jean-plug-base_view-leak
• jean-post-replication
• jean-read-version
• jean-readInputs-issue385
• jean-refactor-actions
• jean-rename-beforeDocumentCreate-to-onOpenForm
• jean-reorder-validation
• jean-replication-postonly
• jean-script_id-delimiter
• jean-script_id-formulas
• jean-setup-tempdoc-for-hidewhens
• jean-switch-script_id
• jean-templatedb-tweaks
• jean-test-formula-failed
• jean-tidying
• jean-translate-view
• jean-tweak-BaseField.getFieldValue
• jean-tweak-getPlominoReaders
• multiupload-widget
• plomino-refactoring-layout-documentproperties
• revert-628-github-main
• silviot-multiupload-widget

Build # 828

Build Type

push

travis-ci

Committed by jean

Commit Message

Make sure zipfiles which contain directory entries work

When Plomino creates a zipfile, it doesn't create directory entries such
as the `resources/` entry below. However, unless you pass the `-D`
option, `zip` does:

Archive:  /home/jean/tmp/historydb.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
     1738  2013-10-10 20:32   dbsettings.xml
    21266  2013-11-12 11:41   frmHistory.xml
        0  2013-10-11 18:02   resources/
     1183  2013-10-11 18:02   resources/libConfig.xml
     5790  2013-10-11 18:02   subAccess.xml
     6182  2013-10-11 18:02   subChildFormFields.xml
---------                     -------
    36159                     6 files

That directory failed like this:

2013-11-13 19:17:26 ERROR Zope.SiteErrorLog 1384345046.850.594614657075 http://local:8080/Plone/testdb/importDesign
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.CMFPlomino.PlominoDesignManager, line 559, in importDesign
  Module Products.CMFPlomino.PlominoDesignManager, line 1228, in importDesignFromZip
  Module xml.dom.minidom, line 1931, in parseString
  Module xml.dom.expatbuilder, line 940, in parseString
  Module xml.dom.expatbuilder, line 223, in parseString
ExpatError: no element found: line 1, column 0

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

4512 of 6254 relevant lines covered (72.15%)

1.45 hits per line