plank / laravel-mediable

95%

master: 95%

LAST BUILD ON BRANCH 4.1.0

branch: 4.1.0

CHANGE BRANCH

x

Reset

• 4.1.0
• 4.0
• 4.0.0
• 4.0.1
• 4.2.0
• 4.2.1
• 4.2.2
• 4.2.3
• 4.3.0
• 4.3.1
• 4.3.2
• 4.4.0
• 4.4.1
• 4.4.2
• 5.0.0
• 5.0.1
• 5.0.2
• 5.0.3
• 5.0.6
• 5.0.7
• 5.1.0
• 5.1.1
• 5.2.0
• 5.2.1
• 5.3.1
• 5.4.0
• 5.4.1
• 5.5.0
• 5.6.0
• 5.8.0
• 5.9.0
• 5.9.1
• 6.0.0
• 6.0.2
• 6.0.3
• 6.0.4
• 6.0.5
• 6.1.0
• 6.1.1
• 6.1.2
• 6.1.3
• 6.2.0
• callback-ordering
• cleanup-test-suite
• composer-version-constraints
• define-media-table
• dependabot/github_actions/actions/cache-3
• dependabot/github_actions/actions/checkout-3
• develop
• facade-phpdoc
• facade-uniqueness
• filesystem-options
• fix-array-access
• fix-case-insensitive
• fix-collection-delete
• fix-command-tests
• fix-delete-offset
• fix-duplicate-update-missing-model
• fix-getClientSize-deprecation
• fix-image-manipulator-binding
• fix-import-uppercase
• fix-load-image-contents
• fix-migration-bindings
• heic
• image-manipulation
• index-cleanup
• intervention-autoconfig
• intervention3-docs
• laravel-10
• laravel-7-support
• laravel-8-support
• laravel-9
• laravel-9-temporary-url
• localize-filename-sanitation
• master
• modern-migrations
• move-to-disk
• movetodisk-copy-visibility
• multiple-models-per-job
• on-duplicate-replace-with-variants
• pass-media-to-manipulation-callback
• php-84
• php8-support
• rework-create-image-variant-job
• scoped-disk-support
• source-adapter-url-path-parsing
• support-8.1
• temporary-url-support
• update-changelog
• update-psr-message-dep
• update-rtd
• uploaded-mime-type
• use-custom-media-for-queries
• v6
• variant-documentation
• variant-tagging
• variant-tracking
• variant-visibility

Build # 249

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Fix timing of beforeSave callback (#164)

Previously callback would occur after applying the on duplicate behaviour. This would result in potentially destructive changes being applied to an existing file before the callback changes disk/directory/filename to something else. It also results in no duplciate validation being performed after the path has been modified.

The callback is now called from the MediaUploader::replace() and MediaUploader::import() methods

Co-authored-by: Sean Fraser <40804044+ls-sean-fraser@users.noreply.github.com>

Run Details

835 of 876 relevant lines covered (95.32%)

72.64 hits per line