pires / go-proxyproto

95%

master: 95%

LAST BUILD ON BRANCH multireader-buf-truncation

branch: multireader-buf-truncation

CHANGE BRANCH

x

Reset

• multireader-buf-truncation
• add-trust-proxy-header-from
• bugfix/fix-godoc-default-text
• bugfix/reset_conn_read_deadline_after_successful_header
• bump-buf-size
• client-cert
• complete_pr36
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/net-0.23.0
• dependabot/go_modules/golang.org/x/net-0.36.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• doc/license
• dynamic-buffer-size
• feat/go_1.24
• feat/keep_listening_when_upstream_not_trusted
• feature/bump_coveralls
• feature/go_1.15
• feature/proxy_unknown
• fix-test-len
• fix/go_1.20_lint
• fmt
• gofmt
• h2-conn-context
• h2-err-server-closed
• large-tlv
• main
• master
• nil-panic-test
• pires/auto_release
• pires/feat/bump_go
• pires/feat/client_provided__buffer_size
• pires/feat/dinamically_grow_header_buffer
• pires/feat/go_1.26
• pires/feat/linter_modernize
• pires/feat/replace_policyfunc_with_connpolicyfunc
• pires/feat/wrap_errors
• pires/fix/buffer_header_only
• pires/fix/duplicated_ci_checks
• pires/fix/emersion-h2-conn-context
• pires/fix/http2_nil_connctx_panics
• pires/fix/readme_coveralls_badge
• pires/fix/respect_deadlines
• pires/fix/test_local
• pires/pr_2_rework
• pr_4
• prepare_release
• refs/tags/0.1.0
• refs/tags/0.1.1
• refs/tags/0.1.2
• refs/tags/0.2.0
• refs/tags/0.3.0
• refs/tags/v0.0.0-alpha
• refs/tags/v0.1.3
• refs/tags/v0.2.0
• refs/tags/v0.3.0
• refs/tags/v0.3.1
• refs/tags/v0.3.2
• refs/tags/v0.3.3
• refs/tags/v0.4.0
• refs/tags/v0.4.1
• refs/tags/v0.4.2
• refs/tags/v0.5.0
• refs/tags/v0.6.0
• refs/tags/v0.6.1
• refs/tags/v0.7.0
• refs/tags/v0.8.0
• refs/tags/v0.8.1
• refs/tags/v0.9.0
• refs/tags/v0.9.1
• refs/tags/v0.9.2
• steven-tlvs
• unnecessary-limited-reader

Build # 21628228770

Build Type

Pull #142

github

Committed by pires

Commit Message

fix: Read() data truncation issue

remove the multireader abstraction and modify conn.Read() so that we
start by draining buffered data (from the header parsing), then reading
directly from the underlying connection in a single Read() call

fixes data loss in TLS passthrough scenarios (e.g. ingress-nginx)
when PROXY header + TLS ClientHello exceeds the 256-byte buffer.

Pull Request Pull Request #142: fix: Read() data truncation issue

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

13 existing lines in 1 file now uncovered.

963 of 1013 relevant lines covered (95.06%)

51.12 hits per line