picturae / OaiPmh

79%

master: 80%

LAST BUILD ON BRANCH develop

branch: develop

CHANGE BRANCH

x

Reset

• develop
• 0.5.0
• 0.5.1
• 0.5.10
• 0.5.11
• 0.5.12
• 0.5.13
• 0.5.14
• 0.5.15
• 0.5.16
• 0.5.17
• 0.5.18
• 0.5.2
• 0.5.20
• 0.5.3
• 0.5.4
• 0.5.5
• 0.5.6
• 0.5.7
• 0.5.8
• 0.5.9
• feature/multidesc
• hotfix/0.5.15
• master
• release/0.5.5

Build # 68

Build Type

push

travis-ci

Committed by dthornley

Commit Message

Merge branch 'master' into develop

* master:
  Corrected indentation.
  Fixed catching an exception in Provider->getResponse. If it is an instance of an Oai-Exception then it is just added as an error Element directly to erroneous xml response. Otherwise it is converted, using its message, into a non-complete OaiException (i.e. without an oai error code). To handle the second case, ResponseDocument->addError is changed so that if there is no error code, then the OBLIGATORY attribute with generic value 'badArgument' is added. Possible better way to handle the situation with a generic exception: to add 'InternalServerError' to the list of admissible error code values in the scheme for OAI errors and replace 'badArgument' in addError with 'InternalServerError'.
  Fixed feature as agreed with David: Provider's getResponse method catches now any \Expression, makes am OaiPmh-Expressions out of it and adds to the xml for erroneous response.

Run Details

361 of 458 relevant lines covered (78.82%)

3.81 hits per line