phcurado / daisy_ui_components

90%

main: 90%

LAST BUILD ON BRANCH button-disabled-attribute

branch: button-disabled-attribute

CHANGE BRANCH

x

Reset

Sync Branches

• button-disabled-attribute
• 05-23-accordion
• 05-23-collapse
• 05-25-alert_options
• 62-add-tab-component
• accordion
• add-components
• add-note-about-translations
• add-steps-component
• alert-story
• assert_html_support
• autocomplete-input
• ayrat555/custom-event-for-pagination
• ayrat555/update-ci
• codex/fix-missing-rest-includes
• copilot/fixtable
• dependabot/hex/credo-1.7.12
• dependabot/hex/credo-1.7.13
• dependabot/hex/credo-1.7.14
• dependabot/hex/credo-1.7.15
• dependabot/hex/credo-1.7.16
• dependabot/hex/credo-1.7.17
• dependabot/hex/credo-1.7.5
• dependabot/hex/credo-1.7.6
• dependabot/hex/credo-1.7.7
• dependabot/hex/dialyxir-1.4.3
• dependabot/hex/dialyxir-1.4.5
• dependabot/hex/dialyxir-1.4.6
• dependabot/hex/dialyxir-1.4.7
• dependabot/hex/ex_doc-0.32.1
• dependabot/hex/ex_doc-0.32.2
• dependabot/hex/ex_doc-0.34.0
• dependabot/hex/ex_doc-0.34.1
• dependabot/hex/ex_doc-0.34.2
• dependabot/hex/ex_doc-0.37.0
• dependabot/hex/ex_doc-0.37.1
• dependabot/hex/ex_doc-0.37.2
• dependabot/hex/ex_doc-0.37.3
• dependabot/hex/ex_doc-0.38.0
• dependabot/hex/ex_doc-0.38.1
• dependabot/hex/ex_doc-0.38.2
• dependabot/hex/ex_doc-0.38.3
• dependabot/hex/ex_doc-0.38.4
• dependabot/hex/ex_doc-0.39.1
• dependabot/hex/ex_doc-0.39.2
• dependabot/hex/ex_doc-0.39.3
• dependabot/hex/ex_doc-0.40.0
• dependabot/hex/ex_doc-0.40.1
• dependabot/hex/excoveralls-0.18.1
• dependabot/hex/excoveralls-0.18.2
• dependabot/hex/excoveralls-0.18.4
• dependabot/hex/excoveralls-0.18.5
• dependabot/hex/floki-0.38.0
• dependabot/hex/floki-0.38.1
• dependabot/hex/jason-1.4.1
• dependabot/hex/jason-1.4.3
• dependabot/hex/jason-1.4.4
• dependabot/hex/phoenix_live_view-0.20.14
• dependabot/hex/phoenix_live_view-0.20.15
• dependabot/hex/phoenix_live_view-0.20.16
• dependabot/hex/phoenix_live_view-0.20.17
• dependabot/hex/phoenix_live_view-1.0.10
• dependabot/hex/phoenix_live_view-1.0.11
• dependabot/hex/phoenix_live_view-1.0.12
• dependabot/hex/phoenix_live_view-1.0.13
• dependabot/hex/phoenix_live_view-1.0.14
• dependabot/hex/phoenix_live_view-1.0.17
• dependabot/hex/phoenix_live_view-1.0.2
• dependabot/hex/phoenix_live_view-1.0.3
• dependabot/hex/phoenix_live_view-1.0.4
• dependabot/hex/phoenix_live_view-1.0.5
• dependabot/hex/phoenix_live_view-1.0.6
• dependabot/hex/phoenix_live_view-1.0.7
• dependabot/hex/phoenix_live_view-1.0.9
• dependabot/hex/phoenix_live_view-1.1.1
• dependabot/hex/phoenix_live_view-1.1.10
• dependabot/hex/phoenix_live_view-1.1.11
• dependabot/hex/phoenix_live_view-1.1.13
• dependabot/hex/phoenix_live_view-1.1.14
• dependabot/hex/phoenix_live_view-1.1.15
• dependabot/hex/phoenix_live_view-1.1.16
• dependabot/hex/phoenix_live_view-1.1.17
• dependabot/hex/phoenix_live_view-1.1.18
• dependabot/hex/phoenix_live_view-1.1.19
• dependabot/hex/phoenix_live_view-1.1.2
• dependabot/hex/phoenix_live_view-1.1.20
• dependabot/hex/phoenix_live_view-1.1.21
• dependabot/hex/phoenix_live_view-1.1.22
• dependabot/hex/phoenix_live_view-1.1.23
• dependabot/hex/phoenix_live_view-1.1.24
• dependabot/hex/phoenix_live_view-1.1.26
• dependabot/hex/phoenix_live_view-1.1.27
• dependabot/hex/phoenix_live_view-1.1.3
• dependabot/hex/phoenix_live_view-1.1.7
• dependabot/hex/phoenix_live_view-1.1.8
• dependabot/hex/phoenix_live_view-1.1.9
• dir-storybook-button
• dropdown
• duration-input
• feat/breadcrumbs
• feat/docs-update
• feat/fieldset
• feat/footer-component
• feat/group-inputs
• feat/label
• feat/progress
• feat/table-improvements
• feat/table-story
• feat/table-toggle-improvements
• feat/tabs-storybook
• feat/tailwind-4-docs
• feat/toggle
• feat/upd-liveview
• fix-card-slot-definitions
• fix/textarea
• fix/textarea-format
• fix/textarea-row-cols
• fix/toggle-component
• main
• missing-form-attribute
• modal-ignore-open-attribute
• native-attributes-checkbox-radio-range-button
• pagination-js-event
• patch-1
• phx-1.8.0
• refs/pull/15/merge
• sidebar
• sidebar-improvements
• sidebar-story
• tabs-accept-href
• update-ci
• update-daisy-version
• wigny/update-liveview

Build # e570820be9069e6c636a11a5f5119d17a26db123-PR-171

Build Type

Pull #171

github

Committed by miguelcoba

Commit Message

Render the disabled attribute on button

`disabled` is declared as its own attr, so it never reaches `{@rest}` and
the rendered button carries only the `btn-disabled` class. It stays
focusable, clickable and announced as an ordinary button.

Render it on the element instead. `disabled` is also dropped from the
global `include:` list, where it was inert: a declared attr always wins,
so it could never arrive as a global.

No visual change — daisyUI styles `.btn-disabled`, `.btn:disabled` and
`.btn[disabled]` identically, and the class is still applied. The link
branch is untouched, since `disabled` is not valid on an anchor.

Pull Request Pull Request #171: Render the disabled attribute on button

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1138 of 1260 relevant lines covered (90.32%)

16.39 hits per line