peterstace / simplefeatures

91%

master: 91%

LAST BUILD ON BRANCH remove_xor_nan_envelope_hack

branch: remove_xor_nan_envelope_hack

CHANGE BRANCH

x

Reset

• remove_xor_nan_envelope_hack
• add_coveralls
• master
• add_tests_for_null_geometry
• improve_orientation_documentation
• add_tests_for_xy_unit
• remove_unused_code
• bitset_bugfixes
• improve_coverage
• dump
• refs/tags/v0.30.0
• detect_trailing_wkb_bytes
• exact_algorithms
• address_go_report_card_issues
• fix_more_go_report_card_issues
• dump_points
• nan_checks
• alter_internal_structure_of_multipoints
• refs/tags/v0.31.0
• collapse_point_ctors
• collapse_point_ctors_for_xy_only
• use_tb_interface_for_test_helpers
• refs/tags/v0.32.0
• rewrite_release_notes_for_nan_inf_validation
• empty_env
• refs/tags/v0.33.0
• min_max_xys
• refs/tags/v0.33.1
• sync_pool_for_rtree
• as_geometry_type
• issue-416-wrap-errors
• refs/tags/v0.34.0
• fix_spelling_error_in_marshaler_comment
• json_unmarshal_on_concrete_geometries
• simplify_refactor
• wrap_make_valid
• refs/tags/v0.35.0
• remove_repeated_points
• area_transform_func_invoked_multiple_times
• validate_method
• add_clockwise_checks
• refs/tags/v0.36.0
• eliminate-copy-in-force-cw-ccw
• twkb-decode
• fix_pct_w_verb_in_Errorf
• fix_bug_in_exact_equals
• refs/tags/v0.37.0
• linear_interpolation_methods
• dump_rings
• 411-use-unsafeslice-for-wkb-handling
• add_workflow_dispatch_to_gh_actions
• bugfix_transform_empty_collection
• fix_golangci-lint
• dont_label_faces_when_inputs_are_lines
• fix_run_benchmarks_script
• refs/tags/v0.38.0
• geometry-collection-dcel
• fix_lint_error
• refs/tags/v0.39.0
• omitinvalid_bugfix
• dockerise_benchmarks
• envelope_transform_xy
• lint_fixes
• refs/tags/v0.40.0
• gc_dcel_bugfix_WIP
• use_sequence_instead_of_intermediate_xys_for_dcel_edges
• refs/tags/v0.40.1
• refactor_dcel_labels_WIP
• simplify_dcel_label_management
• reuse_dcel_half_edges_to_fix_geometry_collection_bugs_WIP
• reuse_dcel_half_edges_to_fix_geometry_collection_bugs
• rearrange_and_rename_dcel_code
• unary_union_WIP
• unary_union_and_union_many
• ordered_DCEL_output
• refs/tags/v0.41.0
• make_ignore_order_a_func
• bounding_diagonal
• normalise
• simplify_geometry_type_method
• avoid_atan2_in_dcel
• minor_cleanup_for_radial_sorting
• fix_ci_for_aarch64
• geoscpp
• only_trigger_github_actions_once_per_commit
• do_not_panic_when_no_rings_to_extract
• fix_aarch64_incorrect_intersection_results
• refs/tags/v0.42.0
• geos_3.11
• geos_coverage_union
• reproduce_geos_bug
• refs/tags/v0.42.1
• multiple_geos_versions_in_ci
• geos_unary_union
• geos_rtree
• refs/heads/geos_rtree
• upgrade_checkout_gh_action
• use_makefile_instead_of_bash_script_for_ci
• remove_rtree_insert_and_delete_methods
• refs/tags/v0.43.0
• rtree_cleanup
• simpler_rtree_bulk_load
• remove_is_leaf_flag
• export_envelope_to_box_helper
• add_string_method_to_envelope
• remove_omit_invalid
• refs/tags/v0.44.0
• is_valid
• separate_validating_and_non_validating_ctor_funcs
• validate_only_for_parsers
• no_validation_in_geos_wrapper
• remove_validation_from_transform_xy
• no_validation_in_direct_ctors
• remove_error_and_ctor_options_from_direct_ctors
• clarify_validate_functionality_in_doc_comment
• cleanup_error_handling_in_parsers
• cleanup_error_handling_in_dcel_renoding
• rename_unchecked_point_ctors
• use_novalidate_instead_of_constructor_options
• remove_xor_nan_in_env
• refs/tags/v0.45.0
• fix_bug_in_envelope_transform_xy
• refs/tags/v0.45.1
• envelope_on_sequence
• use_sequence_envelope_instead_of_extend
• better_nan_handling_in_fastmin_and_fastmax
• envelope_ctor_no_validation
• lint_overhaul
• enable_errcheck_linter
• enable_testpackage_linter
• enable_unparam_linter
• enable_stylecheck_linter
• enable_errorlint_linter
• enable_revive_linter
• update_golangci-lint_to_v1.55.2
• scratch
• separate_point_x_line_and_line_x_line_renoding
• simpler_node_set_implementation
• reproduce_bug_573
• no_rings_error
• hack_line_x_line_intersection_order_to_make_it_symmetric
• scratch_alternate_line_line_intersection
• refs/tags/v0.46.0
• remove_unneeded_benchmarks
• shared_geos_wrapper
• use_existing_rawgeos_wrappers_in_cmpgeos
• move_geos_wrappers_from_cmpgeos_to_rawgeos
• use_alpine_images_for_geos
• rot_mbr
• min_diamater
• refs/tags/v0.47.0
• use_Less_XY_comparison_func
• snap_to_grid
• decimate
• fix_some_misleading_doc_comments
• better_lerp
• upgrade_to_golangci-lint_1.56.0
• upgrade_to_golangci-lint_v1.56.1
• v0.47_fixes
• pkg-config_fix
• refs/tags/v0.47.1
• build_tag_for_no_pkg_config
• refs/tags/v0.47.2

Build # 6365310483

Build Type

Pull #556

github

Committed by peterstace

Commit Message

Simplify internal representation of Envelope

This change removes the "XOR NaN" hack. The hack was initially
introduced as a performance optimisation, but is fairly complicated.

NOTE: this PR introduces a performance regression of up to 5% for some
operations. The performance regression will be fixed in a subsequent PR
my modifying how the `Envelope` method for `LineString`s is implemented.

Pull Request Pull Request #556: Simplify internal representation of Envelope

Run Details

42 of 42 new or added lines in 1 file covered. (100.0%)

7648 of 8360 relevant lines covered (91.48%)

32305.04 hits per line