payjoin / rust-payjoin

62%

master: 84%

LAST BUILD ON BRANCH payjoin-0.22.0

branch: payjoin-0.22.0

CHANGE BRANCH

x

Reset

• payjoin-0.22.0
• 24-name-audit
• 339-sender-adversarial-tests
• 396-peek
• 398-propagate
• 399-propagate-exp
• 465-rm-relay-from-session-ctx
• 483-response-size
• 498-opaque-error
• 535-select_first_candidate-error
• 583-input-pair
• 643-version
• 647-dedup
• 659-round-II
• 707-test
• 718-unwrap
• 798-expose-fallback-tx-using-receiver-session-history-object
• PR_812_fix_follow_up
• Renaming-changes
• Use-web_time-SystemTime
• acme
• add-default-directory
• add-saving-config
• additive-cli-features
• additive-danger-local-https
• ai-disclosure
• amount-create-session
• arc-sc
• arm/additionfeecontribution-abstraction
• arm/ci/ignore-doctest
• arm/feature/allow-for-many-payouts
• arm/fix/disableadditionaoutput
• arm/merge-psbt
• arm/missing-test-cfg
• arm/vscode-git-ignore
• avoid-uih-naming
• bindings-0.23
• bitcoind-in-devshell
• bump-ohttp-relay-0.0.10
• bump-payjoin-0-23
• bump-payjoin-0.24.0
• bump-payjoin-1-0-0-rc-0
• bump-payjoin-cli-0-1-0
• bump-payjoin-cli-0.2.0
• bump-payjoin-directory-0.0.2
• bump-payjoin-directory-0.0.3
• bump-payjoin-ffi-0.24
• bump-payjoin-test-utils-0.0.0
• bump-payjoin-test-utils-0.0.1
• bump-uniffi-dart
• cache-ohttp-key
• candidate-input-refs
• cargo-mutants-version-update
• change-danger
• chavic/ffi-string-impl-audit
• chavic/ffi-string-implementation-error-audit
• check-fetch-status
• check-independent-features
• check-ntxid
• check_outputs_mutant
• clean-up-clones
• clean-up-py-inttests
• clean-up-py-unittests
• clean_uri_errors_v3
• cleanup-on-aisle-0.23
• cli-directory-dep-drift
• cli-history
• cli-ohttp-separation
• cli-size-limit
• clippy-fix-v2-sender
• clone
• closed-session-event
• code-spell
• completed_at_fk
• compress-reply-key
• contributing-add-doc
• contributing.md
• core-module-mutants-focus
• corepc-patches
• dart-gh-workflow
• dart-in-devshell
• dart-workflow-optimize
• decouple-v2-v1
• decouple-wantsoutsputs
• dedup-nonwit-data-len-const
• dedupe-finalize-multiparty
• default-feature-for-url
• deprecated-fragment-mutant
• deprecated-rustfmt.toml
• diff-mutants
• directory-cli-fixes
• directory-config
• directory-error-logs
• directory-homepage
• directory-mod
• directory-service-struct
• doc-commit-messages
• doc-update
• docker-payjoin-dir-rustc
• docs/ohttp-no-reuse-warning-819
• dont-pub-use-duration
• dont-set-path
• duplicate_proposal
• e2e-concurrency-fixes
• e2e-panic-handler
• enable-no-default-features-build
• enforce-toolchain-ffi-workflows
• ephemeral-reciever
• errant-url-endpoint
• error-fixes-for-bindings
• exclude-closed-sessions
• expect-instead-of-unwrap-hrp-parse
• explicit-err-conversions
• export-input-contribution-err
• extend-receive-tests
• extend-receive-v1-tests
• fail-cancel-session
• fail-ci-on-python-test-failures
• feat/config-error-handling
• feat/input-selection-strategies
• feat/inputpair-tests
• feat/multi-platform-ci
• feature/clean-uri-interface
• fee-app-test-coverage
• fetch-ohttp-timeout
• ffi-deps
• ffi-dev-profile
• ffi-error-fixes
• ffi-msrv-1.85.0
• ffi-public-methods
• ffi-readme-fixes
• fix-apply-fee-range-error
• fix-cli-conf-example
• fix-core-module-export
• fix-dlh
• fix-ffi-fmt
• fix-impl-error-display
• fix-output-substitution-import
• fix-pjos
• fix-send-resume
• fix-tempdir-cleanup
• fix-test-flakiness
• fix-toml-formatting
• fix-uri-ext-case
• fix-utxo-error
• fix/946-mutant-v1-output-substitution
• fix/ohttp-keys-timeout-issue-968
• fix/portable-file-locking
• fix/ref-args-persist-402
• fix/ref-args-tests-402
• fix/rpc-error-message-regression-966
• fix/test-lockfile-safety
• fix_params_lint_error
• flake
• flake-check-fixes
• formatting-fix-08-20
• fragment-fixes
• full-mutant-coverage
• fuzzing
• gateway-opt-in
• gitignore-mutants
• handle-bad-key-configuration
• handle-error-typestate
• handle-fallback-tx
• handle-post-err
• handle-recv-contribution-err-as-unavailable
• handle-v2-error
• handle-v2-error-generic
• hide-pr-template-checklist
• hpke-encrypt-error-response
• ignore-const-mutation
• implement-err-partial-eq-eq
• import-payjoin-ffi
• infallible-serialize-url
• into-url
• introduce-metrics
• invalid-format-errors
• issue-templates
• json-error
• json-reply-session-event
• lib-docs
• limit-v1-request-size
• lint-1.85.0
• lint-fix
• llcov-in-flake
• log-error-in-session-closed
• log-in-tracing
• lookup-rk
• macroify-transition-save-method
• main-send-module-test
• master
• max-content-length
• max-fee-rate-in-session-context
• migrate-to-axum
• min-feerate-broadcast
• minor_typo_in_ffi_readme
• misc-logging-changes
• missing-sender-session-history-methods
• missing-uniffi-exports
• moddocs
• monitoring
• move-constant
• move-extract-fallback-to-maybeinputsseen
• move-inmem-session-persister
• move-ns1r-out-of-master
• msrv-1.85
• msrv-pinned-deps
• mutant-workflow-permissions
• mutants-05-06
• mutants-06-23-25
• mutants-10-06-25
• mutants-out-cleanup
• mutants-version-fix
• mutation-ci
• mv-persist-submod
• nightly-ci-check
• nightly-lint-errors
• no-accept-invalid-certs
• no-default-feat-tests
• no-mock-relay-in-tests
• no-uni-mod-distinction
• no-unwrap-in-tests
• non-default-session-history
• ns1r-master-backup
• oh-fragment-param-error-refactor
• ohttp-cli-feature-merge
• ohttp-fallback
• ohttp-relay-intourl
• ohttp-reqs-refactor
• ohttp-visibility
• one-expiry-error
• only-try-preserving-privacy
• optimize/cli-clone-reduction-#402
• optimize/hpke-vec-clones-#402
• optimize/receive-clone-reduction
• optimize/send-clone-reduction
• optional-param-doc
• output-substitution-checklist
• own-self
• own-self-sender
• patch-1
• patch-2
• patch-3
• patch-4
• payjoin-0.21.0
• payjoin-0.23.0
• payjoin-0.24.0
• payjoin-1.0.0-rc.0
• payjoin-cli-0.1.0
• payjoin-cli-0.2.0
• payjoin-cli-clear-sessions
• payjoin-cli-cmd-cleanup
• payjoin-cli-interrupt
• payjoin-cli-pki-feature
• payjoin-cli-readme-updates
• payjoin-directory-0.0.1
• payjoin-directory-0.0.1-rc0
• payjoin-directory-0.0.2
• payjoin-directory-0.0.3
• payjoin-directory-build
• payjoin-ffi-0.24
• payjoin-test-utils-0.0.0
• payjoin-test-utils-0.0.1
• persist-lint
• persist-ohttp-keys
• persist-payjoin
• persisted-session
• persistence-followups
• pip-to-uv
• pjos-error-variants
• pjos-to-0
• pjuri-fragments-lowercase
• poll-no-pause
• pr-checklist
• pr-comments-test
• prepare-psbt-by-copy
• probot/enhance_leakage_test
• process-res-error-handling
• propagate-config-err
• psbt-ctx-recv
• pub-crate-jsonreply-new
• pub-well-known-error
• pull-out-session-ctx
• pulls/1021/head
• python-ci-jobs
• python-flake-dev-env
• python-workflow-optimize
• qualify-path
• random-padding
• readme-tests-update
• readme-updates
• receive-error-heirarchy
• receiver-builder
• receiver-error-pub-crate
• receiver-generic-over-typestate
• receiver-new-with-time
• receiver-typestate-closures
• recv-err
• recv-session-event
• recv-state-transition-objects
• redis-ci-workflow
• redis-ports
• reduce-contr-inputs-event
• reduce-vis-recv-common
• reduce-visibility-session-history-get-session-context
• reduce-visibility-state-transition-objects
• redudant-ok
• redundant-closure
• refactor-builder-to-derive
• refactor-receiver
• refactor-sender
• refactor-uri
• refactor-wantsfeerange
• relay-opt-in
• remaining-issue-templates
• remove-apt-cmds-from-ffi-gen
• remove-change-vout
• remove-docker-mentions
• remove-duplicate-short-cli-flag
• remove-mut-ohttpkeys
• remove-old-fn-ref
• remove-optional
• remove-pad-plaintext
• remove-public-url
• remove-python-bitcoin-lib
• remove-redis-docker-compose
• remove-remaining-url-api
• remove-replyableerr-tests
• remove-request-pub-fields
• remove-storage-wrapper
• remove-terminal-error-method
• remove-test-utils-url-and-request
• remove-tofrom-ffi-json
• remove-uninitialized
• remove-unwrap
• rename-expiration
• rename-receiver-sessoin-context
• rename-relay-state
• rename-sender-events
• rename-session-events
• rename-v2getcontext
• replace-bitcoincore-rpc-350
• replace-bitcoind
• replace-custom-rpc
• replacement-outputs-Iter
• replay-expiration-error
• reply-json
• req-impl-visibility
• request-body
• request_v_arg_types
• ressurect-terminal-failure
• restore-psbt-outputs
• restore-utxo-bug
• restore-witness-script
• resume-db-path
• return-err-in-replay
• rfc-9540
• rfc-9540-directory-and-receiver
• rm-from-id-result
• rm-mailbox
• rm-old-ffi-receiver-tests
• rm-polling-proposal-as-non-primary-info
• rm-session-history-psbt-with-fees
• rpc-cli-error
• rusqlite_migration
• rust-bitcoin-0.32.4
• rust-toolchain
• rustup-override-workflow-script
• sanitizeLogs
• seal-state-trait
• send-v2-module-tests
• sender-closed-variant
• sender-generic-over-state
• sender-mutants
• sender-mutants-2
• sender-parse-error-reply
• sender-persist-session-events
• sender-redundant-import
• sender-session-events
• sender-session-history-fallback
• sep-receive-errors
• separate-receive
• separate-send-versions-p1
• separate-send-versions-p2-v2
• seperate-fee-application-typestate
• session-history-naming-discrepancy
• setup-py-typo
• shebang-fix
• short-id-pub-crate
• short-id-session-id-replacment
• shortid-method
• show-test-error-details
• shutdown-resume-with-sigint
• simplify-cli-feature-flags
• simplify-handle-fatal
• simplify-session-id-pj-cli
• spacebear21-patch-1
• split-v1-psbt-contexts
• sticky-max-feerate-clean
• test-arch
• test-cov-impl-error-jsonreply
• test-utils
• test-utils-redis
• test-utils-redis-follow
• testing-features
• time-newtype-rebased
• toml-version-specify
• tracing-instead-of-log-crate
• treat-missing-utxo-as-error
• try-request-url-string
• tx-outcome-helpers
• typed-cli-args
• u8-responses
• unchecked-proposal-hpke-pk
• uniffi-dart
• unpub-internal-uri-getters
• unwrap-v2-payjoin
• update-bip77
• update-bip78
• update-flake-lock
• update-lock-file-backup
• update-payjoin-cli-nigiri-install
• update-readme-header
• update-setuptools
• upgrade-testcontainers
• uri_errors
• uri_mutants
• url-no-idna
• use-ffi-hasreplyerror-transition
• use-reply-key-for-replyable-errors
• use-shortid-util
• use-witness-for-expected-weight
• v1-to-v2-test-202-bug
• v1-v2
• v1context-visibility
• v2-replace-outputs-into-iter
• wants-fee-mutants
• wants-inputs-primary-info
• wants-outputs-event-primary-info
• workflow-optimizations
• yeet-redis
• yeet-redis-followups

Build # 12470231512

Build Type

push

github

Committed by web-flow

Commit Message

Fix unresumable Sender (#443)

The Sender was generating new hpke keys on resume since keygen was being
done in `extract_v2`. This caused a problem where when the Sender was
persisted, stopped, and resumed, the receiver would have already pushed
a response to a different ShortId than the one the Sender would look for
it in the resumed state.

By generating a key on Sender creation and persisting that the Sender
can produce a consistent HpkeContext every single run.

The e2e test did not catch this because it was not propagating errors.
The e2e test has been fixed.

Run Details

10 of 10 new or added lines in 2 files covered. (100.0%)

252 existing lines in 8 files now uncovered.

2899 of 4687 relevant lines covered (61.85%)

982.03 hits per line