ottogroup / palladium

100%

master: 90%

LAST BUILD ON BRANCH bug/permissive-recursive-get-config

branch: bug/permissive-recursive-get-config

CHANGE BRANCH

x

Reset

• bug/permissive-recursive-get-config
• 1.0.1
• 1.2.0
• 1.2.1
• 1.2.1.1
• 1.2.1.dev1
• 1.2.2
• 1.2.3
• 1.2.dev4
• 1.2b1
• 1.2b2.dev1
• GBIPMMF-190
• batch-processing
• bugfix-ujson-precision
• bugfix/R-tzlocal
• bugfix/alive-handler
• bugfix/bad-server-fit-decorator-name
• bugfix/better-default-cache-dir
• bugfix/cache-wraps
• bugfix/cachedupdatepersister-without-active-model
• bugfix/conda-build-3.6
• bugfix/conda-install-quiet
• bugfix/config-copy-tests-coverage
• bugfix/docs-parallelism
• bugfix/dont-register-update-model-cache
• bugfix/fit-evaluate-scorer
• bugfix/flakey-tests
• bugfix/openml-travis
• bugfix/persistence-decorators
• bugfix/pip-install-travis
• bugfix/pld-config-key-bad-value
• bugfix/simplify-travis
• bugfix/some-deprecation-warnings
• bugfix/travis-docs-require
• bugfix/travis-py-3.5
• dependabot/pip/jinja2-2.11.3
• develop
• feature-active-model
• feature-admin-delete
• feature-database-clob
• feature-document-backward-incompatiblity
• feature-document-commands
• feature-params-from-data-api
• feature-python-3.3
• feature-streaming-io-api
• feature-update-requirements
• feature/R-categorical
• feature/activate-web-service
• feature/add-conda-recipe
• feature/add-poolclass-param
• feature/avoid-delayed-initialization
• feature/bayesian-hyperparameter-example
• feature/cachedupdatepersister-avoid-loading-same-model
• feature/ci-add-python-3-7
• feature/config-exclamation-mark-as-factory
• feature/copy-with-default
• feature/cv-iterator-apply-X
• feature/default-configfile-name
• feature/get-metadata-decorators
• feature/grid-search-impl
• feature/grid-search-persist-best
• feature/grid-search-save-results
• feature/keras-and-xgboost-examples
• feature/list-webservice
• feature/model-attachments
• feature/multiple-entry-points
• feature/openml
• feature/pld-export
• feature/pld-fit-memory
• feature/pld-test-scoring
• feature/predict-service-unwrap-for-text
• feature/refit-web
• feature/requirements-update
• feature/resolve-dotted-name-modules
• feature/rest-persister
• feature/travis-py-3.7
• feature/travis-run-conda-build
• feature/update-dependencies
• feature/update-pip-dependencies
• feature/update_dependencies
• features/docs-dask-hyperparameter
• master

No longer disallow recursive call to get_config (reverts e390cbf)

It turns out that we make use of recursive `get_config` calls in our
own code: `CachedUpdatePersister` initializes with
`self.update_cache()`, which is decorated with
`PluggableDecorator('update_model_decorators')`, which calls
`get_config` to get a list of strings pointing to decorator functions.

In any event, it may be a good idea to call `self.update_cache()` from
a thread so to not block initialization.  However,
`PluggableDecorator` likely has other legitimate uses, so this isn't a
fix for the problem at hand.

The caveat still applies that if one calls `get_config` from component
code, one must be aware that the part of config we want to refer to
may not be initialized yet.  Best way to work around this is to either
not rely on `__factory__` and friends at all (PluggableDecorator does
that), or to make that part of the configuration a sub-entry to the
component's own configuration, if possible.