ossia / score
15%

DEFAULT BRANCH: master
Repo Added
Files 2921
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 15.264% (+0.001%) from 15.263%
30754433360

push

github

jcelerier 
fix(widgets): scale custom cursor hotspots on xcb for HiDPI

score::get_cursor loads the @2x cursor asset once devicePixelRatio() >= 1.5 and
tags the pixmap with devicePixelRatio 2. The hotspots in score::Skin are given in
device-independent pixels, which is what QCursor expects.

Qt's xcb backend however passes QCursor::hotSpot() straight to
xcb_render_create_cursor together with the raw device-pixel image
(QXcbCursor::createBitmapCursor -> qt_xcb_createCursorXRender), so the hotspot of a
64x64 @2x cursor lands at (16,16) instead of its centre (32,32). The cursor is then
drawn 16 device pixels down and to the right of the real pointer, which makes every
item look like its hitbox is misplaced: pointing at a small widget actually hits
whatever is up and to the left of it. It is most visible with the UI Zoom setting
above 100%, since Zoom raises devicePixelRatio and therefore the size of the gap in
screen pixels.

Measured with XFixesGetCursorImage on Qt 6.4.2, cursor_pointing_hand@2x.png:
hotspot (16,16) on a 64x64 image before, (32,32) after. That xcb code is unchanged
from Qt 6.2 through 6.11, so express the hotspot in the image's own pixels there
and leave the other platforms, which honour the pixmap devicePixelRatio, alone.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TTUi76cnUWh7dGZC64LqbZ

4 of 4 new or added lines in 1 file covered. (100.0%)

263 existing lines in 1 file now uncovered.

30463 of 199568 relevant lines covered (15.26%)

1075.34 hits per line

Relevant lines Covered
199568 RELEVANT LINES 30463 COVERED LINES
1075.34 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30754433360 master fix(widgets): scale custom cursor hotspots on xcb for HiDPI score::get_cursor loads the @2x cursor asset once devicePixelRatio() >= 1.5 and tags the pixmap with devicePixelRatio 2. The hotspots in score::Skin are given in device-independent pixel... push jcelerier github
15.26
30589063221 master developer.sh: support for ubuntu 26.04 (resolute). resolute codename was missing from detect_deps_scripts() so developer.sh fell back to ci/ubuntu.noble.deps.sh which fails on 26.04 because libqtwebsockets6-dev, libqt6serialport6-dev and libqtshad... push jcelerier github
15.26
30507431705 master audio: simplify pretty name for Default device push jcelerier github
15.26
30317766880 master ci(wasm): ship the release asset with the binary uncompressed e7a498a gzipped the binary because ci/wasm.deploy.sh pushes site/ into the score-web git repository, which GitHub caps at 100 MiB. The release bundle is zipped from that same site/, so... push jcelerier github
15.32
30213925900 master 3rdparty: bump libossia for the network-context poll fix Brings in ossia/libossia#913: SDL joystick init no longer requires haptic support (which the Emscripten SDL2 port does not have), and network_context::poll() restarts the io_context, withou... push jcelerier github
15.3
30143869936 master fx: include the ossia value header in Fx/Types.hpp Types.hpp names ossia::value in value_output_callback / value_out but only included ossia/detail headers. Every regular build force-includes the PCH, which drags the definition in, so the omissio... push jcelerier github
15.31
5309 master try to support more build configurations Pull #59 jcelerier travis-ci pending completion  
2025 master Pause listening on play push jcelerier travis-ci pending completion  
2009 master Fix various bugs push jcelerier travis-ci pending completion  
3986 master documentation push jcelerier travis-ci pending completion  
See All Builds (502)