optimizely / javascript-sdk

98%

master: 81%

LAST BUILD ON BRANCH client-rum

branch: client-rum

CHANGE BRANCH

x

Reset

• client-rum
• 2.0-consolidation
• 4.x.x
• 5.x.x
• dependabot/npm_and_yarn/happy-dom-16.6.0
• dependabot/npm_and_yarn/rollup-2.79.2
• esra/FSSDK-11100_audience_evaluator_test
• esra/dependabot/update_happy-dom
• esra/vitest/FSSDK-11095_rewrite_condition_tree_test
• fahad/enforce-linting
• farhan-anjum/FSSDK-11073-GHA-publish-to-GPR
• farhan-anjum/FSSDK-11073-update-gha-for-gpr-publish-on-5.x.x
• farhan-anjum/FSSDK-11446-add-exp/var-id-to-notif-listener
• junaed/fssdk-10655-fsc-decide-reason-fix
• junaed/fssdk-10935-refactor-log-export
• junaed/fssdk-11003-make-services-disposable-for-ssr
• junaed/fssdk-11034-tests-js-to-ts
• junaed/fssdk-11098-issue-with-akamai-edge-worker
• junaed/fssdk-1119-test-js-to-ts
• junaed/fssdk-11238-convert-notification-center-utils-test
• junaed/fssdk-11403-readme-update
• junaed/fssdk-11473-remove-crossbrowser-and-umd-from-pipeline
• junaed/prepare-5.3.5
• master
• mpirnovar-testing-fsc-js
• raju/child_logger
• raju/cleanup-log
• raju/cmab_client
• raju/cmab_config
• raju/cmab_decision
• raju/cmab_traffic
• raju/cmabservice
• raju/config-cleanup
• raju/decision_notification
• raju/decision_test
• raju/default-opt
• raju/dep
• raju/dependabot
• raju/entrypoint_types
• raju/event_default_flush
• raju/event_experiment
• raju/event_flush_default
• raju/exception-msg
• raju/export-entrypoint
• raju/export_map
• raju/high_alert
• raju/log-alias
• raju/log-fix
• raju/logger-factory
• raju/logging-error-handling
• raju/message-gen
• raju/msg
• raju/no_config
• raju/notification-center
• raju/odp-cleanup
• raju/odp-refactor
• raju/odp_event_api
• raju/opaque_factory
• raju/opti_service
• raju/optimizely_client_refactor
• raju/remove-plugins-dir
• raju/universal_entrypoint
• raju/ups_async
• raju/util-cleanup
• raju/validate
• refs/heads/master
• sohail/removetokens

Build # 781

Build Type

push

travis-ci

Committed by web-flow

Commit Message

fix (onReady): Clear ready timeout when instance closed, and other small fixes (#25)

Summary:

Previously, if close was called with pending ready timeouts, those timeouts would remain active. With this change, we clear all pending ready timeouts when close is called.

To guard against Promises returned from onReady remaining permanently pending, in close, we resolve any ready promises associated with pending timeouts with unsuccessful results. 

There are two other small changes in this PR:
- Improve documentation comments for Optimzely onReady and ProjectConfigManager onReady
- Return false from setForcedVariation when no configObj available (was previously returning null)

Test plan:

Updated unit tests, existing unit tests should continue passing

Run Details

584 of 635 branches covered (91.97%)

Branch coverage included in aggregate %.

5707 of 5812 relevant lines covered (98.19%)

74.27 hits per line