openzipkin / zipkin-go

75%

master: 73%

LAST BUILD ON BRANCH v0.2.2

branch: v0.2.2

CHANGE BRANCH

x

Reset

• v0.2.2
• 128_request_sampler_for_client
• 65_adds_tracer_new_noop
• 80_removes_request_size_on_empty
• 80_removes_response_size_on_empty
• adds_b3_single_heade
• adds_err_handler_for_server
• adds_error_response_reader
• adds_finished_span_handler
• adds_golang_ci
• adds_noop_reporter
• adds_support_for_end_time
• adds_support_for_error_handler_for_http
• adds_support_for_noop
• enables_go_cache
• exposes_binary_samplers
• fix-travis
• fixes_dep
• fixes_deps_lint
• fixes_kafka_reporter
• fixes_kafka_serializer
• fixes_proto_code
• go_10_nd_11
• go_116
• go_1_12
• grpc_parsers
• improves_testing_readability
• improves_tests_for_trace_id
• lowercase_span_name_and_service_name
• master
• missing_tags
• removes_b3_header_option_on_reporting
• removes_tag_http_url
• tweaks_kafka_documentation
• uses_interface_for_http_client
• v0.1.0
• v0.1.1
• v0.1.2
• v0.1.3
• v0.1.4
• v0.1.5
• v0.1.6
• v0.1.7
• v0.2.0
• v0.2.1
• v0.2.3
• v0.2.4
• v0.2.5

Build # 535

Build Type

push

travis-ci

Committed by jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

1845 of 2446 relevant lines covered (75.43%)

17617.63 hits per line