openwisp / openwisp-firmware-upgrader

97%

master: 94%

LAST BUILD ON BRANCH 1.2

branch: 1.2

CHANGE BRANCH

x

Reset

• 1.2
• 1.1
• add-tiny
• api
• backport/404-to-1.2-1779209331
• bump-version
• change_mock_patch_decorator_in_test_models
• changelog/1.1.2
• changes/allow-deleton-of-upgrades
• chore/port-changelog-1.2.1
• chores/add-ci-failure-bot
• chores/add-gsoc26-branch-to-ci
• chores/add-gsoc26-persistent-scheduled-upgrades-branch-to-ci
• ci/changelog_bot
• config_app_label_test_admin
• css-fixes
• custom_group_model_migrations
• debug-ci
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/setup-python-6
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.12.3
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.12.4
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.14.0
• dependabot/pip/django-redis-approx-eq-6.0.0
• dependabot/pip/psycopg2-binary-approx-eq-2.9.11
• dependabot/pip/psycopg2-binary-approx-eq-2.9.12
• dependabot/pip/responses-approx-eq-0.25.6
• dependabot/pip/responses-approx-eq-0.25.7
• dependabot/pip/responses-approx-eq-0.25.8
• dependabot/pip/responses-approx-eq-0.26.0
• dev
• drop-python3.9
• extended_controller_app_tests_part_one
• feature/backport-workflow
• feature/bot-autoassign
• fix-302-mass-upgrade-credentials
• fix-flaky-selenium-tests
• fix-mass-upgrade-docs
• fix-openwrt-syntaxwarning-escapes
• fix-restoring-device-test
• fix/302-mass-upgrade-credentialless-devices
• fix_test_selenium_device_change_url
• format-by-prettier
• gsoc/firmware-docs
• gsoc25
• gsoc25-tidy-up-tests
• issue/208-enable-cancellation-of-upgrades
• issue/224-show-real-time-upgrade-progress
• issue/301-fw-image-not-deleting
• issue/318-update-developer-docs-to-install-libsqlite3-mod-spatialite
• issue/349-multicolor-progressBar
• issue/358-identifier-change-crash
• issue/366-allow-upgrade-options
• issue/382-fix-deactivated-upgrader
• issue/69-improve-endpoints
• issue/mass-upgrade-by-group-location
• issue/show-mass-upgrade-progress
• issue/upgrade-by-group
• issue/upgrade-options-fix
• issues/165-add-device-recognition-mechanism
• issues/204-shared-firmware
• issues/249-add-support-for-django-5.x
• issues/250-fix-http500-missing-credentials
• issues/256-delete-org-blocked
• issues/291-sysupgrade
• issues/338-empty-image-submission
• issues/360-use-theme-color-variables
• issues/376-updated-upgrade-op-breadcrumb
• issues/417-persistence-schema-fields
• issues/418-core-architecture-with-validation
• master
• refactor_test_admin_TestAdminTransaction
• release-1.1.1
• release/1.1.2
• release/1.2.0
• remove-main
• replicate-version-branch
• switch-to-prettier
• uuid-fix

Build # 26116044218

Build Type

push

github

Committed by nemesifier

Commit Message

[fix] Prevent HTTP 500 on missing device credentials #250

When device credentials are deleted after a firmware image is
assigned, saving the device form crashes with an unhandled
`DoesNotExist` exception. This change catches
`ObjectDoesNotExist` and raises a `ValidationError` instead,
providing a user-friendly error message.

Several related edge cases are handled as well.

Closes #250

(cherry picked from commit b0cc4d488)
(adaptations were made for this version branch)

Coverage Stats

1675 of 1718 relevant lines covered (97.5%)

12.67 hits per line