openconfig / ygot

91%

master: 89%

LAST BUILD ON BRANCH diff-enum-3

branch: diff-enum-3

CHANGE BRANCH

x

Reset

• diff-enum-3
• 0.6.0
• 0.7.0
• MergeDupAnno
• SetNodeOpt
• ValueStr
• annotation-fields-0
• apb_bug
• awly_dev
• build-empty-skip-populated
• build-fix
• builderany
• choice-case-panic
• compressed_annotate
• coverage_update
• debug-185
• del-old-proto
• demo-import-names
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/setup-go-6
• dependabot/go_modules/github.com/golang/glog-1.2.4
• dependabot/go_modules/github.com/google/go-cmp-0.7.0
• dependabot/go_modules/github.com/openconfig/gnmi-0.13.0
• dependabot/go_modules/github.com/openconfig/gnmi-0.14.0
• dependabot/go_modules/github.com/openconfig/gnmi-0.14.1
• dependabot/go_modules/github.com/openconfig/goyang-1.6.2
• dependabot/go_modules/github.com/openconfig/gribi-1.9.0
• dependabot/go_modules/github.com/spf13/cobra-1.9.1
• dependabot/go_modules/golang.org/x/net-0.33.0
• dependabot/go_modules/golang.org/x/net-0.36.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• dependabot/go_modules/google.golang.org/grpc-1.68.1
• dependabot/go_modules/google.golang.org/grpc-1.69.0
• dependabot/go_modules/google.golang.org/grpc-1.69.2
• dependabot/go_modules/google.golang.org/grpc-1.69.4
• dependabot/go_modules/google.golang.org/grpc-1.70.0
• dependabot/go_modules/google.golang.org/grpc-1.71.0
• dependabot/go_modules/google.golang.org/grpc-1.71.1
• dependabot/go_modules/google.golang.org/protobuf-1.36.0
• dependabot/go_modules/google.golang.org/protobuf-1.36.1
• dependabot/go_modules/google.golang.org/protobuf-1.36.2
• dependabot/go_modules/google.golang.org/protobuf-1.36.3
• dependabot/go_modules/google.golang.org/protobuf-1.36.4
• dependabot/go_modules/google.golang.org/protobuf-1.36.5
• dependabot/go_modules/google.golang.org/protobuf-1.36.6
• dependabot/go_modules/google.golang.org/protobuf-1.36.7
• dependabot/go_modules/google.golang.org/protobuf-1.36.8
• diff-enum
• diff-enum-2
• diff-merges
• diff-opt
• diffll
• dplore/updatemod
• emitjson-novalidate
• emitjson-threadsafe
• enum-bug
• enum-dedup
• enum-dedup-flag
• enum-moduledef
• enum-name
• enum-notstable
• enum_debug
• enumkey
• enumpkgname
• errorf-fix
• etv-nil
• exclude-state
• exclude_state_compressed_list
• experimental-yangproto
• fake-api
• field-getters
• file-split
• fix-go-master
• fix-protopkg
• fix_bug_of_losing_encap_header_details
• fix_prunebranches
• generic_protos
• genutil-coverage
• get-or-create
• getnode
• ghaci
• go-1.8.x
• go11
• godep_update
• goyang_prefix
• goyangflg
• identity-special-chars
• keyvaluetypecheck
• leafget
• leafref_perf
• leafref_validation
• less-verbose-errors
• lint-fix
• lintfix
• list-key-mismatch
• listkey_137
• listtest
• log-optional
• mapvalinsert
• marshal-annotations
• master
• merge-fix
• mergeoptions
• modelver
• node
• nonptropt
• npe-pathstrings
• ostromart_cleanup
• ostromart_coverage
• ostromart_coverage_ytypes
• ostromart_dedup
• ostromart_dev
• ostromart_govet
• ostromart_leafref
• ostromart_lint
• ostromart_tests
• ostromart_union_tests
• ostromart_validate
• patch-1
• pathelem
• pathschemavalidity
• pathtranslator-wildcard
• proto-enum
• proto-sort-by-type
• protoannotation
• protobuf-fakeroot
• protobuf-fix
• protobuf_fixes
• protobuf_getting_started
• protobuf_single_package
• protobuf_union_leafref_enum
• protocplugin-1
• protopkgname
• protoyang
• prune-empty
• pull-request-demo
• remove-deepequal
• rename-overwrite
• renderperf2
• renovate/major-deps
• retrieve-node-track
• revert-218-protocplugin-1
• robjs-353
• robjs-annotations
• robjs-build-empty-merge-issue
• robjs-coverage-adjust
• robjs-coveralls
• robjs-devel
• robjs-empty-type
• robjs-empty-validate
• robjs-enumtypemap
• robjs-enumtypemap-access
• robjs-experimental-tree
• robjs-fixtests
• robjs-gnmi-pathelem
• robjs-json-merge
• robjs-json-paths
• robjs-jsonenum-serialisation
• robjs-leafrefbug
• robjs-map-merge
• robjs-mergetwostructs
• robjs-nil-key
• robjs-path-restructure
• robjs-proto-annotation
• robjs-proto-enum-annotate-gen
• robjs-proto-enum-naming
• robjs-proto-namespace
• robjs-proto-number
• robjs-proto-unionfix
• robjs-proto-yangspec
• robjs-protogen-12
• robjs-rename-list-entry
• robjs-structmerge
• robjs-structmerge-maps
• robjs-telemetry-eg
• robjs-testcoverage
• robjs-unmarshal-protobuf
• robjs_buildsystem
• robjs_generated_proto_code
• robjs_pathstrings
• robjs_protogen_caller
• safe-append
• schema-type
• schemapath
• set_leafref
• set_path_origin
• stringtotype
• struct-literal-fix
• struct-util
• structdiff
• structdiff-1
• structdiff-2
• structmerge-union
• testupdate
• testutil
• testutil-opt
• testutil-sub
• union-key-um
• unmarshal-annotations
• unmarshal-empty
• unmarshal-gnmi
• unmarshal-ignore-extra
• unmarshalpanic
• unzip-schema
• v0.5.0
• v0.6.0
• v0.7.0
• v0.7.1
• v0.7.2
• v0.7.3
• validate_err
• validationopts
• wenbli-PathElemDirectComp
• wenbli-clean
• wenbli-dev
• wenbli-dev-add1.12
• wenbli-dev-exportAllMappedTypeFields
• wenbli-dev-fixOldTypo
• wenbli-dev-remove1.9
• wenbli-dev-ypathgen
• wenbli-dev2
• wenbli-dev3
• wenbli-leafrefValTreeImpl
• wenbli-refactor
• wenbli-refactor2
• wenbli-ypathgen-childctor
• ypathgen-dev
• ywrapper_proto

Build # 1064

Build Type

push

travis-ci

Committed by web-flow

Commit Message

[4/4] Fix bug with enums in diff (#183)

* Fix enumeration related bug in ygot.Diff

 * (M) demo/*
 * (M) ygen/*
 * (M) ytypes/*
   - Remove the hundreds of implementations of generateUnifiedDiff that
     had sneaked into the codebase, yikes.
 * (M) ygot/
   - Fix a defect whereby a diff would be produced for any enumeration
     value since a zero-check was not done during the diff walk process.
 * (M) testutil/*
   - Make sure that the notification checkers ignore nil values, and
     do not modify the input data supplied to them.

* Undo move change

* Fix error in imports

* Ensure nil cases are covered by test coverage

Run Details

57 of 57 new or added lines in 3 files covered. (100.0%)

7870 of 8646 relevant lines covered (91.02%)

179.01 hits per line