openbraininstitute / libsonatareport

86%

push

github

change default `LIBSONATA_ZERO_BASED_GIDS` (#8)

## Context

Neurodamus is 0-based now. We should adapt libsonatareport as well.

Fix: #7

change default to zero-based

## Scope

- remove LIBSONATA_ZERO_BASED_GIDS
- add LIBSONATAREPORT_ONE_BASED_GIDS
- add warnings in `setup_reports()` for legacy env key
- remove python 3.9 from ci since it was dropped by neurodamus

after thinking about having all the tests 0-based, I would not change the integration and conversion tests (that are currently 1-based) for these reasons:

1. more work
2. it is good to have some tests that check the legacy 1-based version of the code
3. I would still support that version, not as default, so that people with an old neurodamus can still run by setting the flag. Performance-wise is the same. A couple of warnings and errors to support both ways are not a big cost imho

## Tests

- fix unit tests
- integration and conversion tests use the old 1-based version

13 of 15 new or added lines in 2 files covered. (86.67%)

800 of 928 relevant lines covered (86.21%)

19.31 hits per line