open-contracting / credere-backend

85%

main: 86%

LAST BUILD ON BRANCH chore-exceptions

branch: chore-exceptions

CHANGE BRANCH

x

Reset

Sync Branches

• chore-exceptions
• 10-remove-data-for-completed-applications
• 10-remove-data-for-lapsed-applications
• 102-FI-user-data-verification
• 107-access-fund-upon-contract-being-signed
• 108-declined-application-further-options
• 113-do-not-log-user-entry-errors-in-sentry
• 114-new-application-email-to-FI-error
• 115-new-email-address-is-not-being-saved
• 116-email-FI-when-documents-have-been-upload
• 117-lapsed-applications-still-accessible
• 118-do-not-log-database-data
• 119-use-env-variable-for-environment
• 120-check-preferences-before-sending-emails
• 132-order-past-contracts-by-contract-start-date
• 141-set-previous-award
• 151-legal_type_in_credit_product
• 153-pdf_adjustments
• 16-Email-notification-for-new-MSME-application
• 182-log-skipped-awards
• 186-remove-contract-upload
• 192-multiple-awards
• 199-dead-code
• 207-authorization-bugs
• 210-check-users
• 214-login-mfa
• 215-source-data-removal
• 216-empy-key
• 222-remove-upload-compliance
• 225-document-workflow
• 243-message-types-fix
• 246-direct-invitation
• 248-quiet-option
• 249-replace-transaction_session
• 249-transaction_session_logger
• 258-escape-suppliers-name
• 259-unnecessary-tags
• 27-remove-size-and-sector-data-missing
• 281-default-dict
• 29-past-contracts-not-shown-in-award-details
• 299-new-fetch-method
• 304-fi-default-preaproval-message
• 33-mark-if-field-has-been-manually-updated
• 343-use-email_validator
• 350-pending-submit-reminder
• 358-main
• 361-reply-to
• 362-translate-enums
• 362-translate-more-enums
• 363-borrower-annual-revenue
• 366-exclude-legal-person
• 375-new-email-designs
• 378-send-refactor
• 385-lender-notifications
• 390-cognito-fix
• 392-applications-filter
• 400-new-document-type
• 401-new-document-format
• 41
• 413-authenticate
• 418-data-source-changes
• 42-define-entity-relationship-diagram
• 424-onboarding-reminder
• 425-lapse-application
• 427-external-onboarding
• 435-external-onboarding-tracking
• 439-change-lapseable-logic
• 44-SES-Integration
• 443-revert-373
• 46-Background-process
• 47-sentry-integration
• 53-Add-authorization-scheme-to-endpoints
• 55-87-133-152_issues
• 58-Add-logger-to-server
• 60-Deploy
• 62-Send-reminder
• 63-MSME-Application-endpoints
• 64-user-application-endpoints
• 66-FI-endpoints
• 79-complete-missing-test
• 81-download-application-button
• 90-Email-SME-endpoint
• 94-Credit-provider-and-credit-options-changes
• add-lender-rejected-at-to-applications
• add-sphynx-for-background-processes
• autoflush
• awards-offset
• aws-refactor
• better-error-messages
• bugfix-remove-data
• chore-pydantic2-prep
• chore-tidy
• chore-typing
• ci-mypy
• cognito-mfa
• copy-application
• data-access-consistency
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/setup-python-5
• dependabot/github_actions/actions/setup-python-6
• dependabot/github_actions/docker/build-push-action-5
• dependabot/github_actions/docker/build-push-action-6
• dependabot/github_actions/docker/login-action-3
• dependabot/github_actions/docker/setup-buildx-action-3
• dependabot/github_actions/dot-github/workflows/tj-actions/changed-files-41
• dependabot/github_actions/pre-commit/action-3.0.1
• dependabot/github_actions/tj-actions/changed-files-37
• dependabot/github_actions/tj-actions/changed-files-38
• dependabot/github_actions/tj-actions/changed-files-40
• dependabot/github_actions/tj-actions/changed-files-41
• dependabot/github_actions/tj-actions/changed-files-42
• dependabot/github_actions/tj-actions/changed-files-43
• dependabot/github_actions/tj-actions/changed-files-44
• dependabot/github_actions/tj-actions/changed-files-45
• dependabot/pip/black-24.3.0
• dependabot/pip/certifi-2024.7.4
• dependabot/pip/cryptography-41.0.6
• dependabot/pip/cryptography-42.0.2
• dependabot/pip/cryptography-43.0.1
• dependabot/pip/cryptography-44.0.1
• dependabot/pip/fastapi-0.109.1
• dependabot/pip/idna-3.7
• dependabot/pip/jinja2-3.1.3
• dependabot/pip/jinja2-3.1.4
• dependabot/pip/jinja2-3.1.6
• dependabot/pip/pillow-10.2.0
• dependabot/pip/pillow-10.3.0
• dependabot/pip/pillow-11.3.0
• dependabot/pip/python-multipart-0.0.18
• dependabot/pip/python-multipart-0.0.7
• dependabot/pip/requests-2.32.0
• dependabot/pip/requests-2.32.4
• dependabot/pip/urllib3-1.26.18
• dependabot/pip/urllib3-1.26.19
• dependabot/pip/werkzeug-3.0.1
• dependabot/pip/werkzeug-3.0.3
• dependabot/pip/werkzeug-3.0.6
• develop
• division-by-zero
• document-models
• email-lang-change
• email-subjects
• es-emails
• external-onboarding-fix
• fathom
• feat/232/more-statistics
• feature/40/cognito-integration
• feature/43/create_email_templates
• fix/58/rollback-confirm-credit-option
• gettext-simpler
• html-template-documents_updated_fi_user
• httpx
• i18n
• initial-sphynx-config
• main
• merge-fetch-awards
• misc
• missing-commit
• modify-initial-migration
• move-statistic-custom-range
• mypy
• mypy-auth
• new-credit-product-field
• new-document-type
• new-user-form
• no-pandas
• no-tuple
• nplus1
• perf-index
• pre-commit-ci-update-config
• pyjwt
• quiet
• quote-plus
• quote_plus
• readme-BG-procces
• refactor-architecture
• refactor-authorization
• refactor-fixtures
• refactor-types-docs
• remove-background-statistics
• remove-dated-application-data
• remove-dead-code-login
• remove-statistics-table-command
• ruff
• send_application_overdue_reminder
• simple-indexes
• skippedaward-message
• snake-case
• source-format-error
• sphinx-routers-docs
• sqlmodel-cleanup
• sqlmodel-upgrade
• static
• statistics
• statistics-refactor
• tags
• terminology
• translations-doc-name
• upgrades
• user-test

Build # 6563314120

Build Type

Pull #180

github

Committed by jpmckinney

Commit Message

chore: Use specific exceptions, instead of ValueError

Sentry logs logger.error and logger.exception calls, so it's not necessary to call capture_exception (which was given incorrect arguments).

Sentry groups exceptions by stack trace, so the unique error messages should not be an issue.
https://docs.sentry.io/product/data-management-settings/event-grouping/

Pull Request Pull Request #180: chore: Tidy exception handling

Run Details

119 of 131 new or added lines in 13 files covered. (90.84%)

3 existing lines in 3 files now uncovered.

2291 of 2687 relevant lines covered (85.26%)

0.85 hits per line