ooni / probe-cli

4%

master: 72%

LAST BUILD ON BRANCH issue/399

branch: issue/399

CHANGE BRANCH

x

Reset

• issue/399
• backend/369
• bug-ooni/probe#1013
• chore/bundle-update
• chore/c-deps
• chore/goversion-update
• chore/major-dependencies
• chore/probe-assets
• chore/report-card-fix
• chore/stun-input
• chore/update-dependencies
• chore/update-toolchain
• chore/update-user-agent
• clean-stop
• config/category-codes
• delete-all-measurements
• develop
• feat/orchestrate-switch
• feature/coc
• feature/latestengine
• feature/periodic
• feature/probe-engine-0.7.0
• feature/updates
• feature/v3.0.0
• fix-list-ui
• fix/1183
• fix/build
• fix/buildscript
• fix/checkout-version
• fix/download-version
• fix/lockunlock
• fix/one-msmt
• fix/ooni_home
• fix/show
• fix/useragent
• fullbuild
• gh-aarch64
• gh-armhf
• independent-file
• informed-consent-file
• informed-consent-migration
• issue-templates
• issue/1004
• issue/1005
• issue/1016
• issue/1030
• issue/1043
• issue/1125
• issue/1185
• issue/1185-slim
• issue/1238
• issue/125
• issue/1281
• issue/1283
• issue/1289
• issue/1315
• issue/267
• issue/316
• issue/41
• issue/452
• issue/748
• issue/807
• issue/969
• issue/973
• issue/update-engine
• launchd
• master
• no-help
• no-write-disk
• packaging
• packaging2
• psiphon-metadata
• rc/14
• refactor-consolidate
• refactor/no-forks
• refactor2
• refactor3
• refs/tags/v3.0.10
• refs/tags/v3.0.11
• refs/tags/v3.0.7
• refs/tags/v3.0.7-beta
• refs/tags/v3.0.7-beta.1
• refs/tags/v3.0.8
• refs/tags/v3.0.8-beta
• refs/tags/v3.0.9
• refs/tags/v3.1.0
• refs/tags/v3.2.0
• refs/tags/v3.3.0
• refs/tags/v3.4.0
• release/13
• release/3.0.0-rc.4
• release/3.0.10
• release/3.0.2
• release/3.0.3
• release/3.0.4
• release/3.0.5
• release/3.0.6
• release/3.0.8
• release/3.0.8-beta
• release/3.0.9
• release/3.11
• release/3.11.0-deps
• release/3.14
• release/3.15
• release/3.16
• release/3.17
• release/3.18
• release/3.19
• release/3.2.0
• release/3.20
• release/3.21
• release/3.22
• release/3.25
• release/3.4.0
• release/testing
• release/testing_backport
• release/v3.0.1
• release/v3.0.7
• return-msmt-uid
• sbs-sandbox
• signal-windows
• stable
• testing
• tor-targets
• update/engine
• update/probe-engine
• update/probe-engine-0.12.0
• v3
• v3.0
• v3.0.0
• v3.0.0-rc.10
• v3.0.0-rc.11
• v3.0.0-rc.12
• v3.0.0-rc.13
• v3.0.0-rc.14
• v3.0.0-rc.4
• v3.0.0-rc.5
• v3.0.0-rc.6
• v3.0.0-rc.7
• v3.0.0-rc.8
• v3.0.0-rc.9
• v3.0.1
• v3.0.12-alpha
• v3.0.2
• v3.0.3
• v3.0.5
• v3.0.6
• version/3.1.0
• version/3.3.0

Build # 377

Build Type

Pull #120

travis-ci

Committed by web-flow

Commit Message

ooni.go: use 32 bit counter to signal interruption

Using a 64 bit counter has pitfalls. See Go documentation.

I don't want a refactoring or whatever to let these pitfalls
emerge in the future.

We just need one bit to signal we're done.

So use 32 bit, which shall be safe everywhere.

See https://golang.org/pkg/sync/atomic/#pkg-note-BUG.

Proactively triggered by https://github.com/ooni/probe-engine/issues/399.

Pull Request Pull Request #120: ooni.go: use 32 bit counter to signal interruption

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

7750 of 199015 relevant lines covered (3.89%)

0.04 hits per line