ooni / netx

100%

master: 100%

LAST BUILD ON BRANCH feature/refactor-9

branch: feature/refactor-9

CHANGE BRANCH

x

Reset

• feature/refactor-9
• design-doc-review
• develop
• dialer-new
• dialer/tidy
• feature/1.1.1.1
• feature/betternervous
• feature/bodypart
• feature/bogus
• feature/cancellation
• feature/clarity
• feature/connid
• feature/contextrooted
• feature/contributing
• feature/coverage
• feature/design
• feature/divertlookup
• feature/dns
• feature/dnsbounded
• feature/dnscontext
• feature/dnsfallback
• feature/dnsporcelain
• feature/dnsretry
• feature/exposescoreboard
• feature/fallbackresolver
• feature/fork_for_probe_engine
• feature/headers
• feature/interfaces
• feature/maxconnsperhost
• feature/model
• feature/modelx
• feature/movelogger
• feature/nervous
• feature/newroot
• feature/noproxy
• feature/oodnsrefactor
• feature/opportunistic_sni
• feature/porcelain
• feature/prettylogging
• feature/probeenginex
• feature/readme
• feature/refactor
• feature/refactor-1
• feature/refactor-10
• feature/refactor-11
• feature/refactor-12
• feature/refactor-13
• feature/refactor-14
• feature/refactor-15
• feature/refactor-17
• feature/refactor-2
• feature/refactor-3
• feature/refactor-5
• feature/refactor-6
• feature/refactor-7
• feature/refactor-8
• feature/refactoring
• feature/removegodns
• feature/resolution
• feature/roundtrip
• feature/roundtripstats
• feature/scoreboard
• feature/scoreboardtests
• feature/snaps
• feature/sni
• feature/snibasedblocking
• feature/splitresolve
• feature/techdebt
• feature/testing
• feature/tls
• feature/tlsfacts
• feature/tlsfilter
• feature/update-deps
• feature/xref
• fix/requestdone
• fix/specific_dns_server
• fix/tests
• issue/127
• issue/141
• issue/25
• issue/302
• issue/327
• issue/8
• master
• moretidy/transport
• refactor/dialer
• refactor/dialer2
• refactor/dialer3
• refactor/dialer4
• refactor/dot
• refactor/fulldialer
• refactor/resolver
• refactor/tlsdialer
• rename/oodns
• resolver/tidy
• tidy/http
• tidy/httptransport
• xhdix-feature/edns-padding
• zap/dnsconf

Build # 120

Build Type

Pull #37

travis-ci-com

Committed by web-flow

Commit Message

Refactor dialer into smaller pieces

These smaller pieces implement the interface pattern where you can
wrap a basic piece with another implementing the same interface.

I want to potentially retry connecting with some kind of proxy and
see whether it's possible to circumvent blocking.

I want to potentially retry the TLS handshake by changing the case of
the certificate, by maybe splitting it into multiple segments.

What's more, now all these new pieces use a context to carry around
information rather using a handler passed to constructor.

We cannot still really take advantage of this, because we're still
stuck with a dialerapi.Dialer that configures its own policy inside
of its constructor, but we'll make that more flexible soon.

Pull Request Pull Request #37: Refactor dialer into smaller pieces

Run Details

295 of 295 new or added lines in 14 files covered. (100.0%)

1908 of 1908 relevant lines covered (100.0%)

83.75 hits per line