ooni / netx

100%

master: 100%

LAST BUILD ON BRANCH feature/refactor-3

branch: feature/refactor-3

CHANGE BRANCH

x

Reset

• feature/refactor-3
• design-doc-review
• develop
• dialer-new
• dialer/tidy
• feature/1.1.1.1
• feature/betternervous
• feature/bodypart
• feature/bogus
• feature/cancellation
• feature/clarity
• feature/connid
• feature/contextrooted
• feature/contributing
• feature/coverage
• feature/design
• feature/divertlookup
• feature/dns
• feature/dnsbounded
• feature/dnscontext
• feature/dnsfallback
• feature/dnsporcelain
• feature/dnsretry
• feature/exposescoreboard
• feature/fallbackresolver
• feature/fork_for_probe_engine
• feature/headers
• feature/interfaces
• feature/maxconnsperhost
• feature/model
• feature/modelx
• feature/movelogger
• feature/nervous
• feature/newroot
• feature/noproxy
• feature/oodnsrefactor
• feature/opportunistic_sni
• feature/porcelain
• feature/prettylogging
• feature/probeenginex
• feature/readme
• feature/refactor
• feature/refactor-1
• feature/refactor-10
• feature/refactor-11
• feature/refactor-12
• feature/refactor-13
• feature/refactor-14
• feature/refactor-15
• feature/refactor-17
• feature/refactor-2
• feature/refactor-5
• feature/refactor-6
• feature/refactor-7
• feature/refactor-8
• feature/refactor-9
• feature/refactoring
• feature/removegodns
• feature/resolution
• feature/roundtrip
• feature/roundtripstats
• feature/scoreboard
• feature/scoreboardtests
• feature/snaps
• feature/sni
• feature/snibasedblocking
• feature/splitresolve
• feature/techdebt
• feature/testing
• feature/tls
• feature/tlsfacts
• feature/tlsfilter
• feature/update-deps
• feature/xref
• fix/requestdone
• fix/specific_dns_server
• fix/tests
• issue/127
• issue/141
• issue/25
• issue/302
• issue/327
• issue/8
• master
• moretidy/transport
• refactor/dialer
• refactor/dialer2
• refactor/dialer3
• refactor/dialer4
• refactor/dot
• refactor/fulldialer
• refactor/resolver
• refactor/tlsdialer
• rename/oodns
• resolver/tidy
• tidy/http
• tidy/httptransport
• xhdix-feature/edns-padding
• zap/dnsconf

Build # 110

Build Type

Pull #32

travis-ci-com

Committed by web-flow

Commit Message

refactor(dialerapi): decouple from other packages

Merge dialerbase into dialerapi since dialerbase was basically
just a small dialerapi implementation detail.

Ensure that the input parameters to the constructor and the
dependencies of dialerbase are not weird stuff.

Try to limit exposure of implementation details or weird types
as much as possible. Start thinking about deprecating some code
parts that are not much used and tricky.

Pull Request Pull Request #32: refactor(dialerapi): decouple from other packages

Run Details

146 of 146 new or added lines in 5 files covered. (100.0%)

2154 of 2156 relevant lines covered (99.91%)

91.19 hits per line