ooni / netx

100%

master: 100%

LAST BUILD ON BRANCH feature/refactor-11

branch: feature/refactor-11

CHANGE BRANCH

x

Reset

• feature/refactor-11
• design-doc-review
• develop
• dialer-new
• dialer/tidy
• feature/1.1.1.1
• feature/betternervous
• feature/bodypart
• feature/bogus
• feature/cancellation
• feature/clarity
• feature/connid
• feature/contextrooted
• feature/contributing
• feature/coverage
• feature/design
• feature/divertlookup
• feature/dns
• feature/dnsbounded
• feature/dnscontext
• feature/dnsfallback
• feature/dnsporcelain
• feature/dnsretry
• feature/exposescoreboard
• feature/fallbackresolver
• feature/fork_for_probe_engine
• feature/headers
• feature/interfaces
• feature/maxconnsperhost
• feature/model
• feature/modelx
• feature/movelogger
• feature/nervous
• feature/newroot
• feature/noproxy
• feature/oodnsrefactor
• feature/opportunistic_sni
• feature/porcelain
• feature/prettylogging
• feature/probeenginex
• feature/readme
• feature/refactor
• feature/refactor-1
• feature/refactor-10
• feature/refactor-12
• feature/refactor-13
• feature/refactor-14
• feature/refactor-15
• feature/refactor-17
• feature/refactor-2
• feature/refactor-3
• feature/refactor-5
• feature/refactor-6
• feature/refactor-7
• feature/refactor-8
• feature/refactor-9
• feature/refactoring
• feature/removegodns
• feature/resolution
• feature/roundtrip
• feature/roundtripstats
• feature/scoreboard
• feature/scoreboardtests
• feature/snaps
• feature/sni
• feature/snibasedblocking
• feature/splitresolve
• feature/techdebt
• feature/testing
• feature/tls
• feature/tlsfacts
• feature/tlsfilter
• feature/update-deps
• feature/xref
• fix/requestdone
• fix/specific_dns_server
• fix/tests
• issue/127
• issue/141
• issue/25
• issue/302
• issue/327
• issue/8
• master
• moretidy/transport
• refactor/dialer
• refactor/dialer2
• refactor/dialer3
• refactor/dialer4
• refactor/dot
• refactor/fulldialer
• refactor/resolver
• refactor/tlsdialer
• rename/oodns
• resolver/tidy
• tidy/http
• tidy/httptransport
• xhdix-feature/edns-padding
• zap/dnsconf

Build # 131

Build Type

Pull #39

travis-ci-com

Committed by web-flow

Commit Message

netx: move beginning and handler at toplevel

All the netx code now does not depend on a preconfigured
beginning and handler, except toplevel code.

This is very helpful because it allows us to specify different
contexts depending on circumstances.

Yet, the public API has not changed because there is still
a notion of the binding of a dialer with a handler.

What I like about this change is that it allows us to evolve
our code potentially in two directions:

1. we keep a single handler and we provide correct information
concerning the current TransactionID

2. we switch to a rooted handlers model where the handler is
passed as part of the context

Now, internals in netx already follow model #2, while the toplevel
API is still using model #1.

The part that needs refactoring now is httpx.

Pull Request Pull Request #39: netx: move beginning and handler at toplevel

Run Details

406 of 406 new or added lines in 19 files covered. (100.0%)

2084 of 2084 relevant lines covered (100.0%)

65.66 hits per line