ooni / netx

100%

master: 100%

LAST BUILD ON BRANCH feature/nervous

branch: feature/nervous

CHANGE BRANCH

x

Reset

• feature/nervous
• design-doc-review
• develop
• dialer-new
• dialer/tidy
• feature/1.1.1.1
• feature/betternervous
• feature/bodypart
• feature/bogus
• feature/cancellation
• feature/clarity
• feature/connid
• feature/contextrooted
• feature/contributing
• feature/coverage
• feature/design
• feature/divertlookup
• feature/dns
• feature/dnsbounded
• feature/dnscontext
• feature/dnsfallback
• feature/dnsporcelain
• feature/dnsretry
• feature/exposescoreboard
• feature/fallbackresolver
• feature/fork_for_probe_engine
• feature/headers
• feature/interfaces
• feature/maxconnsperhost
• feature/model
• feature/modelx
• feature/movelogger
• feature/newroot
• feature/noproxy
• feature/oodnsrefactor
• feature/opportunistic_sni
• feature/porcelain
• feature/prettylogging
• feature/probeenginex
• feature/readme
• feature/refactor
• feature/refactor-1
• feature/refactor-10
• feature/refactor-11
• feature/refactor-12
• feature/refactor-13
• feature/refactor-14
• feature/refactor-15
• feature/refactor-17
• feature/refactor-2
• feature/refactor-3
• feature/refactor-5
• feature/refactor-6
• feature/refactor-7
• feature/refactor-8
• feature/refactor-9
• feature/refactoring
• feature/removegodns
• feature/resolution
• feature/roundtrip
• feature/roundtripstats
• feature/scoreboard
• feature/scoreboardtests
• feature/snaps
• feature/sni
• feature/snibasedblocking
• feature/splitresolve
• feature/techdebt
• feature/testing
• feature/tls
• feature/tlsfacts
• feature/tlsfilter
• feature/update-deps
• feature/xref
• fix/requestdone
• fix/specific_dns_server
• fix/tests
• issue/127
• issue/141
• issue/25
• issue/302
• issue/327
• issue/8
• master
• moretidy/transport
• refactor/dialer
• refactor/dialer2
• refactor/dialer3
• refactor/dialer4
• refactor/dot
• refactor/fulldialer
• refactor/resolver
• refactor/tlsdialer
• rename/oodns
• resolver/tidy
• tidy/http
• tidy/httptransport
• xhdix-feature/edns-padding
• zap/dnsconf

Build # 268

Build Type

Pull #78

travis-ci-com

Committed by web-flow

Commit Message

Make events actionable for OONI's nervous system

After trial and error, I have determined that, in general, to decide
whether we need follow-up measurements, we need just the result of
four events in the HTTP round trip:

- RESOLVE_DONE
- CONNECT
- HANDSHAKE_DONE
- ROUND_TRIP_DONE

In some cases it may be possible to run operations inline while in
others it's probably best to run concurrently or later.

Regardless of the implementation strategy, this diff makes sure that
by combining this four events only, we have enough information to
conclude whether to trigger more measurements.

This conclusion is based on my analysis using ooni/jafar, it may be
of course that later we'll need to tweak this a bit.

I've been doing refactoring for quite some time to prepare this.

Master issue: https://github.com/ooni/probe-engine/issues/87

Pull Request Pull Request #78: Make events actionable for OONI's nervous system

Run Details

11 of 11 new or added lines in 3 files covered. (100.0%)

1400 of 1400 relevant lines covered (100.0%)

43.92 hits per line