ocaml / ocaml-lsp

17%

master: 22%

LAST BUILD ON BRANCH ps/rr/fix__ocamlformat_rpc_initialization

branch: ps/rr/fix__ocamlformat_rpc_initialization

CHANGE BRANCH

x

Reset

Sync Branches

• ps/rr/fix__ocamlformat_rpc_initialization
• 414-LTS
• 414-support
• 5.1-compat
• 5.2-no-dune
• 5.2-preview
• add-code-of-conduct
• add-config
• add_syntax_doc
• anmonteiro/dont-read-merlin-files
• anmonteiro/overlay
• batching
• bump-ppx-expect
• cmarkit
• completion-edge-cases
• construct-custom-query
• dependabot/github_actions/cachix/install-nix-action-27
• dependabot/github_actions/cachix/install-nix-action-30
• dependabot/github_actions/cachix/install-nix-action-V28
• dependabot/github_actions/cachix/install-nix-action-v29
• dependabot/github_actions/ocaml/setup-ocaml-3
• dependabot/github_actions/tarides/changelog-check-action-3
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/babel/traverse-7.23.2
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/braces-3.0.3
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/cross-spawn-7.0.6
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/micromatch-4.0.8
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/prettier-3.3.2
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/semver-6.3.1
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/typescript-5.4.5
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/typescript-5.5.2
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/typescript-5.5.4
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/typescript-5.6.2
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/typescript-5.6.3
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/typescript-5.7.2
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.12.12
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.12.13
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.0
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.1
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.2
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.5
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.6
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.7
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.8
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/types/node-20.14.9
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/vscode-jsonrpc-8.2.0
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/vscode-jsonrpc-8.2.1
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/vscode-languageserver-protocol-3.17.5
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/vscode-languageserver-types-3.17.5
• dependabot/npm_and_yarn/ocaml-lsp-server/test/e2e/vscode-uri-3.0.8
• destruct-line-code-action
• destruct-long-lines-fix
• doc-to-md-test
• documentation_custom_query
• document-edit-tests
• extract
• fix-issue1358
• fix-md-dividers
• fix-signature-help-parens
• fix-string-zipper
• fix-test-5.2
• fix-uri-tostring
• folding-range-ifthenelse
• follow-merlin-ugprades
• hacking-doc.md
• HEAD
• improve-comment-completion
• improved-document-symbols
• improved-hovers
• improved-infer-interface
• inlay-hints
• jump_
• jump-ca
• jump_cq
• master
• merlin-as-a-lib
• merlin-suffix
• name-all-merlin-pipelines
• nix-flake-fix-dune-release
• no-inlay-hints-under-ghost
• odoc-parser-compatibility
• patch-1
• polarity_search
• pp-release-1.18
• prepare-1.17.0
• preview-ocamlformat-0.26.1
• print-only-first-type-result
• ps/branch/coverage__don_t_allow_failure_in_workflow
• ps/rr/chore__add_missing_unix_dependency
• ps/rr/chore__changes_tweaks
• ps/rr/chore__disable_warning_58_for_now
• ps/rr/chore__fix_typo
• ps/rr/chore__format_flake_file
• ps/rr/chore__more_changes_formatting
• ps/rr/chore__move_dune_release_to_own_shell
• ps/rr/chore_nix___add_5_1_support
• ps/rr/chore_nix___add_back_test_deps_for_dev
• ps/rr/chore_nix___allow_overriding_ocaml_version
• ps/rr/chore_nix___better_formatting_job
• ps/rr/chore_nix___disable_check_phase_for_now
• ps/rr/chore_nix___fix_package_name
• ps/rr/chore_nix___no_overlays_for_ocamlformat_release
• ps/rr/chore_nix___remove_octavius
• ps/rr/chore_nix___remove_pp_from_deps
• ps/rr/chore_nix___remove_some_copy_pasting
• ps/rr/chore_nix___remove_some_duplication
• ps/rr/chore_nix___remove_stdune_dep_from_lsp
• ps/rr/chore_nix___simplify_test_job
• ps/rr/chore_nix___some_cleanups
• ps/rr/chore_nix___update_flakes
• ps/rr/chore__ocamlformat_0_26_2
• ps/rr/chore_ocamllsp___stop_vendoring_lsp_jsonrpc
• ps/rr/chore__prepare_1_16_0
• ps/rr/chore__prepare_1_16_1
• ps/rr/chore__remove_re_export_of_ordering_from_stdune
• ps/rr/chore__remove_some_pointless_qualification
• ps/rr/chore__remove_uutf_from_deps
• ps/rr/chore__revert_incorrect_chagnes_to_makefile
• ps/rr/chore__simplify_some_qualification
• ps/rr/chore__switch_to_janestreet_style
• ps/rr/chore__update_constraints
• ps/rr/chore__update_flakes
• ps/rr/chore__update_nix_flakes
• ps/rr/chore__update_ocamlformat_test_version
• ps/rr/chore__upgrade_to_ocamlformat_0_26_2
• ps/rr/chore__vendor_cmarkit
• ps/rr/chore__windows_tests
• ps/rr/feature__add_missing_server_requests
• ps/rr/feature__disable_code_lens_by_default
• ps/rr/feature_lsp___add_basic_query_support_to_uri_s
• ps/rr/feature_lsp___add_inlayhint_client_request
• ps/rr/feature_lsp___add_missing_client_to_server_requests
• ps/rr/feature_lsp___add__text_document_expert_advance_
• ps/rr/feature_lsp___allow_progress_notifications_from_client
• ps/rr/feature_lsp___api_for_absolute_positions
• ps/rr/feature__update_lsp_spec
• ps/rr/fix__close_stderr_in__run_in_directory_
• ps/rr/fix__dependency_on_metamodel_tests
• ps/rr/fix__hack_to_workaround_dune_bug
• ps/rr/fix__kill_dune_ocaml_merlin_in_a_friendlier_way
• ps/rr/fix__killing_merlin_on_windows
• ps/rr/fix_lsp___make_write_take_list_of_strings
• ps/rr/fix_lsp___move_logtrace_to_the_correct_location
• ps/rr/fix_lsp___type_of_target_is_uri
• ps/rr/fix__move_subdir_stanza_for_ocaml_lsp_server_to_correct_place
• ps/rr/fix__remove_dependency_on_workspace_root
• ps/rr/fix__use_sigterm_instead_of_sigkill_sigint
• ps/rr/refactor__clean_up_imports_of_merlin
• ps/rr/refactor__cleanup_signature_help
• ps/rr/refactor__doc_to_md
• ps/rr/refactor__get_rid_of_stdune_from_code_generator
• ps/rr/refactor__get_rid_of__stdune_path_
• ps/rr/refactor__inlay_hints
• ps/rr/refactor__limit__stdune__usage_in_code_gen
• ps/rr/refactor_lsp___remove_text_document_expert
• ps/rr/refactor__remove_incorrect_logging_message
• ps/rr/refactor__remove_some_dead_code
• ps/rr/refactor__remove__stdune_io_
• ps/rr/refactor__remove_uses_of__stdune_fdecl_
• ps/rr/refactor__replace_some_stdune_modules_with_base
• ps/rr/refactor__simplify_file_existence_check
• ps/rr/refactor__switch_to_nixpkgs
• ps/rr/test__add_missing_dependency
• ps/rr/test__demonstrate_that_ppx_works
• ps/rr/test__remove_for_pp_script
• ps/rr/test__reproduce__1207
• ps/rr/test__switch_document_symbol_to_snapshot_tests
• ps/rr/test__try_to_repro_drop_until_bug
• ps/rr/test__use_snapshots_everywhere
• ps/rr/update_flakes
• release-1.20.0
• remove-dune-dep-for-fallback-read-dot-merlin
• remove-flake-utils-dep
• remove-hover-extended-req
• respect-completion-prefix
• selectionRange--use-merlin-enclosings-query-instead-of-shape
• setup-ocaml-v3
• sh-infix
• sh-unit
• stewarding-custom-request
• string-zipper-goto-line-backward
• superscript
• symbol-fallback-build-folder
• tunneling-merlin-lsp-p2-use-merlin-lib
• type-enclosing-query
• ulugbekna/completion-for-in
• unused
• update-github-actions
• update_jump
• update-readme
• uri-fragment

Build # 3846

Build Type

push

github

Committed by rgrinberg

Commit Message

fix: ocamlformat-rpc initialization

if [get_process] is alled concurrently, the ivar might be filled twice.

Fixes #1115

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: d5c77719-29a5-4b46-92e8-c09f6453ba56 -->

Run Details

4 of 5 new or added lines in 1 file covered. (80.0%)

10 existing lines in 1 file now uncovered.

4073 of 23471 relevant lines covered (17.35%)

18.71 hits per line