nymius / bdk

86%

master: 82%

LAST BUILD ON BRANCH fix/off-by-one-error-in-coinbase-coin-selection

branch: fix/off-by-one-error-in-coinbase-coin-selection

CHANGE BRANCH

x

Reset

Sync Branches

• fix/off-by-one-error-in-coinbase-coin-selection
• I1499/introduce-tlv-for-bdk-file-store
• I1517/append-after-open-causes-overwrites
• bugfix/i-1517-store-append-after-open-causes-overwrite
• ci/replace-grcov-by-cargo-llvm-cov
• create-pull-request/update-rust-version
• feat/silent-payments-with-rust-silentpayments
• fix/check-foreign-utxos-are-foreign
• master
• refactor/i-1695-remove-serde-json-dependency
• refactor/use-iterators-to-preselect-utxos

Build # 13293607264

Build Type

push

github

Committed by nymius

Commit Message

fix(wallet): off-by-one error checking coinbase maturity in optional UTxOs

The `preselect_utxos` method has an off-by-one error that is making the
selection of optional UTxOs too restrictive, by requiring the coinbase
outputs to surpass or equal coinbase maturity time at the current height
of the selection, and not in the block in which the transaction may be
included in the blockchain.

The changes in this commit fix it by considering the maturity of the
coinbase output at the spending height and not the transaction creation
height, this means, a +1 at the considered height at the moment of
building the transaction.

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

12141 of 14105 relevant lines covered (86.08%)

22248.64 hits per line