nunnatsa / ginkgolinter

78%

main: 88%

LAST BUILD ON BRANCH refactor-ginkgo-handler

branch: refactor-ginkgo-handler

CHANGE BRANCH

x

Reset

Sync Branches

• refactor-ginkgo-handler
• Add-Enhancement-Suggestion-template
• add-badges
• add-bug-report-template
• add-contrib-guide
• add-is
• add-linter-cover
• add-pr-template
• add-revive-linter
• add-rules
• add-to-readme
• allow-multi-edit
• allow-underscore
• automation-improvements
• bug-fix
• bug-fixes
• bump-dependencies
• bump-deps
• bump-deps-testdata
• bump-go-1.21
• bump-go-1.22
• bump-go-to-1.24
• bump-golangci-lint
• bump-lint
• bump-tools-v0.28.0
• bump-typeparams
• bump-x-tools
• bump_golang.org/x/tools_to_v0.31.0
• cap-equal
• check-wrong-bool-asert
• chor-update-deps
• cleanup
• code-improvements
• compare-len
• compare-types
• cont-refactoring
• dependabot/go_modules/github.com/go-toolsmith/astcopy-1.1.0
• dependabot/go_modules/golang.org/x/tools-0.10.0
• dependabot/go_modules/golang.org/x/tools-0.11.0
• dependabot/go_modules/golang.org/x/tools-0.11.1
• dependabot/go_modules/golang.org/x/tools-0.12.0
• dependabot/go_modules/golang.org/x/tools-0.13.0
• dependabot/go_modules/golang.org/x/tools-0.14.0
• dependabot/go_modules/golang.org/x/tools-0.15.0
• dependabot/go_modules/golang.org/x/tools-0.16.0
• dependabot/go_modules/golang.org/x/tools-0.16.1
• dependabot/go_modules/golang.org/x/tools-0.17.0
• dependabot/go_modules/golang.org/x/tools-0.18.0
• dependabot/go_modules/golang.org/x/tools-0.19.0
• dependabot/go_modules/golang.org/x/tools-0.20.0
• dependabot/go_modules/golang.org/x/tools-0.21.0
• dependabot/go_modules/golang.org/x/tools-0.22.0
• dependabot/go_modules/golang.org/x/tools-0.23.0
• dependabot/go_modules/golang.org/x/tools-0.24.0
• dependabot/go_modules/golang.org/x/tools-0.26.0
• dependabot/go_modules/golang.org/x/tools-0.27.0
• dependabot/go_modules/golang.org/x/tools-0.28.0
• dependabot/go_modules/golang.org/x/tools-0.29.0
• dependabot/go_modules/golang.org/x/tools-0.31.0
• dependabot/go_modules/golang.org/x/tools-0.32.0
• dependabot/go_modules/golang.org/x/tools-0.33.0
• dependabot/go_modules/golang.org/x/tools-0.35.0
• dependabot/go_modules/golang.org/x/tools-0.36.0
• dependabot/go_modules/golang.org/x/tools-0.38.0
• dependabot/go_modules/golang.org/x/tools-0.6.0
• dependabot/go_modules/golang.org/x/tools-0.7.0
• dependabot/go_modules/golang.org/x/tools-0.8.0
• dependabot/go_modules/golang.org/x/tools-0.9.1
• dependabot/go_modules/golang.org/x/tools-0.9.3
• doc-improve
• docs-fix-typos
• double-neg
• enable-dependabot
• error-async
• eventually-func
• fake-pr
• feat/constructor-config
• fix-100
• fix-115
• fix-124
• fix-171
• fix-190
• fix-211
• fix-82
• fix-91
• fix-badges
• fix-bug
• fix-comp-type-rule
• fix-false-positive
• fix-issue-88
• fix-name
• fix-pointer-bug
• fix-pr-template
• fix-sanity
• fix/go-mod
• fix/unalias
• focus-spec
• force-expect-to
• ginkgohandler-unit
• git-ignore-bin
• gitignore
• global-expect
• go-downgrade-1.20
• go1.20
• go119
• golangci-lint
• gomega-only
• havelen0
• helper-methods
• improve-gomega-detection
• improve-tests
• internal
• main
• matcherror
• more-bins
• nav/enforce-correct-succeed-usage
• new-bool-check
• no-assertion-rule
• nogo-support
• optional_description_rule
• patch-1
• pointer-val
• prevent-focus
• readme-opening
• refactor
• refactor/fix-typos
• simplify-error-msg
• small-refactor
• smaller-files
• sprintf-msg
• succeed-rule
• support-hold-label
• test-pr
• testscript
• timing
• tiny-cleanup
• tiny-fix
• to-and-not
• update-CONTRIBUTING
• update-dependencies
• update-deps
• var-unit-tests
• vars-in-containers
• version

Build # 11663392035

Build Type

Pull #166

github

Committed by nunnatsa

Commit Message

better way to find the actual expression

In gomega expression, the current code knows how to skip the helper
method like `WithOffset()` and get to the actual method (e.g. `Expect`).

The problem is that this logic is done by comparing to a static list of
method names. If a new method will be added, we'll have to add it to the
list each time.

This commit fixes the issue by skiping any non-actual method.

Also, move things around for better oerdering.

Pull Request Pull Request #166: Refactor ginkgo handler

Run Details

83 of 345 new or added lines in 10 files covered. (24.06%)

2181 of 2809 relevant lines covered (77.64%)

1012.93 hits per line