numberly / appnexus-client

90%

master: 87%

LAST BUILD ON BRANCH 0.7.2

branch: 0.7.2

CHANGE BRANCH

x

Reset

• 0.7.2
• 0.4.0
• 0.4.1
• 0.4.2
• 0.4.3
• 0.5.0
• 0.6.0
• 0.6.1
• 0.6.2
• 0.7.0
• 0.7.1
• 0.7.3
• 0.7.4
• 0.7.5
• 0.8.0
• 0.8.1
• develop
• documentation/badge-corners
• feature/changelog
• feature/documentation
• feature/logging
• features/budget-splitter-service
• fix/#45
• master
• thingy

Build # 86

Build Type

push

travis-ci

Committed by ramnes

Commit Message

Fix the custom data representation mechanism

It seems that the custom data representation mechanism was broken for a long
time, and for several reasons, the main one being that `Client.representation`
was unintentionally ignored.

This commit:
* adds a test to check that the `Client.representation` is indeed used;
* rollbacks the custom data representation API to `object` being a dictionary,
  not a Thingy (because converting to a Thingy is made with a representation
  function, `Service.constructor`);
* reverts `representations.raw` to its original state.

Run Details

314 of 350 relevant lines covered (89.71%)

4.49 hits per line