npr / npr-one-api-js-sdk

100%

main: 100%

LAST BUILD ON BRANCH fix/ng5

branch: fix/ng5

CHANGE BRANCH

x

Reset

• fix/ng5
• add-caption
• bugfix/examples
• dependabot/npm_and_yarn/coveralls-3.1.1
• dependabot/npm_and_yarn/es6-error-4.1.1
• dependabot/npm_and_yarn/esdoc-1.1.0
• dependabot/npm_and_yarn/esdoc-importpath-plugin-1.0.2
• dependabot/npm_and_yarn/eslint-3.19.0
• dependabot/npm_and_yarn/eslint-config-airbnb-base-15.0.0
• dependabot/npm_and_yarn/eslint-plugin-import-1.16.0
• dependabot/npm_and_yarn/js-logger-1.6.1
• dependabot/npm_and_yarn/semantic-release-17.4.3
• dependabot/npm_and_yarn/semantic-release-17.4.4
• dependabot/npm_and_yarn/semantic-release-17.4.7
• dependabot/npm_and_yarn/semantic-release-18.0.0
• dependabot/npm_and_yarn/semantic-release-18.0.1
• dependabot/npm_and_yarn/semantic-release-19.0.2
• dependabot/npm_and_yarn/semantic-release/git-9.0.1
• dependabot/npm_and_yarn/sinon-chai-2.14.0
• dependabot/npm_and_yarn/url-parse-1.5.10
• dependabot/npm_and_yarn/url-parse-1.5.3
• dependabot/npm_and_yarn/url-parse-1.5.4
• dependabot/npm_and_yarn/webpack-5.51.1
• dependabot/npm_and_yarn/webpack-5.55.1
• dependabot/npm_and_yarn/webpack-5.61.0
• dependabot/npm_and_yarn/webpack-5.64.4
• dependabot/npm_and_yarn/webpack-5.65.0
• dependabot/npm_and_yarn/webpack-5.68.0
• dependabot/npm_and_yarn/webpack-5.69.1
• dependabot/npm_and_yarn/webpack-5.71.0
• dependabot/npm_and_yarn/webpack-5.72.0
• feature/additional-exports
• feature/follow-show
• feature/hostname-changes
• feature/https
• feature/js-proxy-support
• feature/resume-flow
• feature/stationfinder-v3
• feature/typings
• fix/types
• git-issue-9
• issue-9
• issue-9-node-6
• main
• master
• npr-scoping-issue-10
• revert-16-update-node-issue-9
• update-node-issue-9
• vbad

Build # 81

Build Type

push

travis-ci

Committed by xiehan

Commit Message

fix(index): Avoid syntax that is too clever

Our Angular app's build optimizer is failing to produce a working production build, breaking on [line 90](https://githu
b.com/npr/npr-one-api-js-sdk/blob/v2.0.0/src/index.js#L90) saying `NprOneSDK._config` is null/undefined. While I'm not p
ositive, I suspect we were being too clever in the way we were trying to initialize the config by just calling `NprOneSD
K.config` (the getter) without assigning it to a variable, which confuses Angular's build optimizer and potentially drop
ped the getter as unused code.

Run Details

763 of 763 relevant lines covered (100.0%)

129.87 hits per line