nomad-coe / nomad-simulations

68%

develop: 90%

LAST BUILD ON BRANCH v0.4.0

branch: v0.4.0

CHANGE BRANCH

x

Reset

Sync Branches

• v0.4.0
• 100-different-structure-classes
• 100-moving-simulation-workflow-definitions-to-this-repo
• 100-trying-restructured-workflows
• 101-complete-basis-set-migration
• 106-allowing-311-python-version
• 110-using-hdf5dataset-for-greens-functions-properties
• 113-add-force-field-schema
• 113-add-force-field-schema-GPT-fill
• 115-issues-with-dft-xc-extraction
• 126-minor-fixes
• 130-atom-centered-basis-set
• 131-add-mkdocstrings-to-docu
• 136-add-some-methods-for-the-cell
• 138-define-n_atoms_per_unit_cell-for-tb-model-method
• 143-physicalproperty-rank-checks-broken
• 143-physicalproperty-rank-checks-broken-2
• 180-check-creation-of-composition-formula
• 212-electronic-structure-navigation
• 225-decide-exact-usage-of-is_representative
• 240-disambiguate-crystal-symmetry-symbols
• 242-move-wyckoff-to-positions
• 244-enforce-system-tree-integrity
• 28-add-md-relevant-outputs
• 4-documentation-modelmethod-numericalsettings
• 4-documentation-modelsystem-atomsstate
• 4-documentation-outputs-physicalproperty
• 47-add-thermodynamics-output
• 55-add-electronicgreensfunction-and-electronicselfenergy-properties
• 73-modelsystem-for-h5md
• 86-implement-hdf5datasets-for-potentially-large-quantities
• 9-add-unit-testing
• 92-further-abstraction-in-modelmethod
• 94-fix-readme
• 98-adding-isort-for-the-formatting
• JFRudzinski-patch-1
• adapting-new-entry-points-structure
• add-representation-section
• add-workflow-tests
• add-workflows
• add_cff_file
• add_system_orbitals
• add_zenodo_doi
• adds_to_131
• ammend_phys_prop
• atom-centered-basis-set
• bump_dependencies
• cg-particle-support
• cg-particle-support-JFR
• cgbeadstate
• cgbeadstate-2
• cgbeadstate-2-div
• charge-density-h5
• cicd_python_version
• clarify_subsystem_referencing
• clean_electronic
• clean_schema
• coupled_cluster
• develop
• disable-workflow-ref-tests
• docs_workflows
• documentation
• documentation-sprint
• extend-workflows
• extend_equalities
• fix-bond-list
• fix-docstrings-modelsystem
• fix-geometric-space-warning
• fix-h5md-test
• fix_equal_operator_in_cell
• fix_particle_indices
• fix_pipeline
• fixes
• fixing_repo_release
• h5md-refactor
• hot-fix
• hot-fix-model-system
• logger-decorator
• migrate-md
• nmr-schema-atom-labels
• orbitals-allow-l0
• patch-bad-import
• phys_prop_2025-05-16
• physical-property-tweaking
• physical-property-tweaking-rebase
• playing_graphviz
• positive_data_types
• qc-model-method-contributions
• qc-single-reference
• quick_fix_workflow
• redo-physical-property
• redo-physical-property-JFR
• refactoring-model-system
• remove-dependency-of-placeholder
• remove_phys_prop
• remove_phys_prop-EBB-test
• remove_phys_prop-JFR-test
• revert-243-extend-workflows
• ri-approximation
• shape_decorators
• sprint-dft-qchem
• subroutine_name
• subsection_index
• test-branch
• test_new_physical_props
• test_phys_prop_annotations
• test_push
• update-pip-installation-without-index
• update_link
• utils_check_simulation_cell
• v0.0.0
• v0.0.1
• v0.0.2
• v0.0.3
• v0.0.4
• v0.0.5
• v0.0.6
• v0.0.7
• v0.1.0
• v0.1.1
• v0.1.2
• v0.2.1
• v0.3.1
• v0.3.2
• v0.5.0
• version_tag
• warnings_and_errors

Build # 14862385886

Build Type

push

github

Committed by web-flow

Commit Message

Refactoring model system (#170)

* work with basesections.v2

* remove the redundant child model_system subsection

* move positions Quantity to ModelSystem

* AtomsState(Element), remove helper functions, modify normalize() to check consistency between chemical_symbol and atomic_number

* remove positions and velocities from Cell

* move ASE Atoms object creation to ModelSystem

* add sub_systems to ModelSystem

* add total_charge and total_spin to ModelSystem

* add ModelSystem.sub_systems instead of ModelSystem.model_system

* move comparison functions from AtomicCell to ModelSystem

* add ParticleState and CoarseGrainedState

* Refactor symmetry resolution: use dict mapping for cell types

* remove atom_types and related tests

* remove too many warnings in get_chemical_symbols

* ModelSystem.particle_states instead of atom_states

* remove redundant positions length checks

* n_particles and particle_indices (instead of n_atoms and atom_indices)

* add a note in GeometricSpace.get_geometric_space_for_atomic_cell

* modify to_ase_atoms, test_numerical_settings.py 

* modify conftest so that model_system.positions are populated

* import the v2 Entity in physical_property.py

* Fix DOSProfile normalization factor resolution to use model_system.particle_states

* Remove unused variable from SlaterKosterBond normalization test

* fix APW-refs fixture in conftest.py

* fix spectral profile tests

* Remove redundant try/except around get_geometric_space_for_atomic_cell

* add a test for composition formula

Run Details

140 of 187 new or added lines in 7 files covered. (74.87%)

42 existing lines in 5 files now uncovered.

1899 of 2804 relevant lines covered (67.72%)

0.68 hits per line