noironetworks / opflex

76%

master: 68%

LAST BUILD ON BRANCH indus-cfd

branch: indus-cfd

CHANGE BRANCH

x

Reset

• indus-cfd
• coveralls
• master
• snat
• svc-arp
• droplog_test
• adjust_drop_counters
• travis_build_fix
• access-allow-untagged
• l2c
• multi-travis
• tsan-check
• prometheus-cpp
• enable-prometheus
• flag_sync
• coverity
• grafana
• deb-rules
• common-getuuid
• cov_0513
• build-opt
• mac-vector-leak
• of-timeout
• erspan-updates
• enable-sanitizers
• unresolved_rels
• tsan-issues
• ubsan
• lgtm_build
• remove-vlog
• fix_lgtm
• cleanup-lgtm-complaints
• ubsan-disable
• lgtm_fixes
• debian_warnings-2
• travis-log
• debian_warnings-3
• travis-logs
• tsanissues-jsonrpc
• lgtm-fixes
• lgtm_2
• epcounter
• epcounter-tests
• remoteep-tests
• tsan-erspan
• ofpeer
• remove-debug5
• remove-clone
• unrel_count
• const-operator
• unrel_pol2
• unrel_pol3
• lgtm-1
• lgtm-2
• tsan-cleanup
• jsonrcp-errormsg
• unresolved_relations
• lgtm-coverty-1
• unresolved_relations_2
• ovsdb-rework
• tsan-afm
• jsonrpc-monitor
• lgtm-cleanup
• cov-1
• lgtm-lo
• rework-jsonrpc-code
• lgtm-revert
• coverity_fix_01
• cov-2
• lgtm-prom
• except-1
• coverity_0529
• grafana-images
• grafana-2
• coverity_0531
• cov-fixes
• ovsdb-update
• prom_unit_test
• coverity_0601
• file_dump_unresolved
• coverity_0602
• cov-exc
• jsonrpc-monitor-support
• gbpserver-coverity
• remove-unused-method
• fix-deb-rpm
• grpc-coverity
• lgtm-grpc-build
• cfd-ut
• tupledata-rename
• pthread-6-8
• mcast-flaky
• runtime-6-10
• coveralls-logs
• ct-rel
• ovsdb-async
• gprof
• span-create-delete
• ovsdb-ut
• ovsdb-update-mock-fix
• flaky-tests-6-16
• unicast_garp
• totals-1
• snat_test_coverage
• remove-snat-unset
• add-dir-order-to-sg
• grafana-6-23
• peer-tsan
• ovsdb-test-update
• tunnel-mtx
• atomic-1
• cpp-min-version-change
• genie-gen-c++11
• lock-cleanup-1
• remove-oftypes
• revert-agent-c++14
• remove-cpp-version-checks
• travis-rc
• gautvenk-patch-1
• snat-uts
• add-cwrapper-uts
• fsdroplog-ut
• droplogcfg
• droplogger_thread
• span-ut
• uc-6-29
• service-UT
• enhance-epfile-tests
• serialize-unresolved
• grafana-uc
• set-erspan-dir
• ospm-7-2
• snat-fixes
• ubsan-enable
• os-tsan-1
• complaint-cleanup
• std-to-string
• coverity-fixes-uninit
• test-updatemos
• erspan-id
• ovsdb-connect
• sm-7-13
• os-gbp-1
• faults_changes
• renderer-stop-fix
• genie-remove-reverse-relationship
• genie-relation-uris
• remove-epg-erspan
• os-refactor
• os-refactor-2
• os-tsan-7-23
• mock-server-1
• erspan-update-port
• span-uts
• lgtm-os
• opflex_epfaults
• grpc-travis
• nat-fixes
• os-tsan-8-6
• collapse-debug-levels
• prefer-range-for
• os-deadlock-8-10
• grpc-v1.31.0
• reduce-logs
• span-coverage
• genie-codacity
• drop_deny
• grpc-cache
• coverity-8-14
• codacity-cleanup
• codacity-usleep
• opflex_denyrules
• deny_rules
• codacity
• codacity-8-14
• more-uts
• codacity-8-17
• cov-issue
• os-stats-8-20
• minor_br_access_fix
• cov-8-21
• rpm-deb-8-23
• githash-incorrect
• ovsdb-id
• dup-os-on-os
• parse_fix
• server-prom
• incorrect_arg_droplog
• event_array_fix
• ofstats-del
• svc-dup
• remove-asssert
• os-grafana
• server-readme
• exc_err_log
• span-bridge-fix
• timer-mutex
• cleanup-dotfiles
• csr-flows
• lgtm-grpc
• faults-rpm-deb
• ipfix-fields
• travis-focal
• timer-protect
• add-extepfile-test
• deny_rule_2
• ipfix-output-only
• dropflow-ut
• ipfix-domid
• con_deny
• csr-integration
• fixes
• removelog
• csr-service
• test-dscp
• revert-258-dscp_2
• svc-loopback
• clsr
• devtoolset-8
• rhel8-rpm
• svc-stats-disable
• disable-untagged-dup
• clsr2
• jefferson
• bump-version
• bpf
• rhel8rpm
• reduce-noisy-logs
• jefferson-logs
• policydrop
• overlay_tunnel_adv
• gbp_inspect-crash
• port-tunneladv-change
• clsr3
• revert-Revert-oshift-dup
• clsr4
• Revert-Revert-openshift-hack-jefferson
• service-secgrp-bypass
• svc-bypass-secgrp-jefferson
• 5.1.1.0
• cleanup_droplogs
• logaction
• fix_uninit_tests
• codacy-warnings
• opflex-svc-stats-thread
• jefferson-svc-stats-thread
• ubuntu2010-failure
• revert-297-jefferson-svc-stats-thread
• 5.1.1.1
• move-to-ovs-renderer
• remove-simstats
• reduce-travis-usage
• tsan-fixes
• tsan-clang-cleanup
• add-lgtm-rules
• loopback-lb
• triangular-deadlock
• cleanup-includes
• config_filter_droplog
• tsan-epcounter
• backport-fixes
• jefferson-lb-loopback
• judith
• bump-release
• more_default_rules
• mac_mask
• backport_droplog_pruning
• gbpinspect
• fix_tsan
• backport_tsan_fix
• ssu-wipe
• genie-cleanup
• qos-coverage
• update-docs
• fault_manager
• droplog-uts
• modb-count-agent
• openssl
• svc-stale
• port-commits
• certs
• prometheus-doc
• sys-stats-1
• 5.1.3.0
• focal-travis
• mtufault
• faultcode
• backport_drop_prune_bug
• prune_bug
• epfaults_UT
• upgrade-prom-cpp
• asan-gbp-issues
• fix-travis-badge
• 5.1.3.1
• increase-ovsdb-buffer-size
• judith-buffer-size-bump
• add-missing-stop
• egress_dns
• 5.1.3.2
• focal-disable-deb-test
• configured-peer-issue
• judith-peer-reset
• overflow-on-read
• judith-buffer-issue
• deb-build-problems
• prom-define-remove
• kwai
• bump-vers-k+
• 5.2.1.0
• backport_egress_dns
• remote-ep
• 5.1.3.3
• tsan-ubuntu2010
• dns_fixes
• prom-deps
• fix-cov-issue
• prom-conditionals
• tsan_cov_fix
• fix-unavail-resolves
• dns_records
• kwai-prom-0.12.1
• session-aff
• rpm_fix
• kwai-session-aff
• fix_acc_br_pktin
• epdeclare
• recursive_resolve
• kwai-remote-ip
• judith-remote-ip
• 5.1.3.4
• ubuntu-21.04-issue
• nat-prio
• kwai-nat-prio
• judith-nat-prio
• rework-boost-placeholder-usage
• jefferson-ovsdb
• jefferson-peer-list-reset
• jefferson-invalid-read
• configurable-timeouts
• kwai-keepalive
• dns_bkup_restore
• rpm_build_fix
• parse_srv
• srv_flow_changes
• cleanup-qos
• permit_logging
• svc-stats-flow-disable
• dns_uts
• 5.2.1.1
• svc_flood
• 5.2.1.2
• 5.2.3.0
• 5.1.3.5
• kmr2
• 5.2.3.1
• 5.2.3.2
• bbva
• kmr2-bbva
• fix_droplog_access_flow
• backport-krm2
• 5.2.3.3
• droplog_part1
• 5.2.3.4
• asyncjson
• asyncjson-kmr2
• asyncjson_kmr2
• 5.2.3.5
• pruning_core_fix
• backport_droplog_prune
• restart
• kmr2-restart
• kmr2-revert
• backport_droplog_part1
• fix_commit_message
• fix_commit_message_kmr2
• 5.2.3.6
• prom-v1.0.1
• prom-v1.0.1-kmr2
• change-retry-timeout
• kmr2-change-retry-timeout
• 5.2.3.7
• test-en
• centos
• backport-kmr2
• testing
• encap
• centos-master
• disable-scheduled-codeql-scan
• sumit-kmr2-travis-builds
• addcodeqlfilter
• kmr2-5.2.7
• multiple-switches
• fix-liopflex-uts-ubuntu2304
• update-codeql-config
• fix-60min-outage
• fix-pre-handshake-timeouts
• time_gprof
• jammy-travis-wait
• jammy-disabledgprof
• dual-stack
• nat
• lmr
• remove_travis_tags
• snat-bounce
• ubuntu23.10
• fix-certs
• fix-lmr
• fix-ssl-version
• fix-ssl
• coveralls-reporting-fixes
• ovs-lib-includes
• ubi
• apic
• startup-enable
• more-cov-issues
• opflex-hpp-optimization
• startup
• inspect-timeout
• cpp14-bump
• lmr-inspect
• rpmbuild
• ubi9rpmbuild
• lmr-6.0.4
• cicd-lmr-update
• fix_dropprunecore
• lmr-stoul
• opflex-fixes
• add_pipeline_script
• opflex-rpm
• anm-opflex-rpm
• reset-wait
• local-hpp-tests
• bhav-opflex-rpm
• local-hpp-counters
• backport_prune_fix
• prr-fixes
• mmr-6.1.1
• high_freq_timers
• high_freq_timers-mmr-6.1.1
• high_freq_timers-lmr-6.0.4
• anm-patch
• vmotion-reset-all-peers
• test-old-master
• arm64
• drop-log-redirect-args

Fix for agent crash reported in CSCvu46192/SR689109894

Root cause:
During leaf replacement of VPC member, the tep ip of replaced leaf changes. Due to this we remove the stale opflex peer connection and add new tep ip of replaced leaf. During this process we seem to be hitting crash due to hoisting issue in BOOST_FOREACH.
More details on this here: https://www.boost.org/doc/libs/1_73_0/doc/html/foreach/pitfalls.html

Tests performed:
./opflex_server --policy=/home/noiro/work/opflex/agent-ovs/policy.json --peer "127.0.0.1:8010" <-- this is agent's configured peer that listens on 8009
./opflex_server --policy=/home/noiro/work/opflex/agent-ovs/policy.json --peer "127.0.0.1:8011" --peer "127.0.0.1:8012" --server_port 8010
./opflex_server --policy=/home/noiro/work/opflex/agent-ovs/policy.json --peer "127.0.0.1:8012" --peer "127.0.0.1:8013" --server_port 8011
./opflex_server --policy=/home/noiro/work/opflex/agent-ovs/policy.json --peer "127.0.0.1:8013" --peer "127.0.0.1:8011" --server_port 8012
sudo ./opflex_agent -c ~/agent.conf 2>&1 | tee agent.log

TODO: this will be followed up with UT in libopflex to hit the exact case which led to crash

Signed-off-by: Gautam Venkataramanan <gautam.chennai@gmail.com>