nielstron / opshin

91%

dev: 92%

push

github

Fix issue #3 with 1st Model

Summary of Changes:
The user wants error messages to point to the correct location (filename, line, and column) within an imported library, rather than pointing to the `import` statement in the file that imports the library.

The root cause of the original issue is the `RewriteLocation` AST transformer, which uses `ast.copy_location` to replace the location information of all nodes from an imported file with the location of the `import` statement.

The provided patch attempts to fix this by introducing a `trace_filename` flag. However, the implementation is flawed and does not resolve the issue:
1.  The call to `ast.copy_location(node, self.orig_node)` remains in the `RewriteLocation.visit` method and is executed unconditionally. This means the line and column numbers of nodes from the imported library are still being overwritten with the location of the `import` statement. This core part of the problem is not fixed.
2.  The new logic added under the `trace_filename` flag is `node.filename = self.orig_node.filename`. This line explicitly sets the filename of the library's AST nodes to the filename of the *importing* file (`self.orig_node` is the import statement). This is the opposite of the desired behavior, which is to preserve the original filename of the library where the error occurred.

In summary, the patch fails to correct the line and column number reporting and introduces new logic that makes the filename reporting explicitly incorrect. Therefore, the issue has not been resolved.

Duration: 13m 40s

1921 of 2322 branches covered (82.73%)

Branch coverage included in aggregate %.

8 of 9 new or added lines in 1 file covered. (88.89%)

4765 of 5033 relevant lines covered (94.68%)

1.87 hits per line