necojackarc / auto-request-review

89%

master: 89%

Pull #139

github

Fix last_files_match_only to evaluate per file instead of globally (#135)

Previously, when last_files_match_only was enabled, every time a pattern
matched any changed file, all previously accumulated reviewers were
cleared. This meant the last pattern that matched ANY file in the PR
determined all reviewers, which was wrong when different files had
different last-matching patterns.

Now, for each changed file independently, we find its last matching
pattern's reviewers, then union the results across all files. This
correctly handles the case where e.g. a generated file overrides
reviewers to [] while a non-generated file in the same directory still
matches the wildcard pattern's reviewers.

59 of 70 branches covered (84.29%)

Branch coverage included in aggregate %.

153 of 168 relevant lines covered (91.07%)

7.36 hits per line