ndlib / sipity

100%

master: 98%

LAST BUILD ON BRANCH method-declaration-smithing

branch: method-declaration-smithing

CHANGE BRANCH

x

Reset

• method-declaration-smithing
• 784-ETD-Email-Respond-To-Advisor-Request
• DLTP-368-create-user-for-advisor-granting-that-user-advisor-review-ability
• DLTP-373
• I8n
• add-account-profile
• add-work-type-to-sip
• adding-ability-to-capture-advisor-comments
• adding-ability-to-modify-attachments
• adding-account-profile
• adding-actor-for-work-type-permission
• adding-additional-email-notifiers
• adding-advisor-requests-changes
• adding-advisor-signoff-form
• adding-agree-to-terms-of-deposit
• adding-approve-for-ingest-form
• adding-attachment-schema
• adding-authentication-required
• adding-authorization-enforcement-for-edits
• adding-authorization-required
• adding-available-event-triggers
• adding-conversion-method-for-entity-type
• adding-create-processing-entity-when-work-is-created
• adding-event-logging
• adding-explicit-declaration-of-polymorphic-relationship
• adding-file-attachment-handling
• adding-form-spec-verification
• adding-generation-of-sipity-command_repository_interface
• adding-guard-instructions
• adding-meta-request-and-rails-panel
• adding-processing-action-type
• adding-processing-subsystem
• adding-query-repository-interface
• adding-register-action-taken-on-entity
• adding-relationships
• adding-role-behavior
• adding-rudimentary-pid-minter
• adding-rudimentary-spec
• adding-thesis-defense-date-form
• adding-todo-list
• adding-work-enrichments
• adding-work-type-to-create-form
• adding-work-type-todo
• additional_attributes
• adjusting-additional-attributes
• advisor-signoff-form
• allow-new-sip-action-to-prepopulate-the-form
• altering-processing-state-dashboard-query
• amending-work-show-page
• augmenting-coverage-without-features
• augmenting-permission-model-docs
• bumping-rspec-given-version
• bumping-to-ruby-2.2.0
• capturing-who-took-the-action
• cleanup-vestigial-elements
• collaborators-ui
• create-access-rights-container
• dashboard-view
• defense-date-views
• delete-work
• deploy
• destroy-collaborators
• dltp-346-add-action-and-html-form-for-describing-etds
• dltp-347-add-action-and-html-form-for-describing-etds
• dltp-360-advisors-without-reform
• dltp-361
• dltp-366
• dltp-367
• dltp-370-dashboard-page
• email-notifier
• email-templates
• email_delivery_setting_for_staging
• enforcing-at-least-one-collaborator
• ensuring-that-emails-are-being-created
• experimental-test-harness
• exposing-access_rights-transient-answer
• exposing-the-delete-action
• extract-take-two
• extracting-common-methods-to-ancestor
• extracting-concept-of-transient-answers
• extracting-form-commands-to-relevant-form-objects
• extracting-mapping-function-for-group-name-to-role
• extracting-method
• extracting-policies
• extracting-submit_create_work_form
• extracting-transient-answer-commands
• file-management-ui
• fix-masters-thesis-label
• fix-work-type-display
• fixing-prereq-action-fulfillment-answer
• flash-message-bug
• handle-attaching-a-file
• improving-documentation
• inching-towards-better-documentation
• leverage-action-queries
• master
• more-internationalization
• moving-concepts-into-sub-modules
• moving-controllers-into-their-own-module
• moving-exceptions-into-logical-container
• moving-forms-into-subdirectory
• moving-models-into-subdirectory
• moving-object-in-inheritance-hierarchy-chain
• moving-runners-into-subdirectory
• normalizing-authorization-required
• normalizing-form
• notification-documentation
• panel-refinement
• persisting-sip-work-type
• preparing-for-production
• rearranging-schema.org-meaning
• refactoring-policy-questions
• refining-state-transitions
• removing-config-deprecation-notice
• removing-deprecation-usage
• removing-deprecation-warning
• removing-models-permission
• removing-some-view-logic
• removing-validation-of-publishing-date
• removing-vestigal-method
• removing-work-policy-acting-as-behavior
• renaming-action
• renaming-edit-header-form
• renaming-method
• renaming-method-to-better-reflect-method-signature
• renaming-notification-name-to-better-reflect-purpose
• renaming-policy-question
• renaming-role-to-acting-as
• renaming-sip-to-work
• renaming-state-for-etd-workflow
• replacing-action-name-with-enrichment-type
• replacing-schema.org-naming-to-help-accessibility
• reverting-to-ruby-2.1.5
• reverting-to-ruby-2.2.0
• reworking-attach-files
• reworking-authentication_layer-configuration
• reworking-low-hanging-module_function-declarations
• reworking-module-function-declaration
• reworking-new-sip-ui-to-be-card-based
• search-terms
• separating-query-and-command-repository
• splicing-in-permission-granting
• splicing-in-replacement-code
• switching-doi-creation-request-to-header-id
• teasing-apart-etd-into-doctoral-dissertation-and-masters-thesis
• teasing-out-enrichment
• teasting-out-repository-interaction
• tidying-up-code-coverage
• tidying-up-dltp-346
• todo-list-refinements
• todo-list-style
• tweaking-email-notifier
• typo
• update-terminal-notifications
• updating-based-on-walkthrough
• updating-processing-query
• view-wrangling
• which-is-more-expressive
• wiring-notifier-to-send-emails
• work-delete-refinements
• work-event-trigger-policy
• working-on-ability-to-delete-collaborators
• working-on-accessible-objects-form
• working-on-approve-on-behalf-of
• working-on-capturing-uploaded-files
• working-on-cas-integration
• working-on-command-permissions
• working-on-email-decorators
• working-on-initial-form-for-etds
• working-on-ldap-client
• working-on-processing-queries
• working-on-query-related-to-work-enrichments

Build # 440

Build Type

push

travis-ci

Committed by jeremyf

Commit Message

Moving module_function declaration to method def

My goal with this move is to improve the legibility of the module and
its related methods. My question to the reviewer is "Does this change
make the module easier to understand?"

As per a conversation with @rbalekai:

> it will probably help more in PRs
> when new methods are added to the modules
> so that we dont have to open the whole file to see whats doing on

Run Details

1353 of 1353 relevant lines covered (100.0%)

4.6 hits per line