nats-io / gnatsd
92%
master: 91%

Repo Added 19 Jun 2015 07:27PM UTC

Build # 2183

Committed by

Commit Message

[FIXED] Possible cluster `Authorization Error` during config reload

When changing something in the cluster, such as Timeout and doing
a config reload, the route could be closed with an `Authorization
Error` report. Moreover, the route would not try to reconnect,
even if specified as an explicit route.

There were 2 issues:
- When checking if a solicited route is still valid, we need to
  check the Routes' URL against the URL that we try to connect
  to but not compare the pointers, but either do a reflect
  deep equal, or compare their String representation (this is
  what I do in the PR).
- We should check route authorization only if this is an accepted
  route, not an explicit one. The reason is that we a server
  explicitly connect to another server, it does not get the remote
  server's username and password. So the check would always fail.

Note: It is possible that a config reload even without any change
in the cluster triggers the code checking if routes are properly
authorized, and that happens if there is TLS specified. When
the reload code checks if config has changed, the TLSConfig
between the old and new seem to indicate a change, eventhough there
is apparently none. Another reload does not detect a change. I
suspect some internal state in TLSConfig that causes the
reflect.DeepEqual() to report a difference.

Note2: This commit also contains fixes to regex that staticcheck
would otherwise complain about (they did not have any special
character), and I have removed printing the usage on startup when
getting an error. The usage is still correctly printed if passing
a parameter that is unknown.

Resolves #719

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>

8 of 8 new or added lines in 2 files covered. (100.0%)

7102 of 7694 relevant lines covered (92.31%)

78480.21 hits per line

7694 RELEVANT LINES 7102 COVERED LINES

78480.21 HITS PER LINE

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
2183	fix_reload_cluster_auth	[FIXED] Possible cluster `Authorization Error` during config reload When changing something in the cluster, such as Timeout and doing a config reload, the route could be closed with an `Authorization Error` report. Moreover, the route would not t...	Pull #720	16 Aug 2018 12:31AM UTC	web-flow	travis-ci	pending completion
2182	fix_reload_cluster_auth	[FIXED] Possible cluster `Authorization Error` during config reload When changing something in the cluster, such as Timeout and doing a config reload, the route could be closed with an `Authorization Error` report. Moreover, the route would not t...	push	16 Aug 2018 12:31AM UTC	kozlovic	travis-ci	pending completion

nats-io / gnatsd
92%
master: 91%

nats-io / gnatsd 92% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on fix_reload_cluster_auth

Recent builds

nats-io / gnatsd
92%
master: 91%

README BADGES
x

CHANGE BRANCH
x