mtreinish / stestr

69%

master: 68%

LAST BUILD ON BRANCH fix-encoding-py3

branch: fix-encoding-py3

CHANGE BRANCH

x

Reset

• fix-encoding-py3
• master
• add-code-of-conduct-1
• use-context-managers
• add-return-code-tests-from-func
• fix-test-bisect
• fix-trove-classifiers
• fix-whitelist-arg
• fix-docs
• add-abbreivate
• fix-run-subunit
• fix-serial-selection
• add-subunit-output-check
• fix-stdin-load
• drop-reno-docs
• limit-testing
• fix-subunit-stdout
• 1.1.0
• deprecate-partial
• update-travis
• update-license
• fix-six-cast
• testr-equiv-string-code
• fix-log-0-error
• fix-warning-message
• user-config
• user-config-functional-tests
• 2.0.0
• update-package-summary
• doc-fixes
• fix-man-link
• cli-man
• templates
• man-page-generation
• cap-pbr
• remove-windows-skips
• supress-stdout-attach
• attempt-cinder-fix
• missing-docs
• man-page-building
• cap-pip
• ignore-rm-errors
• manpage-config-fixes
• uncap-pip
• really-uncap-pbr
• revert-173-uncap-pip
• revert-166-cap-pip
• 2.1.0
• fix-run-desc
• fix-partial-load-help
• cleanup-failing-man-section
• invalid-regex-error
• fix-unxsuccess
• use-testtools_wasSuccessful
• add-py37
• 2.1.1
• pytest-style-paths
• fix-load-reported-time
• fix-py3-import-error-formatting
• update-readme
• change-readme-title
• 2.2.0
• rework-readme-overview
• fix-invalid-concurrency-value-error
• subunit-flag-doc-update
• debug-by-default
• add-repo-metadata
• add-contributing-to-readme
• fix-metadata-pbr
• 2.3.0
• 2.3.1
• remove-python2-support
• add-all-attachments
• add-py2-drop-notice
• rework-attachment-option-logic
• release-automation
• azure-pipelines
• 2.4.0
• irc-readme
• fix-min-failure
• subunit_run_vendor
• add-mailmap
• add-license-metadata-to-package
• fix-nonetype-timestamps
• 2.5.0
• only-use-stdlib-runner-py35
• 2.5.1
• dynamic-schedule
• add-pdb-mode
• add-3.8-support
• add-azure-py38
• 2.6.0
• prep-stestr-3.0.0
• 3.0.0
• drop-universal-wheel-travis
• 3.0.1
• update-hacking
• add-py39-support
• 3.1.0
• gha-ci

Build # 1130

Build Type

Pull #272

travis-ci

Committed by web-flow

Commit Message

Stop encoding attachments text

The attachments text in print_attachments() for the subunit_trace output
was encoding the text as utf8 for some reason which made the text of
type bytes. When bytes objects are printed by python 3 they're marked as
bytes by wrapping the text in b''. However this encode is unecessary (and
would likely break unicode characters) as just writing the str literals
for each line to the output stream works just fine. The encode() call was
added in [1] before stestr was started, and was just added for the case
of using LANG=C to set their locale to ASCII C. This was also before the
adoption of PEP 538 [2] which makes python use unicode even if LANG=C is
set. So removing the encode for supporting that use case shouldn't
matter anymore.

Fixes #243

[1] https://review.opendev.org/#/c/229527/
[2] https://www.python.org/dev/peps/pep-0538

Pull Request Pull Request #272: Stop encoding attachments text

Run Details

472 of 837 branches covered (56.39%)

1760 of 2566 relevant lines covered (68.59%)

0.69 hits per line