msabramo / gocover-cobertura

76%

master: 79%

LAST BUILD ON BRANCH testdata-dot-instead-of-templates-for-pkgpath

branch: testdata-dot-instead-of-templates-for-pkgpath

CHANGE BRANCH

x

Reset

• testdata-dot-instead-of-templates-for-pkgpath
• calc-aggregates
• coveralls-badge
• master
• omit-data-not-computed
• travis-coveralls

Build # 16

Build Type

push

travis-ci

Committed by msabramo

Commit Message

Use testdata as-is without gen from template

While trying to run `gocover-cobertura` on `testdata/testdata_set.txt`, I noticed that
it's actually a Go template; not actual data; so the tool can't process
it. The template seems to be just to replace `{{.PkgPath}}` with the
current directory. By using `.` instead in that file, it eliminates the
need for a bunch of code for rendering the template (it eliminates
2 stdlib imports, not that it's a big deal)

Before:

```
$ gocover-cobertura < testdata/testdata_set.txt | head -n 18
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
<coverage line-rate="0" branch-rate="0" version="" timestamp="1518632283054" lines-covered="0" lines-valid="0" branches-covered="0" branches-valid="0" complexity="0">
	<sources>
		<source>/usr/local/Cellar/go/1.10rc1/libexec/src</source>
		<source>/Users/abramowi/go/src</source>
	</sources>
	<packages></packages>
</coverage>
```

After:

```
$ gocover-cobertura < testdata/testdata_set.txt | head -n 18
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
<coverage line-rate="0" branch-rate="0" version="" timestamp="1518632265239" lines-covered="0" lines-valid="0" branches-covered="0" branches-valid="0" complexity="0">
	<sources>
		<source>/usr/local/Cellar/go/1.10rc1/libexec/src</source>
		<source>/Users/abramowi/go/src</source>
	</sources>
	<packages>
		<package name="./testdata" line-rate="0" branch-rate="0" complexity="0">
			<classes>
				<class name="-" filename="./testdata/func1.go" line-rate="0" branch-rate="0" complexity="0">
					<methods>
						<method name="Func1" signature="" line-rate="0" branch-rate="0" complexity="0">
							<lines>
								<line number="4" hits="1"></line>
								<line number="5" hits="1"></line>
								<line number="5" hits="0"></line>
								<line number="6" hits="0"></line>
```

Run Details

183 of 240 relevant lines covered (76.25%)

23.04 hits per line