mrodrig / json-2-csv

98%

stable: 98%

LAST BUILD ON BRANCH feat/improved-excludeKeys-matching

branch: feat/improved-excludeKeys-matching

CHANGE BRANCH

x

Reset

• feat/improved-excludeKeys-matching
• 235
• 3.14.0
• 3.14.1
• 3.14.2
• 3.14.3
• 3.14.4
• 3.15.0
• 3.15.1
• 3.16.0
• 3.16.1
• 3.17.0
• 3.17.2
• 3.18.0
• 5.1.0
• add-node-10-for-testing
• apr22-npm-audit-fix
• audit-fixes
• chore/audit-fix/oct22
• dependabot/npm_and_yarn/glob-parent-5.1.2
• dependabot/npm_and_yarn/json5-2.2.3
• dependabot/npm_and_yarn/minimist-1.2.6
• dependabot/npm_and_yarn/path-parse-1.0.7
• feat/add-escapeNestedDots-option
• feat/add-key-expansion-functionality
• feat/excludeKeys-regexp-support
• feat/headerless-csv-support-227
• feat/support-for-207
• fix-168
• fix-184
• fix-197
• fix-208
• fix-214
• fix-222
• fix-230
• fix-240
• fix-254
• fix-265
• fix/field-after-wrap
• june24-audit-fix
• main
• may-10-npm-audit-fix
• nested-arrays-273
• npm-audit-fix
• oct23-npm-audit-fix
• peacechen-stable
• refs/tags/3.19.0
• refs/tags/3.20.0
• refs/tags/4.0.0
• refs/tags/4.0.1
• refs/tags/4.1.0
• refs/tags/4.1.1
• refs/tags/5.0.0
• refs/tags/5.0.1
• refs/tags/5.1.0
• refs/tags/5.2.0
• refs/tags/5.3.0
• refs/tags/5.4.0
• refs/tags/5.5.0
• refs/tags/5.5.1
• refs/tags/5.5.2
• refs/tags/5.5.3
• refs/tags/5.5.4
• refs/tags/5.5.5
• refs/tags/5.5.6
• refs/tags/5.5.7
• refs/tags/5.5.8
• refs/tags/5.5.9
• release-5.5.8
• sept24-audit-fix
• stable
• tsify
• updates-for-cli
• v5-prep

Build # 7983786658

Build Type

Pull #246

github

Committed by mrodrig

Commit Message

fix: resolve potential excludeKeys match to a key path other than at the start of a string

In a case where `excludeKeys` is set to `["arr"]`, there was a possibility that with JSON data looking like this:

```
[
    {
        "id": 1,
        "arr": [
            {
                "name": "foo"
            }
        ],
        "name": {
            "arr": "this should appear"
        }
    },
    {
        "id": 2,
        "arr": [
            {
                "name": "bar"
            }
        ],
        "name": {
            "arr": "this should also appear"
        }
    }
]
```

could potentially result in both `arr.name` and `name.arr` being excluded. By adjusting the RegExp thats being used for the matching, this fixes a potential bug that caused `name.arr` to be mistakenly excluded.

Pull Request Pull Request #246: Feat/improved exclude keys matching

Run Details

264 of 269 branches covered (98.14%)

374 of 382 relevant lines covered (97.91%)

828.14 hits per line