mperham / sidekiq

86%

master: 46%

LAST BUILD ON BRANCH 0_16

branch: 0_16

CHANGE BRANCH

x

Reset

• 0_16
• 1971-deprecate_instance_delay
• 2-x
• 3-0
• 4_0
• better_aj
• celluloid-17
• client-push-cleanup
• csrf
• eager_load
• extensible_proctitle
• feature/2173-changelog
• feature/client-di
• feature/dead-job-size
• feature/dont-ack
• feature/fetcher-join
• feature/fix-logging
• feature/freeze
• feature/multi-to-mget
• feature/pipelines
• feature/race
• feature/redis-pool-abstraction
• feature/redis-stats-protection
• feature/redis-use
• feature/reliable-fetch-fix-attempt
• feature/remove-unnecessary-variable
• feature/stats
• feature/usr1-readme
• feature/wait
• fix-travis-rbx
• fix_nil_multi
• graph-labels-locale
• heartbeat
• legend-fix
• lifecycle_events
• list
• master
• mutant
• quiet_api
• refactor_ctl
• reliable-scheduler-caveats
• responsive-summary
• revert-1837-master
• shardable_client
• smart_poll_interval
• task_thread
• tight-labels-are-right
• update-rickshaw
• usr1_shutdown
• v2.17.1
• v2.17.2
• v2.17.3
• v2.17.4
• v2.17.7
• v2.17.8
• v3.0.0
• v3.0.1
• v3.0.2
• v3.1.1
• v3.1.2
• v3.1.3
• v3.1.4
• v3.2.0
• v3.2.1
• v3.2.2
• v3.2.3
• v3.2.4
• v3.2.5
• v3.2.6
• v3.3.0
• v3.3.1
• v3.3.2
• v3.3.3
• v3.3.4
• v3.4.0
• v3.4.1

Build # 1854

Build Type

push

travis-ci

Committed by mperham

Commit Message

Rewrite shutdown signalling, fixes #2056

There's a race condition between sending the shutdown message and waiting for the "shutdown finished" signal to come back.  Instead use a shared CondVar which is not racy.

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

1977 of 2297 relevant lines covered (86.07%)

124.38 hits per line