mozilla / fx-private-relay
92%
main: 92%

LAST BUILD BRANCH: MPP-4398/migrate-from-circleci
DEFAULT BRANCH: main
Repo Added
Files 263
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH MPP-3505/fix-auth
branch: MPP-3505/fix-auth
CHANGE BRANCH
x

coverage: 91.553% (+0.2%) from 91.383%
eb53891d-7942-4104-b36e-3c0901bc94b1

Pull #6212

circleci

jwhitlock 
fix(api): Fixes for FxA token auth

Update `get_cache_key` for Firefox token introspection results, so that
the cache results are shared across processes.

Update `terms_accepted_user` to catch some unhandled exceptions:

* `Timeout` when the call to the FxA profile endpoint times out
* `NoReverseMatch` when django-allauth detects a user created at an
  unfortunate time by a parallel process (fixes MPP-3928)
* `IntegrityError` when django-allauth does not detect a user created at
  an unfortunate time by a parallel process (fixes MPP-3505)

For the last two exceptions, any changes are rolled back as well,
avoiding creating two `User` objects with the same email.

Additional changes:

* Refactor `terms_accepted_user` to make it clearer when 201 and 202
  status codes are returned.
* Avoid doing work in an exception handler than may also raise
  exceptions
* Break functionality into `_get_fxa_profile` and
  `_create_social_account`, to make room in the main function for
  exception handlers.
* Remove some unreachable code
* Add type annotations, and adjust tests to match types
Pull Request #6212: Fix cache, catch exceptions in /api/v1/terms-accepted-user (MPP-3505, MPP-3928)

3014 of 3873 branches covered (77.82%)

Branch coverage included in aggregate %.

60 of 60 new or added lines in 4 files covered. (100.0%)

18642 of 19781 relevant lines covered (94.24%)

13.02 hits per line

Relevant lines Covered
19781 RELEVANT LINES 18642 COVERED LINES
13.02 HITS PER LINE
Source Files on MPP-3505/fix-auth

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
eb53891d... MPP-3505/fix-auth fix(api): Fixes for FxA token auth Update `get_cache_key` for Firefox token introspection results, so that the cache results are shared across processes. Update `terms_accepted_user` to catch some unhandled exceptions: * `Timeout` when the call... Pull #6212 jwhitlock circleci
91.55
ad7b5482... MPP-3505/fix-auth fix(api): Catch NoReverseMatch, rollback Pull #6212 jwhitlock circleci
91.54
See All Builds (16357)