mozilla-services / pushgo

51%

dev: 62%

LAST BUILD ON BRANCH bug/handshake-no-validate

branch: bug/handshake-no-validate

CHANGE BRANCH

x

Reset

• bug/handshake-no-validate
• 1.5rc4
• 1.5rc5
• 1.5rc6
• bug/always-route-metrics
• bug/cors-headers
• bug/emcee-pooling-timeouts
• bug/fix-docker-build
• bug/local-deliver-on-always-route
• dev
• feature/CORS
• feature/apns_update
• feature/dynamo_store
• feature/fix-storage-close-tests
• feature/make-no-memcached
• feature/metrics-hostname-suffix
• feature/metrics-suffix-redux
• feature/net-tests-redux
• feature/no-default-prefix
• feature/remove-serve-closer
• feature/sample-rate
• feature/soft-storage
• feature/start-delay
• feature/tcp-user-timeout
• feature/travis-container-builds
• feature/websocket-fork
• master
• releases/1.5

Build # 838

Build Type

push

travis-ci

Committed by kitcambridge

Commit Message

Issue new device IDs to replace invalid IDs.

Previously, `WorkerWS.handshake()` returned `ErrInvalidID` and closed
the connection if the client sent an invalid ID. The Gecko client does
not currently detect non-200 responses or clear invalid IDs before
reconnecting. This can trigger a reconnect loop if the
`services.push.userAgentID` preference is set to an invalid value by
a user (via `about:config`) or third-party Simple Push server (the
spec recommends, but does not require, UUIDs).

This commit relaxes the server behavior to issue a new, valid device
ID if the client supplies an invalid one.

Run Details

3218 of 6325 relevant lines covered (50.88%)

111.32 hits per line