mozilla-services / pushgo

49%

dev: 62%

LAST BUILD ON BRANCH bug/emcee-pooling-timeouts

branch: bug/emcee-pooling-timeouts

CHANGE BRANCH

x

Reset

• bug/emcee-pooling-timeouts
• 1.5rc4
• 1.5rc5
• 1.5rc6
• bug/always-route-metrics
• bug/cors-headers
• bug/fix-docker-build
• bug/handshake-no-validate
• bug/local-deliver-on-always-route
• dev
• feature/CORS
• feature/apns_update
• feature/dynamo_store
• feature/fix-storage-close-tests
• feature/make-no-memcached
• feature/metrics-hostname-suffix
• feature/metrics-suffix-redux
• feature/net-tests-redux
• feature/no-default-prefix
• feature/remove-serve-closer
• feature/sample-rate
• feature/soft-storage
• feature/start-delay
• feature/tcp-user-timeout
• feature/travis-container-builds
• feature/websocket-fork
• master
• releases/1.5

Build # 749

Build Type

push

travis-ci

Committed by kitcambridge

Commit Message

Refactor `EmceeStore` pooling; adjust timeouts.

* Restrict `MaxConns` to 100.
* Allow specifying `""` or `"0"` as durations to disable timeouts.
* Adjust `{Recv, Send, Retry}Timeout` to match the docs.
* Disable `PollTimeout` by default. The 10ms timeout was causing
  intermittent smoke test failures.
* Replace the run loop with a `sync.Cond`.

Run Details

3013 of 6179 relevant lines covered (48.76%)

102.33 hits per line