mozilla-services / cliquet
100%
master: %

LAST BUILD BRANCH: 186-215-add-sqlachemy-pooling
DEFAULT BRANCH: master
Repo Added
Files 0
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor-backends-with-request
branch: refactor-backends-with-request
CHANGE BRANCH
x

2320

push

travis-ci

leplatrem 
Pass current request along every backends methods.

**Rationale*:

This small refactor paves the way for:

* persisting backend connections on current request (instead of pull/push from queue for each operation performed with one request, e.g batched requests)
* having one transaction per request (with a tween to connect / commit). Particularly interesting for batched requests. (see https://github.com/Kinto/kinto/issues/194)
* have one event per request, with every created/updated/deleted records of a batch

Of course, it may seem ugly to pass the request, but it is advocated [in Pyramid docs](http://pyramid.readthedocs.org/en/1.5-branch/narr/threadlocals.html#why-you-shouldn-t-abuse-thread-locals):

> get_current_request function should never be called because it’s “easier” or “more elegant” to think about calling it **than to pass a request through a series of function calls when creating some API design**. Your application should instead almost certainly pass data derived from the request around rather than relying on being able to call this function to obtain the request in places that actually have no business knowing about it.

We could pass a derived info like `request.bound_data`, but I like the fact to pass the request object.

Especially because it gives a lot of freedom in possible backend implementation (*imagine a box.com storage backend where original request headers are manipulated before being sent to third party service...*)

75 of 75 new or added lines in 13 files covered. (100.0%)

7170 of 7193 relevant lines covered (99.68%)

2.99 hits per line

Relevant lines Covered
7193 RELEVANT LINES 7170 COVERED LINES
2.99 HITS PER LINE
Source Files on refactor-backends-with-request
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
2320 refactor-backends-with-request Pass current request along every backends methods. **Rationale*: This small refactor paves the way for: * persisting backend connections on current request (instead of pull/push from queue for each operation performed with one request, e.g batc... push leplatrem travis-ci pending completion  
2316 refactor-backends-with-request POC push leplatrem travis-ci pending completion  
2313 refactor-backends-with-request POC push leplatrem travis-ci pending completion  
2258 refactor-backends-with-request POC push leplatrem travis-ci pending completion  
See All Builds (1221)