mozilla-releng / balrog

90%

main: 89%

LAST BUILD ON BRANCH its-dangerous-to-go-alone-take-this-state

branch: its-dangerous-to-go-alone-take-this-state

CHANGE BRANCH

x

Reset

• its-dangerous-to-go-alone-take-this-state
• 20250501
• HEAD
• ahal/push-lnpkkyxvuquk
• ahal/push-lsunytmtzqnv
• ahal/push-mklnsqmuksnv
• ahal/push-nztpozkmxqum
• ahal/push-omrtyztkomrn
• ahal/push-pvmxttzqrzrm
• ahal/push-pwpkutknwovm
• ahal/push-qxoxonntoooy
• ahal/push-rwonorwzozkv
• ahal/push-ulksryrykpvo
• app-factory
• app.testing
• auth0
• axios-bump
• badinputs-minus-one
• batch-user
• better-force-validation
• biome
• bump-3.65
• bump-3.66
• bump-3.73
• bump-3.74
• bump-3.83
• bump-deps
• bump-frontend-deps
• bump-pydeps
• bump-taskgraph
• bump-v3.72
• bump-v3.79
• bump-version
• bump-version-for-next-release
• bumubumubumu
• change-case-update
• ciscotest-staging
• cleanup
• client-out-of-workspace
• codemirror-react17
• codeowners
• compose
• compose-links
• connexion3
• cors-fix
• css-loader
• decision-v12.1.0
• dependabot
• dependabot/npm_and_yarn/ui/axios-0.30.0
• dependabot/npm_and_yarn/ui/axios-1.11.0
• dependabot/npm_and_yarn/ui/axios-1.12.0
• dependabot/npm_and_yarn/ui/axios-1.7.9
• dependabot/npm_and_yarn/ui/axios-1.8.1
• dependabot/npm_and_yarn/ui/axios-1.8.2
• dependabot/npm_and_yarn/ui/axios-1.8.3
• dependabot/npm_and_yarn/ui/axios-1.8.4
• dependabot/npm_and_yarn/ui/babel/core-7.26.10
• dependabot/npm_and_yarn/ui/babel/core-7.26.7
• dependabot/npm_and_yarn/ui/babel/core-7.26.8
• dependabot/npm_and_yarn/ui/babel/core-7.26.9
• dependabot/npm_and_yarn/ui/babel/preset-env-7.26.7
• dependabot/npm_and_yarn/ui/babel/preset-env-7.26.8
• dependabot/npm_and_yarn/ui/babel/preset-env-7.26.9
• dependabot/npm_and_yarn/ui/babel/preset-react-7.26.3
• dependabot/npm_and_yarn/ui/babel/runtime-7.26.10
• dependabot/npm_and_yarn/ui/deps-27c316fb00
• dependabot/npm_and_yarn/ui/deps-4a5c1193a4
• dependabot/npm_and_yarn/ui/deps-5287079acf
• dependabot/npm_and_yarn/ui/deps-a9c67bf045
• dependabot/npm_and_yarn/ui/deps-eaa1054ea9
• dependabot/npm_and_yarn/ui/dotenv-16.4.7
• dependabot/npm_and_yarn/ui/dotenv-16.5.0
• dependabot/npm_and_yarn/ui/dotenv-cli-8.0.0
• dependabot/npm_and_yarn/ui/downshift-9.0.9
• dependabot/npm_and_yarn/ui/elliptic-6.6.1
• dependabot/npm_and_yarn/ui/eslint-config-prettier-10.0.1
• dependabot/npm_and_yarn/ui/eslint-config-prettier-10.0.2
• dependabot/npm_and_yarn/ui/eslint-config-prettier-10.1.1
• dependabot/npm_and_yarn/ui/eslint-config-prettier-10.1.2
• dependabot/npm_and_yarn/ui/eslint-plugin-jest-28.11.0
• dependabot/npm_and_yarn/ui/eslint-plugin-jest-28.12.0
• dependabot/npm_and_yarn/ui/eslint-plugin-react-7.37.4
• dependabot/npm_and_yarn/ui/pbkdf2-3.1.3
• dependabot/npm_and_yarn/ui/prettier-3.4.2
• dependabot/npm_and_yarn/ui/prettier-3.5.0
• dependabot/npm_and_yarn/ui/prettier-3.5.1
• dependabot/npm_and_yarn/ui/prettier-3.5.2
• dependabot/npm_and_yarn/ui/prettier-3.5.3
• dependabot/npm_and_yarn/ui/qs-6.14.0
• dependabot/npm_and_yarn/ui/react-codemirror2-8.0.1
• dependabot/npm_and_yarn/ui/react-diff-view-3.3.1
• dependabot/npm_and_yarn/ui/react-number-format-5.4.3
• dependabot/npm_and_yarn/ui/react-number-format-5.4.4
• dependabot/npm_and_yarn/ui/react-router-dom-6.28.2
• dependabot/npm_and_yarn/ui/react-router-dom-6.29.0
• dependabot/npm_and_yarn/ui/react-router-dom-6.30.0
• dependabot/npm_and_yarn/ui/typescript-5.7.3
• dependabot/npm_and_yarn/ui/typescript-5.8.2
• dependabot/npm_and_yarn/ui/webpack-dev-server-5.2.0
• dependabot/npm_and_yarn/ui/webpack-dev-server-5.2.1
• dependabot/pip/agent/requirements/aiohttp-3.12.14
• dependabot/pip/agent/requirements/black-25.1.0
• dependabot/pip/agent/requirements/flake8-7.2.0
• dependabot/pip/agent/requirements/isort-6.0.0
• dependabot/pip/agent/requirements/pip-compile-multi-2.8.0
• dependabot/pip/agent/requirements/pytest-asyncio-0.25.0
• dependabot/pip/agent/requirements/pytest-asyncio-0.26.0
• dependabot/pip/agent/requirements/sentry-sdk-2.21.0
• dependabot/pip/agent/requirements/sentry-sdk-2.22.0
• dependabot/pip/agent/requirements/sentry-sdk-2.24.0
• dependabot/pip/agent/requirements/sentry-sdk-2.24.1
• dependabot/pip/agent/requirements/tox-4.25.0
• dependabot/pip/requirements/auth0-python-4.8.0
• dependabot/pip/requirements/connexion-3.2.0
• dependabot/pip/requirements/cryptography-44.0.1
• dependabot/pip/requirements/deps-7b3319e34f
• dependabot/pip/requirements/flake8-7.2.0
• dependabot/pip/requirements/google-cloud-storage-2.19.0
• dependabot/pip/requirements/google-cloud-storage-3.0.0
• dependabot/pip/requirements/hypothesis-6.122.3
• dependabot/pip/requirements/hypothesis-6.130.3
• dependabot/pip/requirements/hypothesis-6.130.5
• dependabot/pip/requirements/hypothesis-6.131.0
• dependabot/pip/requirements/mozilla-version-3.2.0
• dependabot/pip/requirements/pip-compile-multi-3.1.0
• dependabot/pip/requirements/pyjwt-2.10.1
• dependabot/pip/requirements/pytest-asyncio-0.25.0
• dependabot/pip/requirements/pytest-asyncio-0.26.0
• dependabot/pip/requirements/python-jose-3.4.0
• dependabot/pip/requirements/requests-2.32.4
• dependabot/pip/requirements/sentry-sdk-flask--2.21.0
• dependabot/pip/requirements/sentry-sdk-flask--2.22.0
• dependabot/pip/requirements/sentry-sdk-flask--2.24.0
• dependabot/pip/requirements/sentry-sdk-flask--2.24.1
• dependabot/pip/requirements/setuptools-75.6.0
• dependabot/pip/requirements/setuptools-76.0.0
• dependabot/pip/requirements/setuptools-78.1.0
• dependabot/pip/requirements/setuptools-79.0.0
• dependabot/pip/requirements/sqlalchemy-2.0.37
• dependabot/pip/requirements/sqlalchemy-2.0.38
• dependabot/pip/requirements/sqlalchemy-2.0.39
• dependabot/pip/requirements/sqlalchemy-2.0.40
• dependabot/pip/requirements/tox-4.24.1
• dependabot/pip/requirements/tox-4.25.0
• deps
• deps-20241212
• deps-20250109
• deps-20250311
• deps-20250320
• deps-20250403
• deps-20250612
• disable-error-overlay
• dotenv
• drop-py39
• error-handlers
• fast-refresh
• fix-guardian-db-fixture
• fix-rule-cards-always-having-disabled-actions
• fix-version-in-decision-task
• flask-error-handler
• flask-request
• flask_app
• flaskapp
• gunicorn
• handleGeneralExceptions
• heads/refs/heads/main
• hneiva/docs-infra
• hneiva/fix-backend-docker
• hneiva/repin
• hneiva/tox-upgrade
• hneiva/vbump
• ignore-auth0-errors
• ignore-coveralls-failures
• insert-a-joke-about-leftpad-here
• issue3345
• issue3387
• jest
• json-apprelease
• localdev-mysql-interval
• make-ciscotest-permanent
• more-unused-stuff
• move-deploy-config
• nginx-rewrite-api
• no-compress
• no-refresh-tokens
• oops-forgot-some-garbage
• patch-1
• patch-3
• pip-compile-multi-uv
• pip-warnings
• pr-complete
• push-kxqrywwkroyk
• push-lskwuwlyzsuq
• push-lxvuyvlvozsn
• push-myoutovxkoxq
• push-nzprtvtyuvss
• push-psrxtntrlwky
• push-qkrluwnwqkrl
• push-szunttnpnkul
• push-txswrroxrkyr
• push-uxqvqslzwzkw
• push-vouxxqqovosp
• push-wqtoxvrmnnts
• push-xnmtlmxkzmuv
• push-yywslzkxunxs
• push-zwkqnnxyxxuk
• py313
• python-deps
• query-release-mapping
• ramda
• react-comment-smash-that-bell
• react-number-format
• reject-empty-pin
• reland-auth0
• remove-docker-compose-indirection
• remove-dotenv
• remove-engines-package-json
• remove-html-loader
• remove-mozilla-frontend-infra-components
• remove-react-router-dom
• remove-style-loader
• remove-useless-dep
• remove-yet-another-dep
• restore-utf8-locale-in-containers
• revert-3458-pip-compile-multi-uv
• revert-3466-dotenv
• revert-auth0
• revert-ciscotest
• revert-connexion3
• sentry-ignore-validation-errors
• shutoff-signoff
• sphinx
• split-python-lints
• sqlite-threads
• staging-update
• statsd-pipeline
• taskgraph
• tests-without-app
• try-buildkite
• unpin-deps
• update-deps
• update-python-deps
• update-version
• updates-disabled-cache
• uv
• vbump
• version-bump
• virtual-dom-deps
• warn-once
• we-dont-need-two-diff-libraries
• webpack
• who-cleans-the-cleaner

Build # #4954

Build Type

Pull #3548

circleci

Committed by Eijebong

Commit Message

Pass the state correctly to the `Link` component

This fixes a regression from c3f865c72
where updating react-router silently broke keeping some state across
navigation. The issue is that react router's API changed the state
property from being nested within the `to` object to being directly on
the routing components and the `to` component becoming a string. We
didn't see this at all because of the `Link` wrapper that was doing some
massaging on the `to` property when it wasn't a string, so we were just
silently discarding the state parameter.

I removed said massaging to since we're passing strings to `to`
everywhere now as we should.

Fixes #3547

Pull Request Pull Request #3548: Pass the state correctly to the `Link` component

Run Details

2162 of 2550 branches covered (84.78%)

Branch coverage included in aggregate %.

5692 of 6213 relevant lines covered (91.61%)

0.92 hits per line