mozilla-frontend-infra / perf-goggles

92%

master: 89%

Pull #21

travis-ci-com

Issue #20 - Do not concatenate signature IDs but do a fetch per signature ID

Hitting Perfherder's `{project}/performance/data` API with an `interval` and list of `signature_id` fails for the wasm misc cranelift configuration. [Here](https://treeherder.mozilla.org/api/project/mozilla-central/performance/data/?framework=10&interval=5184000&signature_id=1916484&signature_id=1916485)'s an example. For more details see [bug 1535432](https://bugzilla.mozilla.org/show_bug.cgi?id=1535432).

In order to work around it, I've decided to switch the library to fetch performance data for one signature at a time instead of one fetch with all subtests. For most benchmarks this change won't be noticeable, however, one that I've noticed to have problems is Mac Stylebench. The reason being that it changes from about 20+ fetches to over 400+ fetches. The pages takes ~30 seconds to load instead of ~20 seconds to load. The reason being that the browser does not do more than 6 concurrent fetches.

I believe this is an acceptable trade-off.

27 of 35 branches covered (77.14%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

96 of 98 relevant lines covered (97.96%)

86.05 hits per line