mosra / corrade

94%

master: 8%

LAST BUILD ON BRANCH array-deleter-fix

branch: array-deleter-fix

CHANGE BRANCH

x

Reset

• array-deleter-fix
• android
• appveyor-color
• ci-updates
• coverage
• coveralls
• debug-pointer
• doxygen
• filesystem
• interconnect-fix
• master
• mmap
• msvc2017
• next
• optional
• testsuite-file-diff
• tmp
• tmp-fix
• travis
• travis-sanitizers
• unicode

Build # 308

Build Type

push

travis-ci

Committed by mosra

Commit Message

Containers: get rid of defaultDeleter() template.

Because the function was templated and the Array code used a pointer to
it, this meant the function had to be emitted *somewhere*. This caused
all hell to break loose especially in case of plugins that returned
Array instances -- if the plugin was unloaded before all Array instances
returned from it were destructed, the deleter was suddenly a dangling
function pointer, causing crash on Array destruction.

Now `nullptr` is used instead of a pointer to `defaultDeleter()` -- if
`nullptr` is encountered, the standard `operator delete[]` is called,
without any potential function pointer dispatch.

In general, plugins should be forbidden to use custom deleters
completely, this just fixes the most common case where default deleter
is used.

Run Details

2331 of 2482 relevant lines covered (93.92%)

174.48 hits per line