moira-alert / moira

80%

master: 73%

LAST BUILD ON BRANCH feature/437-fix-nil-pointer-dereference

branch: feature/437-fix-nil-pointer-dereference

CHANGE BRANCH

x

Reset

• feature/437-fix-nil-pointer-dereference
• add-notifier-error-logging
• bump-go-version
• chan-struct
• cleanup-metrics-interface
• codeowners
• dded-a-second-request-for-triggers-after-receiving-errors
• develop
• do-not-select-db-manually
• extract-telemetry-config
• featue/change-handle-prepare-error
• feature-fix-alone-metrics-reply
• feature/171_bad_simpel_trigger_api
• feature/182-fix-update-trigger-handler
• feature/182_mark_all_dangerous_graphite_functions_as_such
• feature/188-fix-plot-window
• feature/192_add_user_and_time_on_maintenance_trigger
• feature/230-add-teams-handlers
• feature/230-connect-teams-and-subs
• feature/230-implement-teams-database-methods
• feature/342-fix-memory-leak-in-scorch-type
• feature/424-add-subscription-transfer-and-contact-deletion-cli
• feature/424-off-notifications-by-list-staff
• feature/426-add-subscription-transfer-and-contact-deletion-cli
• feature/428-improve-advanced-mode
• feature/429-metrics-mixed-up-in-graph-legend
• feature/457-add-pager-delete
• feature/457-stable-pagination
• feature/560-fix-goroutines-leak
• feature/593-remove-last-check-on-trigger-change
• feature/ErrTriggerHasSameMetricNames-rename
• feature/SPOP-trigger-ids-by-batches
• feature/add-metrics-export
• feature/add-reviewdog
• feature/add-teams
• feature/add_functions_for_templates
• feature/add_repace_to_templating
• feature/add_special_tag
• feature/added-pre-commit-and-git-lint
• feature/adding_remote_triggers_to_check_only_once
• feature/allow-one-metric-in-non-single-target
• feature/allow-stale-reads-for-pattern-metrics
• feature/bleve-scorch-index
• feature/bump-golangci-lint
• feature/carbon-api-fixes
• feature/change-handle-prepare-error
• feature/change_deploy_logic
• feature/check-no-metrics-triggers-anyway
• feature/ci-improve-image-naming
• feature/clean-up-unused-dependencies
• feature/codeql
• feature/community-guides
• feature/compose-add-restart
• feature/db_layer_metrics
• feature/debug_exception
• feature/deny-asterisk-patterns
• feature/detect_broken_contacts
• feature/disable_subscriptions
• feature/do-not-use-t1-on-one-target-triggers
• feature/docker-latest-nightly
• feature/fail_sturtup_api
• feature/filter-optimization
• feature/filter_cap_optimization
• feature/filter_optimizations
• feature/fix-alone-metrics-error-check-message
• feature/fix-alone-metrics-reply
• feature/fix-api-bugs
• feature/fix-carbonapi-pow-function
• feature/fix-checker-bugs
• feature/fix-empty-targets-fetch
• feature/fix-event-timestamp-on-maintenance
• feature/fix-filter-matching
• feature/fix-incorrect-regex-index
• feature/fix-large-ttl-oom
• feature/fix-last-check-removing
• feature/fix-metrics-copying
• feature/fix-notifier-logging
• feature/fix-plots-sending
• feature/fix-send-as-album
• feature/fix-telegram-bot-group-chats
• feature/fix-telegram-response
• feature/fix-telegram-spam
• feature/fix_last_successful_check_timestamp
• feature/fix_no_values_in_state
• feature/fix_test_selfstate
• feature/fix_trigger_check_params_bug
• feature/format_project
• feature/ft_result
• feature/fts_highlights
• feature/fts_results
• feature/get-right-maintenance
• feature/getmaintenanceinfomessage_to_notifier
• feature/go-1-14
• feature/go-1.12.4
• feature/go-uuid-update
• feature/golang-update
• feature/gomock-update
• feature/graphite_error_handling
• feature/handle-nometrics-lastchecks
• feature/ignore-ErrNoPointsToRender
• feature/ignore-sequential-dots-metrics
• feature/images_cleanup
• feature/improve-alone-metrics-exception-message
• feature/ldap_whitelist
• feature/local_grafana
• feature/magic-timestamps
• feature/mail_temlate
• feature/make-plot-great-again
• feature/metrics-sources-refactor
• feature/migrate-to-golangci-lint
• feature/mock-1-4
• feature/modules
• feature/moira-states-refactor
• feature/multiple-plots
• feature/new-ticks
• feature/new_metric_state
• feature/no_link_in_test_notifications
• feature/nodata-protection
• feature/nodata_protector_mvp
• feature/nodata_state_by_ttl
• feature/notifications-into-private-channels
• feature/notifier-metrics-by-state
• feature/oldschool-profiling
• feature/omit_empty_plots
• feature/panic-fix
• feature/panic_in_filter
• feature/pprof_heap
• feature/probePath
• feature/prometheus-366
• feature/prometheus-endpoint
• feature/proxy
• feature/redigo-update
• feature/redis_scan
• feature/refactor-GetTriggerChecks-retries
• feature/remove-deprecated-converters
• feature/reserve-external
• feature/revert-332
• feature/rewrite_self-state_check
• feature/search_by_contact_id
• feature/senders-tests
• feature/slack_client_update
• feature/slack_icons
• feature/slave_read
• feature/small-cleanups
• feature/small-fixes
• feature/small-fixes2
• feature/splitting_titles
• feature/staticcheck-fix
• feature/subscriptions_tags
• feature/suport_unicode_characters_like_emojis
• feature/switch-to-actions
• feature/tags
• feature/tags-series-by-tag
• feature/telegram-fixes
• feature/telegram-text-and-plot-in-one-message
• feature/templates-to-triger-description
• feature/test_on_a_non-primary_database
• feature/timeseries-in-checker-renames
• feature/trigger-maintenance-fix
• feature/trigger_type_validation
• feature/update-golang
• feature/update-linter
• feature/update-linter-version
• feature/update-makefile-added-cli
• feature/use-metric-name-from-t1
• feature/web_config
• feature/web_config_external
• feature/webhook
• fieldData
• fix-access-to-map-from-multiple-goroutines
• fix/api_update_subs
• fix/nil-pointer-subscription
• fix/panic_in_filter
• fix/plot_logs
• fix/trigger_check_method
• fix/webhook_url
• go-1.12.5
• goimports
• gomock_sh_script
• handle-crlf
• hotfix/do_not_add_empty_plots
• hotfix/dont-drop-events
• hotfix/downgradeSourcesRefactor
• hotfix/notification_logger
• hotfix/remote_http_responses
• improve-metrics-facade
• improvements
• init-metrics-facade-prefix
• introduce-metrics-facade
• launch-moira-from-sources-with-deps
• master
• new-ticks
• no-gitter
• optimize-dockerfiles
• optimize-metrics-parsing
• reature/replace-folders-and-files-by-go-standard
• receive-compressed-metrics
• redis_connection_limit
• refactor-exactly-once-tasks
• refactor-filter
• refactor/check-nil-pointers
• remove-deprecated-get-trigger-check-ids
• reuse-connection
• tests-in-docker
• travis_notifications
• v2.5.0
• v2.5.1
• warn-about-ignored-metrics-and-patterns
• yet-another-fix-access-to-map-from-multiple-goroutines

Build # 3548

Build Type

push

travis-ci-com

Committed by litleleprikon

Commit Message

fix(notifier): Handle nil pointer dereference

At notifier/plotting.go inside fetchAvailableSeries in case of error
returned from `metricsSource.Fetch` only
`local.ErrEvaluateTargetFailedWithPanic` was checked. Another errors did
not handled properly and function was trying to call mehods of fetch
result which became nil. That caused Nil Pointer Dereference panic. Add
proper error handling to prevent nil pointer dereference.

Closes #437

Run Details

6486 of 8094 relevant lines covered (80.13%)

38990.47 hits per line